DPDK patches and discussions
 help / color / mirror / Atom feed
From: Matan Azrad <matan@mellanox.com>
To: Dekel Peled <dekelp@mellanox.com>,
	Slava Ovsiienko <viacheslavo@mellanox.com>,
	Raslan Darawsheh <rasland@mellanox.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2] net/mlx5: fix VLAN item match for DV mode
Date: Wed, 12 Feb 2020 13:09:42 +0000	[thread overview]
Message-ID: <AM0PR0502MB4019888692001457C2FE168ED21B0@AM0PR0502MB4019.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <4db303faa3da7cb9490ab218dc6b8de34d212561.1581411317.git.dekelp@mellanox.com>



From: Dekel Peled
> Currently MLX5 PMD can't match on untagged packets specifically.
> Tagged traffic still hits the flows intended for untagged packets.
> If the flow has ETH, it will catch all matching packets, tagged and untagged.
> The solution is to use cvlan_tag bit.
> If mask=1 and value=0 it matches on untagged traffic.
> If mask=1 and value=1 it matches on tagged traffic.
> This is the kernel implementation.
> 
> This patch updated MLX5 PMD to set cvlan_tag mask and value according to
> flow rule contents.
> This update is relevant when using DV flow engine (dv_flow_en=1).
> 
> See example at
> https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdoc.d
> pdk.org%2Fguides%2Fnics%2Fmlx5.html%23limitations&amp;data=02%7C01
> %7Cmatan%40mellanox.com%7C4fdccf29506c4fd32ce708d7aee24ebe%7Ca6
> 52971c7d2e4d9ba6a4d149256f461b%7C0%7C0%7C637170159317867655&amp
> ;sdata=PVklEAti0Im%2FAXWuzDlizjxkVAyjCZSwF3vcYQ1x7fw%3D&amp;reser
> ved=0.
> 
> Fixes: fc2c498ccb94 ("net/mlx5: add Direct Verbs translate items")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Dekel Peled <dekelp@mellanox.com>
Acked-by: Matan Azrad <matan@mellanox.com>

  reply	other threads:[~2020-02-12 13:09 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-09 12:25 [dpdk-dev] [PATCH] net/mlx5: set VLAN tag matcher bit properly Dekel Peled
2020-02-09 18:09 ` Slava Ovsiienko
2020-02-11 11:05 ` [dpdk-dev] [PATCH v2] net/mlx5: fix VLAN item match for DV mode Dekel Peled
2020-02-12 13:09   ` Matan Azrad [this message]
2020-02-12 14:10   ` Raslan Darawsheh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AM0PR0502MB4019888692001457C2FE168ED21B0@AM0PR0502MB4019.eurprd05.prod.outlook.com \
    --to=matan@mellanox.com \
    --cc=dekelp@mellanox.com \
    --cc=dev@dpdk.org \
    --cc=rasland@mellanox.com \
    --cc=stable@dpdk.org \
    --cc=viacheslavo@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).