From: Matan Azrad <matan@mellanox.com>
To: Jack Min <jackmin@mellanox.com>, Ori Kam <orika@mellanox.com>,
Shahaf Shuler <shahafs@mellanox.com>,
Slava Ovsiienko <viacheslavo@mellanox.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"stable@dpdk.org" <stable@dpdk.org>,
Zhike Wang <wangzhike@jd.com>
Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix multiple flow table hash list
Date: Tue, 17 Dec 2019 08:39:02 +0000 [thread overview]
Message-ID: <AM0PR0502MB4019A3C2743BC2D093C8C5C2D2500@AM0PR0502MB4019.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <748a95b9f9030c78c55ddda4642915283de3f13b.1576487133.git.jackmin@mellanox.com>
> From: Xiaoyu Min
> The eth devices which share one ibv device only need one hash list of flow
> table.
>
> Currently, flow table hash list is created per each eth device whatever
> whether they share one ibv device or not.
>
> If the devices share one ibv device, the previously created hash list will
> become dangle because the pointer point to (sh->flow_tbls) is overwritten
> by the later created hast list.
>
> To fix this, just don't create hash list if it is already created.
>
> Fixes: 54534725d2f3 ("net/mlx5: fix flow table hash list conversion")
> Cc: stable@dpdk.org
>
> Reported-by: Zhike Wang <wangzhike@jd.com>
> Signed-off-by: Xiaoyu Min <jackmin@mellanox.com>
Acked-by: Matan Azrad <matan@mellanox.com>
next prev parent reply other threads:[~2019-12-17 8:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-16 9:27 Xiaoyu Min
2019-12-17 8:39 ` Matan Azrad [this message]
2019-12-17 12:13 ` Raslan Darawsheh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM0PR0502MB4019A3C2743BC2D093C8C5C2D2500@AM0PR0502MB4019.eurprd05.prod.outlook.com \
--to=matan@mellanox.com \
--cc=dev@dpdk.org \
--cc=jackmin@mellanox.com \
--cc=orika@mellanox.com \
--cc=shahafs@mellanox.com \
--cc=stable@dpdk.org \
--cc=viacheslavo@mellanox.com \
--cc=wangzhike@jd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).