From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id EA10CA04FB; Tue, 17 Dec 2019 09:39:05 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 28A542C60; Tue, 17 Dec 2019 09:39:05 +0100 (CET) Received: from EUR03-DB5-obe.outbound.protection.outlook.com (mail-eopbgr40078.outbound.protection.outlook.com [40.107.4.78]) by dpdk.org (Postfix) with ESMTP id E8FDF1F5; Tue, 17 Dec 2019 09:39:03 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iBKTf+txYlwKhkX8so+X6Zb1F4fH3idaG/8og3Xf/mxCg6Yf4rw8r4rglYvCpwf1Y6tlJvSNf380lkB6lVN7nFvQOZ6fAlyxM4uxMOvc2U3J5vvTMRC07RpGOCEpJrxMvQjzxy7MfXWEKcol5j0UutHqc8QSZo1/ELg74tgCLFxB0S7DkTgWxaE+XBAU8wmgs7jxxaze4CJ1Ds7lPey3jR21xh84BAMnSZRnXz0l6iMMf/WfhHBXkrqosBgXg7zHhbUsjvYAoP30nXL5pj8my1ENkHQtoRrchTgmDJRaJ5+0LSt3zRTI22RWnAXJhg6XcfoCDIqz+qe5M5fjaxTSeA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0ywBIGZqoRAvjxTee7oKhcdpRuHbEPB3a3O3d1J2/Ys=; b=LSaA570YPnNBoyjJOrpsqbeS4gZ4q5MlWYILi8Ze7tc3QcywjiTNx65SLc7uOaW67QbiaYcBqVsM3j7sVY+94oXdx95gjeTRY2yU250yKkDNU5Z/7rRnx4uSEEYDq3M3z1qGRbKD6ZhQ+dP+XwnDpvOI4eP7A0dFc0aRAZwx/X5LsY8BxhCaJmxftLvwjORa5hMbc7ay83TugXc0mEgZvw4NEFVE8dRgCr3Lr/9i1ENg22PPbP+Mm2RCmvOP2OpfmXjWzjJVjJFsyHdtxcFX8sJ5BzUacm6ygM/vGswt9X06JvlIbRFSd2ikYM3i+RxS2sT8G5jVRX135vXKHSjvKw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0ywBIGZqoRAvjxTee7oKhcdpRuHbEPB3a3O3d1J2/Ys=; b=gxCfiE2iB3CukbisMjMJo4Sj5CBx250CI7zQbwiG5v4gjrBK0ehXNBopRslDLHb4apgpjjXuMAVIWlc/2Y7bjiKWXMdLaOxqOSSBIMKtvk+/eBPrXrrwAUptLdkAB9VjaUy1eQBq5CVRkGTMwYCw9iqpFIxwjCVboR2SK/m1bZk= Received: from AM0PR0502MB4019.eurprd05.prod.outlook.com (52.133.39.139) by AM0PR0502MB3635.eurprd05.prod.outlook.com (52.133.46.140) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2538.18; Tue, 17 Dec 2019 08:39:02 +0000 Received: from AM0PR0502MB4019.eurprd05.prod.outlook.com ([fe80::6008:b453:cb1c:9445]) by AM0PR0502MB4019.eurprd05.prod.outlook.com ([fe80::6008:b453:cb1c:9445%5]) with mapi id 15.20.2559.012; Tue, 17 Dec 2019 08:39:02 +0000 From: Matan Azrad To: Jack Min , Ori Kam , Shahaf Shuler , Slava Ovsiienko CC: "dev@dpdk.org" , "stable@dpdk.org" , Zhike Wang Thread-Topic: [PATCH] net/mlx5: fix multiple flow table hash list Thread-Index: AQHVs/Mvl+Ii9GY3gk2BE7pg5YMpl6e+AqBQ Date: Tue, 17 Dec 2019 08:39:02 +0000 Message-ID: References: <748a95b9f9030c78c55ddda4642915283de3f13b.1576487133.git.jackmin@mellanox.com> In-Reply-To: <748a95b9f9030c78c55ddda4642915283de3f13b.1576487133.git.jackmin@mellanox.com> Accept-Language: en-US, he-IL Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=matan@mellanox.com; x-originating-ip: [77.127.34.201] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: f8139711-c8c4-4476-aef9-08d782cc91d7 x-ms-traffictypediagnostic: AM0PR0502MB3635:|AM0PR0502MB3635: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3173; x-forefront-prvs: 02543CD7CD x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(136003)(39860400002)(396003)(376002)(366004)(346002)(199004)(189003)(52536014)(110136005)(5660300002)(6506007)(66446008)(64756008)(66556008)(66476007)(66946007)(6636002)(76116006)(7696005)(4744005)(186003)(8676002)(81156014)(316002)(4326008)(8936002)(9686003)(2906002)(478600001)(81166006)(55016002)(26005)(86362001)(71200400001)(33656002)(54906003); DIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR0502MB3635; H:AM0PR0502MB4019.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: SO1yD1g55nAbpsdNSEP4L3EP0oyxVS/DwIoWZWTqmoitKL35WorZVXHCfhKRFwUUUKIp18+GjMmtTasI7SpMP+p1R5yD/z9C9rvCVB8IgLxkW994vxRxNAT1au0wfhH78PO/If0b7fw+vYSAGUpa6PjNfMIRb+gVihj21UFuTou39JtERfCOKEZZnNutcZpFjQNeYUk6sQ69SlbZEqmMMGroRj+v4B6vAceit1DNQCHoSzBl76W2zbUKeU55UDyI+6Mcb0cNU/rjj7dVkou5SO54WGa9PUd6Tq47u5nGJFWlSnsvBZQg6yoXV2+TipZXEW24TRBQfYZhJQVonlNzR7+J32y60UvOnn8k9Nni6+pFgt0dpDbX+/RA0WCZxHkCIzsbtc/38ONHKRwLHAzdJ3hl+9WF8WZ1BRgoxBNwX46zBjQrDQzVkO71IkUvA+I0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: f8139711-c8c4-4476-aef9-08d782cc91d7 X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Dec 2019 08:39:02.6416 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 3MLetmkXQOYT9dYIVGsSiv5SpX8dC6Haqsrm9C41o0uCeH3I/IU9D1q2ieoA73eThCHQUsvHmVuhYuDLe9OObA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR0502MB3635 Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix multiple flow table hash list X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > From: Xiaoyu Min > The eth devices which share one ibv device only need one hash list of flo= w > table. >=20 > Currently, flow table hash list is created per each eth device whatever > whether they share one ibv device or not. >=20 > If the devices share one ibv device, the previously created hash list wil= l > become dangle because the pointer point to (sh->flow_tbls) is overwritten > by the later created hast list. >=20 > To fix this, just don't create hash list if it is already created. >=20 > Fixes: 54534725d2f3 ("net/mlx5: fix flow table hash list conversion") > Cc: stable@dpdk.org >=20 > Reported-by: Zhike Wang > Signed-off-by: Xiaoyu Min Acked-by: Matan Azrad