From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D2407A00C4; Thu, 31 Oct 2019 16:13:28 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 15FF01C196; Thu, 31 Oct 2019 16:13:27 +0100 (CET) Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-eopbgr140059.outbound.protection.outlook.com [40.107.14.59]) by dpdk.org (Postfix) with ESMTP id 0F7CC1C190 for ; Thu, 31 Oct 2019 16:13:26 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=L0fy8uaXvFd/EmgRnfwZ+95bpE2zl7ycrpVVsS89zWyPjLOdDRQADmCP8xKOmlmK4WfY/XxAmj2nGGtAKblrDgDClcYAFwXHZ5uXcQJJD/HsM9WXF+Z1ky0JjHWg1ml8KAnWofqr08i2VPzJUv0FQ14V8hFRzcEcN0PvMtcMGMIF9pmP/4E48qnntnc3xihedkiVYTbmT3hFTN+ZuB4u45M7A7OQCWTJyPKJDhrv7NGsJav/KmOplZBxpA3yKBJuCRykUXf9urr2BvKqvGXM8XnQg6EqYBSed5yySbZfHtxD9gvjA7o15ybxShtVDln9bTdCCwGJ5bOVHq3UtzFHGA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dhdrD0SZFOYhEtbl/C7PN9u33Pv9Vf99oMMa4Bqv1Us=; b=iZyszd2vsrjma9Vzk7hpeRerKz23qLOSAOcEssbRVnLxf5KSie9GqY+D+vt0jmZu8GcYLGY9mMgaqUUjnfYUcEbvuuVspZc2vDe3JMu74cxkcW5PDqq9gVseL+rkVLerGH2PyAcVLSJ1mdk/WitRZnnO+jX8cuePfypigYRKMZXevVnYRYgx5G3BXujZ+tOWPJnbCJs9aXpc6xXHzTJqJjZ43SxwP2KeQI4C/NG1kvJO44U3r9F/ZywpMZTHf7RiQdbE6pE2YTEX9f+ptUZCzt4FhrlarQ6/OKy3x3KL0DgNUlO/kQ2JsasydxRj+Txv4ttyJVvpWg5iFKccpBQSoA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dhdrD0SZFOYhEtbl/C7PN9u33Pv9Vf99oMMa4Bqv1Us=; b=BXfMfUuU7MFmo5DUUrkoH0FIzh/22nlYKc82rMXTKo9dmVaCY2x/BZunjGb5gATbP+kvWjmRs+0rgKQFFA/SPI89OBFGiNm0MjIIYY/sgpRPgYz2rOwlPHXtCLkMz5gBPOscO0KR7ie0GaFKujPbHV5N8ScD2pM65NNhdtDhX6w= Received: from AM0PR0502MB4019.eurprd05.prod.outlook.com (52.133.39.139) by AM0PR0502MB3683.eurprd05.prod.outlook.com (52.133.50.152) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2387.24; Thu, 31 Oct 2019 15:13:24 +0000 Received: from AM0PR0502MB4019.eurprd05.prod.outlook.com ([fe80::fd7a:e5a8:deec:c1b0]) by AM0PR0502MB4019.eurprd05.prod.outlook.com ([fe80::fd7a:e5a8:deec:c1b0%7]) with mapi id 15.20.2387.028; Thu, 31 Oct 2019 15:13:24 +0000 From: Matan Azrad To: "pbhagavatula@marvell.com" , "ferruh.yigit@intel.com" , "arybchenko@solarflare.com" , "jerinj@marvell.com" , Thomas Monjalon CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v15 3/7] ethdev: add validation to offloads set by PMD Thread-Index: AQHVjm7bOLjUGRTIuUGVwwwER6sV0qd02rDg Date: Thu, 31 Oct 2019 15:13:24 +0000 Message-ID: References: <20191029050312.2715-1-pbhagavatula@marvell.com> <20191029153722.4547-1-pbhagavatula@marvell.com> <20191029153722.4547-4-pbhagavatula@marvell.com> In-Reply-To: <20191029153722.4547-4-pbhagavatula@marvell.com> Accept-Language: en-US, he-IL Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=matan@mellanox.com; x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 408a0886-a9f5-4a45-bb75-08d75e14dfe2 x-ms-traffictypediagnostic: AM0PR0502MB3683: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7691; x-forefront-prvs: 02070414A1 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(396003)(366004)(346002)(376002)(136003)(39860400002)(199004)(189003)(4326008)(2201001)(478600001)(14454004)(7696005)(64756008)(6506007)(74316002)(81156014)(81166006)(25786009)(5660300002)(66556008)(102836004)(229853002)(66946007)(99286004)(476003)(7736002)(86362001)(305945005)(76176011)(66476007)(33656002)(71200400001)(9686003)(446003)(6436002)(486006)(71190400001)(3846002)(55016002)(11346002)(66446008)(76116006)(52536014)(8936002)(26005)(14444005)(256004)(110136005)(6116002)(66066001)(316002)(2906002)(4744005)(6246003)(2501003)(186003); DIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR0502MB3683; H:AM0PR0502MB4019.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: DbhXVLusEzBtB+oK63J3ucyB6OcwS3wE4s+b2hs+wRkL/N9Di63kj1Zij3U9Gyqw/hnEqwmLbpoG0ubKC2QZBrr815VX3M93HF/grXwtP76Mv7OWYaiRVkkI1iJC5bjK5WPCGnbdOgwzevmmIVtXeJ36tXyWKfgKUHyfb+pOZnDW2YRnvfOZTdu9M8Z9sv4sEW4t6J1H/89PszwONE8deriK5Y7n6o3ZZ+D2CilvLnhFvaUn/ZN9oTd1disX2X8w4tiYIjSRL6e2pHnl8xarPbaq2mZiNgLKzQXXJx8z2DSqrlW67KPPm5Rd5jrpuyyz1zFSxFCvwsF4CaFDkydq0iyZzw+sJJUh0J33VKZeuhCm0aClN+6AM2Y8XMR/rkbkPXO5CfXbOxJjnt7zGjFaZEZhu0eK5vjI97+Gkj3etQ8ZjB9458EUSfQ3fCg27bh0 x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 408a0886-a9f5-4a45-bb75-08d75e14dfe2 X-MS-Exchange-CrossTenant-originalarrivaltime: 31 Oct 2019 15:13:24.3010 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: /4eLauOtBT8hw6poF874G/AEWt1mI4wIJmnd0+DzIxtUb5wE7FMsddGg/Sd85X7lXX3fUGIVa0kfIPPR0Lfnag== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR0502MB3683 Subject: Re: [dpdk-dev] [PATCH v15 3/7] ethdev: add validation to offloads set by PMD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Pavan From: Pavan Nikhilesh > Some PMDs cannot work when certain offloads are enable/disabled, as a > workaround PMDs auto enable/disable offloads internally and expose it > through dev->data->dev_conf.rxmode.offloads. >=20 > After device specific dev_configure is called compare the requested offlo= ads > to the offloads exposed by the PMD and, if the PMD failed to enable a giv= en > offload then log it and return -EINVAL from rte_eth_dev_configure, else i= f > the PMD failed to disable a given offload log and continue with > rte_eth_dev_configure. > rte_eth_dev_configure can be called more than 1 time in the device life tim= e, How can you know what is the minimum offload configurations required by the= port after the first call? Maybe putting it in dev info is better, what do you think? Matan