From: Matan Azrad <matan@mellanox.com>
To: Asaf Penso <asafp@mellanox.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: Slava Ovsiienko <viacheslavo@mellanox.com>,
Dekel Peled <dekelp@mellanox.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix call to modify action without init item
Date: Thu, 26 Mar 2020 08:37:47 +0000 [thread overview]
Message-ID: <AM0PR0502MB4019A9E7B0A4B5AE084A6611D2CF0@AM0PR0502MB4019.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <1585165998-14221-1-git-send-email-asafp@mellanox.com>
From: Asaf Penso
> The item is being set according to the attribute value, whether it is udp/tcp or
> ipv4/6.
> Also, there are two condition calls.
>
> If the attribute is neither udp/tcp or ipv4/6 the item is not initialized at all, but
> the call to the flow_dv_convert_modify_action is still being done.
> Also, even if the attribute is tcp/udp or ipv4/6, we still have two conditions.
>
> This patch changes the conditions, so the item will always be set.
> By doing this, there is also a save in the number of condition calls.
>
> Fixes: 4bb14c83 ("net/mlx5: support modify header using Direct Verbs")
> Cc: stable@dpdk.org
>
> Signed-off-by: Asaf Penso <asafp@mellanox.com>
> Reviewed-by: Dekel Peled <dekelp@mellanox.com>
Acked-by: Matan Azrad <matan@mellanox.com>
next prev parent reply other threads:[~2020-03-26 8:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-25 19:53 Asaf Penso
2020-03-26 8:37 ` Matan Azrad [this message]
2020-03-29 11:17 ` Raslan Darawsheh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM0PR0502MB4019A9E7B0A4B5AE084A6611D2CF0@AM0PR0502MB4019.eurprd05.prod.outlook.com \
--to=matan@mellanox.com \
--cc=asafp@mellanox.com \
--cc=dekelp@mellanox.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
--cc=viacheslavo@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).