From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1B8A5A057C; Thu, 26 Mar 2020 09:37:51 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 13C0D1C06D; Thu, 26 Mar 2020 09:37:50 +0100 (CET) Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80088.outbound.protection.outlook.com [40.107.8.88]) by dpdk.org (Postfix) with ESMTP id E7B50374C; Thu, 26 Mar 2020 09:37:48 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=D+IomsCcKTSLmd5cU0pLLZF4gZhkHbMUcsXs9+Wi+iqXVje+RFdTnaOwRuDGFC/pA+iX0a25dXvW7tM9njFd5kSS+yamB9lhPxfYR3MfcHw3z+rcmbovs0JWWJajteKK9HFMkwo77UiR7/SnGD280wlHnCmuHJfH8MkWVQtbRMDEkOJch/bLAXQPzp99SJoGdQA+8bwcy8U8luuyMOj+VfA7FViknvgCFPAfD2k3Onf9HvWCb8ECFlUSdYgv8Qrk53+i1QBVW/beJoK6LD8QxHzKkM2/SBIsRI136bKg7gVh8SdRfP6yogEpniw7e1YghX31dHnXJVafXXN9uoyXmw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=02TdDNvTQM0Fj57gJeCymg5WkY5E/rrc/s6swq+nA4o=; b=MyIPIyOrweO9jhbtYjcl/oCCwRBExF5yN52leTg9tyTjGjaFGIdUvkuDZ65jEYo6dJ7ce+DANG/xBPAb6HXsKZ6uOmItMLYf/PTi2n+X2yfXytfJTk/Rm0m0JgIXk22Dh8B7L+Lpzz8zDafxewHXd5dh0+3V7nfmqpAZ4RNlhOf5goK2aOgb0n/xvOx5Rj0tFXrn7BzMIl4Re3bVFJ+EutEiLchP3lYE+7bQ+PP9hKVAYqtMdKuNkgBHm4hK3EAdpINdgozvBUF28jKcfATeX+9dKyzdb82lpmccoMm1XZtdGzv6jntTwVk1Z5sa/lqKTcl+WqWaQTGB9wSoCycTaQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=02TdDNvTQM0Fj57gJeCymg5WkY5E/rrc/s6swq+nA4o=; b=si1dbwwUXRxLr5HzUcGX5X9XljAQjIXNkZbDRD9jlRH48ZqfXeI/zCXgxvk2yVYKoASYUkbDmvXsOAgRYomWeDqhdOjnhYz8+9HE5FccbplrAdzYZH4daduN/CNO6TKQrg7Vs/G8Cde29gxb48kCL//k49J36j1ksGG3oxRjZjQ= Received: from AM0PR0502MB4019.eurprd05.prod.outlook.com (52.133.39.139) by AM0PR0502MB3761.eurprd05.prod.outlook.com (52.133.50.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2856.19; Thu, 26 Mar 2020 08:37:48 +0000 Received: from AM0PR0502MB4019.eurprd05.prod.outlook.com ([fe80::a564:a117:9022:1fee]) by AM0PR0502MB4019.eurprd05.prod.outlook.com ([fe80::a564:a117:9022:1fee%7]) with mapi id 15.20.2856.018; Thu, 26 Mar 2020 08:37:48 +0000 From: Matan Azrad To: Asaf Penso , "dev@dpdk.org" CC: Slava Ovsiienko , Dekel Peled , "stable@dpdk.org" Thread-Topic: [PATCH] net/mlx5: fix call to modify action without init item Thread-Index: AQHWAt8NYGPRDIcj5kGa9yHNuJswN6hajcCA Date: Thu, 26 Mar 2020 08:37:47 +0000 Message-ID: References: <1585165998-14221-1-git-send-email-asafp@mellanox.com> In-Reply-To: <1585165998-14221-1-git-send-email-asafp@mellanox.com> Accept-Language: en-US, he-IL Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=matan@mellanox.com; x-originating-ip: [77.125.94.232] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 0c59423f-8ae3-44c2-54b5-08d7d160f693 x-ms-traffictypediagnostic: AM0PR0502MB3761:|AM0PR0502MB3761: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-forefront-prvs: 0354B4BED2 x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM0PR0502MB4019.eurprd05.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(10009020)(4636009)(376002)(396003)(39860400002)(366004)(136003)(346002)(186003)(26005)(5660300002)(8676002)(316002)(110136005)(54906003)(76116006)(66946007)(66446008)(66556008)(33656002)(8936002)(478600001)(66476007)(64756008)(6506007)(81156014)(81166006)(52536014)(9686003)(86362001)(450100002)(71200400001)(4326008)(2906002)(4744005)(7696005)(55016002); DIR:OUT; SFP:1101; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: c9vGTaKWeCVSoFyzm6bshbrG6z3Fa8VFG6uZGNOMbaQh6++sfcDD3daUFZzG892b27CbLuZVzM8vnOWGVmrVDXgtXM+R7EVsqKa72ULGb6kDPA8WEWKT0doN9CVVVPsUnUmdhgFlX56oqd7ZOfRZjZvNZX3CCjL5OXslVj+29h+n5iyYN6eSHtWLp0nkoq7R7d7Y3oCS8RRwzIPUzvn24pgKZLBRLlSezGPw98QPG/830/lVHw4A9gD0d1ZuZUHbFsknikc8xONmYX1va9BltPcWAtUhZ7jaEkILJkWNknvjnqAudWQ4ap1s69RHkTrziXF9cBY1NG81+19xDxXlEcM/Atw7KnARiVTcznklYs7Cnw/NV8iDgxvtDTWFS1CLmtr5/8gCwo7/qNpSPcVOE/ajLjnnfmPGzQoOSPMT76N6pDIJdMhR230nJQ+aWlVx x-ms-exchange-antispam-messagedata: /z8Vf1Qz/yFFdEiPCzJXmliY6nuJBu2H9JS/zhPlD58V4o7VeA3fYnwyivGkxSM+eRyg8AdIgcPuLTRS1yEoCDvbCiiApOHoqRsZ2qDAZiEMNfz+78a6EgCLMCOc0gzmz7zViTt0REvVowKMuSuo5A== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0c59423f-8ae3-44c2-54b5-08d7d160f693 X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Mar 2020 08:37:47.9261 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 2zY4k5TWKZ3yoHRRAfW41Ld/zpTxb/tCwDxKYDZEY9ZSUdg5v0lHhn8kBCICzgHBuAObupd45mK+hgGK/bzmIw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR0502MB3761 Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix call to modify action without init item X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Asaf Penso > The item is being set according to the attribute value, whether it is udp= /tcp or > ipv4/6. > Also, there are two condition calls. >=20 > If the attribute is neither udp/tcp or ipv4/6 the item is not initialized= at all, but > the call to the flow_dv_convert_modify_action is still being done. > Also, even if the attribute is tcp/udp or ipv4/6, we still have two condi= tions. >=20 > This patch changes the conditions, so the item will always be set. > By doing this, there is also a save in the number of condition calls. >=20 > Fixes: 4bb14c83 ("net/mlx5: support modify header using Direct Verbs") > Cc: stable@dpdk.org >=20 > Signed-off-by: Asaf Penso > Reviewed-by: Dekel Peled Acked-by: Matan Azrad