DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [Bug 335] Compilation fails when HEADROOM is 0
@ 2019-07-24 15:34 bugzilla
  2019-07-24 15:37 ` Matan Azrad
  0 siblings, 1 reply; 5+ messages in thread
From: bugzilla @ 2019-07-24 15:34 UTC (permalink / raw)
  To: dev

https://bugs.dpdk.org/show_bug.cgi?id=335

            Bug ID: 335
           Summary: Compilation fails when HEADROOM is 0
           Product: DPDK
           Version: unspecified
          Hardware: All
                OS: All
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: ethdev
          Assignee: dev@dpdk.org
          Reporter: matan@mellanox.com
  Target Milestone: ---

The compilation error:
In file included from
/auto/mtrswgwork/matan/reps/matan_rep/dpdk.org/drivers/bus/fslmc/portal/dpaa2_hw_dpbp.c:28:0:
/auto/mtrswgwork/matan/reps/matan_rep/dpdk.org/drivers/bus/fslmc/portal/dpaa2_hw_pvt.h:76:2:
error: #error "Annotation requirement is more than RTE_PKTMBUF_HEADROOM"
 #error "Annotation requirement is more than RTE_PKTMBUF_HEADROOM"
  ^
cc1: error: unrecognized command line option "-Wno-address-of-packed-member"
[-Werror]
cc1: all warnings being treated as errors
make[6]: *** [portal/dpaa2_hw_dpbp.o] Error 1
make[6]: *** Waiting for unfinished jobs....
In file included from
/auto/mtrswgwork/matan/reps/matan_rep/dpdk.org/drivers/bus/fslmc/portal/dpaa2_hw_dpio.c:37:0:
/auto/mtrswgwork/matan/reps/matan_rep/dpdk.org/drivers/bus/fslmc/portal/dpaa2_hw_pvt.h:76:2:
error: #error "Annotation requirement is more than RTE_PKTMBUF_HEADROOM"
 #error "Annotation requirement is more than RTE_PKTMBUF_HEADROOM"
  ^
cc1: error: unrecognized command line option "-Wno-address-of-packed-member"
[-Werror]
cc1: all warnings being treated as errors
make[6]: *** [portal/dpaa2_hw_dpio.o] Error 1
In file included from
/auto/mtrswgwork/matan/reps/matan_rep/dpdk.org/drivers/bus/fslmc/portal/dpaa2_hw_dpci.c:26:0:
/auto/mtrswgwork/matan/reps/matan_rep/dpdk.org/drivers/bus/fslmc/portal/dpaa2_hw_pvt.h:76:2:
error: #error "Annotation requirement is more than RTE_PKTMBUF_HEADROOM"
 #error "Annotation requirement is more than RTE_PKTMBUF_HEADROOM"
  ^
cc1: error: unrecognized command line option "-Wno-address-of-packed-member"
[-Werror]
cc1: all warnings being treated as errors
make[6]: *** [portal/dpaa2_hw_dpci.o] Error 1
In file included from
/auto/mtrswgwork/matan/reps/matan_rep/dpdk.org/drivers/bus/fslmc/fslmc_vfio.c:40:0:
/auto/mtrswgwork/matan/reps/matan_rep/dpdk.org/drivers/bus/fslmc/portal/dpaa2_hw_pvt.h:76:2:
error: #error "Annotation requirement is more than RTE_PKTMBUF_HEADROOM"
 #error "Annotation requirement is more than RTE_PKTMBUF_HEADROOM"
  ^

-- 
You are receiving this mail because:
You are the assignee for the bug.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dpdk-dev] [Bug 335] Compilation fails when HEADROOM is 0
  2019-07-24 15:34 [dpdk-dev] [Bug 335] Compilation fails when HEADROOM is 0 bugzilla
@ 2019-07-24 15:37 ` Matan Azrad
  2019-07-24 16:24   ` Stephen Hemminger
  0 siblings, 1 reply; 5+ messages in thread
From: Matan Azrad @ 2019-07-24 15:37 UTC (permalink / raw)
  To: Hemant Agrawal, sachin.saxena; +Cc: dev

Hi Hemant, Sachin

Looks like issue in dpaa.
Please check.

> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of bugzilla@dpdk.org
> Sent: Wednesday, July 24, 2019 6:35 PM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [Bug 335] Compilation fails when HEADROOM is 0
> 
> https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugs.
> dpdk.org%2Fshow_bug.cgi%3Fid%3D335&amp;data=02%7C01%7Cmatan%40
> mellanox.com%7Cef4c519dd7b1495178f808d7104c7400%7Ca652971c7d2e4d9
> ba6a4d149256f461b%7C0%7C0%7C636995792862104273&amp;sdata=DrdcCJ
> mYUMZxk3j%2F%2BxPlqXMOAb9GDNBPzSNzpifzcMU%3D&amp;reserved=0
> 
>             Bug ID: 335
>            Summary: Compilation fails when HEADROOM is 0
>            Product: DPDK
>            Version: unspecified
>           Hardware: All
>                 OS: All
>             Status: UNCONFIRMED
>           Severity: normal
>           Priority: Normal
>          Component: ethdev
>           Assignee: dev@dpdk.org
>           Reporter: matan@mellanox.com
>   Target Milestone: ---
> 
> The compilation error:
> In file included from
> /auto/mtrswgwork/matan/reps/matan_rep/dpdk.org/drivers/bus/fslmc/po
> rtal/dpaa2_hw_dpbp.c:28:0:
> /auto/mtrswgwork/matan/reps/matan_rep/dpdk.org/drivers/bus/fslmc/po
> rtal/dpaa2_hw_pvt.h:76:2:
> error: #error "Annotation requirement is more than
> RTE_PKTMBUF_HEADROOM"
>  #error "Annotation requirement is more than RTE_PKTMBUF_HEADROOM"
>   ^
> cc1: error: unrecognized command line option "-Wno-address-of-packed-
> member"
> [-Werror]
> cc1: all warnings being treated as errors
> make[6]: *** [portal/dpaa2_hw_dpbp.o] Error 1
> make[6]: *** Waiting for unfinished jobs....
> In file included from
> /auto/mtrswgwork/matan/reps/matan_rep/dpdk.org/drivers/bus/fslmc/po
> rtal/dpaa2_hw_dpio.c:37:0:
> /auto/mtrswgwork/matan/reps/matan_rep/dpdk.org/drivers/bus/fslmc/po
> rtal/dpaa2_hw_pvt.h:76:2:
> error: #error "Annotation requirement is more than
> RTE_PKTMBUF_HEADROOM"
>  #error "Annotation requirement is more than RTE_PKTMBUF_HEADROOM"
>   ^
> cc1: error: unrecognized command line option "-Wno-address-of-packed-
> member"
> [-Werror]
> cc1: all warnings being treated as errors
> make[6]: *** [portal/dpaa2_hw_dpio.o] Error 1 In file included from
> /auto/mtrswgwork/matan/reps/matan_rep/dpdk.org/drivers/bus/fslmc/po
> rtal/dpaa2_hw_dpci.c:26:0:
> /auto/mtrswgwork/matan/reps/matan_rep/dpdk.org/drivers/bus/fslmc/po
> rtal/dpaa2_hw_pvt.h:76:2:
> error: #error "Annotation requirement is more than
> RTE_PKTMBUF_HEADROOM"
>  #error "Annotation requirement is more than RTE_PKTMBUF_HEADROOM"
>   ^
> cc1: error: unrecognized command line option "-Wno-address-of-packed-
> member"
> [-Werror]
> cc1: all warnings being treated as errors
> make[6]: *** [portal/dpaa2_hw_dpci.o] Error 1 In file included from
> /auto/mtrswgwork/matan/reps/matan_rep/dpdk.org/drivers/bus/fslmc/fsl
> mc_vfio.c:40:0:
> /auto/mtrswgwork/matan/reps/matan_rep/dpdk.org/drivers/bus/fslmc/po
> rtal/dpaa2_hw_pvt.h:76:2:
> error: #error "Annotation requirement is more than
> RTE_PKTMBUF_HEADROOM"
>  #error "Annotation requirement is more than RTE_PKTMBUF_HEADROOM"
>   ^
> 
> --
> You are receiving this mail because:
> You are the assignee for the bug.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dpdk-dev] [Bug 335] Compilation fails when HEADROOM is 0
  2019-07-24 15:37 ` Matan Azrad
@ 2019-07-24 16:24   ` Stephen Hemminger
  2019-07-24 16:40     ` Matan Azrad
  0 siblings, 1 reply; 5+ messages in thread
From: Stephen Hemminger @ 2019-07-24 16:24 UTC (permalink / raw)
  To: Matan Azrad; +Cc: Hemant Agrawal, sachin.saxena, dev

On Wed, 24 Jul 2019 15:37:40 +0000
Matan Azrad <matan@mellanox.com> wrote:

> Hi Hemant, Sachin
> 
> Looks like issue in dpaa.
> Please check.
> 
> > -----Original Message-----
> > From: dev <dev-bounces@dpdk.org> On Behalf Of bugzilla@dpdk.org
> > Sent: Wednesday, July 24, 2019 6:35 PM
> > To: dev@dpdk.org
> > Subject: [dpdk-dev] [Bug 335] Compilation fails when HEADROOM is 0
> > 
> > https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugs.
> > dpdk.org%2Fshow_bug.cgi%3Fid%3D335&amp;data=02%7C01%7Cmatan%40
> > mellanox.com%7Cef4c519dd7b1495178f808d7104c7400%7Ca652971c7d2e4d9
> > ba6a4d149256f461b%7C0%7C0%7C636995792862104273&amp;sdata=DrdcCJ
> > mYUMZxk3j%2F%2BxPlqXMOAb9GDNBPzSNzpifzcMU%3D&amp;reserved=0
> > 
> >             Bug ID: 335
> >            Summary: Compilation fails when HEADROOM is 0
> >            Product: DPDK
> >            Version: unspecified
> >           Hardware: All
> >                 OS: All
> >             Status: UNCONFIRMED
> >           Severity: normal
> >           Priority: Normal
> >          Component: ethdev
> >           Assignee: dev@dpdk.org
> >           Reporter: matan@mellanox.com
> >   Target Milestone: ---
> > 
> > The compilation error:
> > In file included from
> > /auto/mtrswgwork/matan/reps/matan_rep/dpdk.org/drivers/bus/fslmc/po
> > rtal/dpaa2_hw_dpbp.c:28:0:
> > /auto/mtrswgwork/matan/reps/matan_rep/dpdk.org/drivers/bus/fslmc/po
> > rtal/dpaa2_hw_pvt.h:76:2:
> > error: #error "Annotation requirement is more than
> > RTE_PKTMBUF_HEADROOM"
> >  #error "Annotation requirement is more than RTE_PKTMBUF_HEADROOM"
> >   ^
> > cc1: error: unrecognized command line option "-Wno-address-of-packed-
> > member"
> > [-Werror]
> > cc1: all warnings being treated as errors
> > make[6]: *** [portal/dpaa2_hw_dpbp.o] Error 1
> > make[6]: *** Waiting for unfinished jobs....
> > In file included from
> > /auto/mtrswgwork/matan/reps/matan_rep/dpdk.org/drivers/bus/fslmc/po
> > rtal/dpaa2_hw_dpio.c:37:0:
> > /auto/mtrswgwork/matan/reps/matan_rep/dpdk.org/drivers/bus/fslmc/po
> > rtal/dpaa2_hw_pvt.h:76:2:
> > error: #error "Annotation requirement is more than
> > RTE_PKTMBUF_HEADROOM"
> >  #error "Annotation requirement is more than RTE_PKTMBUF_HEADROOM"
> >   ^
> > cc1: error: unrecognized command line option "-Wno-address-of-packed-
> > member"
> > [-Werror]
> > cc1: all warnings being treated as errors
> > make[6]: *** [portal/dpaa2_hw_dpio.o] Error 1 In file included from
> > /auto/mtrswgwork/matan/reps/matan_rep/dpdk.org/drivers/bus/fslmc/po
> > rtal/dpaa2_hw_dpci.c:26:0:
> > /auto/mtrswgwork/matan/reps/matan_rep/dpdk.org/drivers/bus/fslmc/po
> > rtal/dpaa2_hw_pvt.h:76:2:
> > error: #error "Annotation requirement is more than
> > RTE_PKTMBUF_HEADROOM"
> >  #error "Annotation requirement is more than RTE_PKTMBUF_HEADROOM"
> >   ^
> > cc1: error: unrecognized command line option "-Wno-address-of-packed-
> > member"
> > [-Werror]
> > cc1: all warnings being treated as errors
> > make[6]: *** [portal/dpaa2_hw_dpci.o] Error 1 In file included from
> > /auto/mtrswgwork/matan/reps/matan_rep/dpdk.org/drivers/bus/fslmc/fsl
> > mc_vfio.c:40:0:
> > /auto/mtrswgwork/matan/reps/matan_rep/dpdk.org/drivers/bus/fslmc/po
> > rtal/dpaa2_hw_pvt.h:76:2:
> > error: #error "Annotation requirement is more than
> > RTE_PKTMBUF_HEADROOM"
> >  #error "Annotation requirement is more than RTE_PKTMBUF_HEADROOM"
> >   ^
> > 
> > --
> > You are receiving this mail because:
> > You are the assignee for the bug.  

It seems reasonable for a driver to require headroom to store extra
data in receive buffer. It should be documented though.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dpdk-dev] [Bug 335] Compilation fails when HEADROOM is 0
  2019-07-24 16:24   ` Stephen Hemminger
@ 2019-07-24 16:40     ` Matan Azrad
  2019-07-25  6:04       ` Hemant Agrawal
  0 siblings, 1 reply; 5+ messages in thread
From: Matan Azrad @ 2019-07-24 16:40 UTC (permalink / raw)
  To: Stephen Hemminger; +Cc: Hemant Agrawal, sachin.saxena, dev



From: Stephen Hemminger <stephen@networkplumber.org>
> Sent: Wednesday, July 24, 2019 7:24 PM
> To: Matan Azrad <matan@mellanox.com>
> Cc: Hemant Agrawal <hemant.agrawal@nxp.com>; sachin.saxena@nxp.com;
> dev@dpdk.org
> Subject: Re: [dpdk-dev] [Bug 335] Compilation fails when HEADROOM is 0
> 
> On Wed, 24 Jul 2019 15:37:40 +0000
> Matan Azrad <matan@mellanox.com> wrote:
> 
> > Hi Hemant, Sachin
> >
> > Looks like issue in dpaa.
> > Please check.
> >
> > > -----Original Message-----
> > > From: dev <dev-bounces@dpdk.org> On Behalf Of bugzilla@dpdk.org
> > > Sent: Wednesday, July 24, 2019 6:35 PM
> > > To: dev@dpdk.org
> > > Subject: [dpdk-dev] [Bug 335] Compilation fails when HEADROOM is 0
> > >
> > > https://bugs.
> > >
> dpdk.org%2Fshow_bug.cgi%3Fid%3D335&amp;data=02%7C01%7Cmatan%40
> > >
> mellanox.com%7Cef4c519dd7b1495178f808d7104c7400%7Ca652971c7d2e4d9
> > >
> ba6a4d149256f461b%7C0%7C0%7C636995792862104273&amp;sdata=DrdcCJ
> > >
> mYUMZxk3j%2F%2BxPlqXMOAb9GDNBPzSNzpifzcMU%3D&amp;reserved=0
> > >
> > >             Bug ID: 335
> > >            Summary: Compilation fails when HEADROOM is 0
> > >            Product: DPDK
> > >            Version: unspecified
> > >           Hardware: All
> > >                 OS: All
> > >             Status: UNCONFIRMED
> > >           Severity: normal
> > >           Priority: Normal
> > >          Component: ethdev
> > >           Assignee: dev@dpdk.org
> > >           Reporter: matan@mellanox.com
> > >   Target Milestone: ---
> > >
> > > The compilation error:
> > > In file included from
> > >
> /auto/mtrswgwork/matan/reps/matan_rep/dpdk.org/drivers/bus/fslmc/po
> > > rtal/dpaa2_hw_dpbp.c:28:0:
> > >
> /auto/mtrswgwork/matan/reps/matan_rep/dpdk.org/drivers/bus/fslmc/po
> > > rtal/dpaa2_hw_pvt.h:76:2:
> > > error: #error "Annotation requirement is more than
> > > RTE_PKTMBUF_HEADROOM"
> > >  #error "Annotation requirement is more than
> RTE_PKTMBUF_HEADROOM"
> > >   ^
> > > cc1: error: unrecognized command line option
> > > "-Wno-address-of-packed- member"
> > > [-Werror]
> > > cc1: all warnings being treated as errors
> > > make[6]: *** [portal/dpaa2_hw_dpbp.o] Error 1
> > > make[6]: *** Waiting for unfinished jobs....
> > > In file included from
> > >
> /auto/mtrswgwork/matan/reps/matan_rep/dpdk.org/drivers/bus/fslmc/po
> > > rtal/dpaa2_hw_dpio.c:37:0:
> > >
> /auto/mtrswgwork/matan/reps/matan_rep/dpdk.org/drivers/bus/fslmc/po
> > > rtal/dpaa2_hw_pvt.h:76:2:
> > > error: #error "Annotation requirement is more than
> > > RTE_PKTMBUF_HEADROOM"
> > >  #error "Annotation requirement is more than
> RTE_PKTMBUF_HEADROOM"
> > >   ^
> > > cc1: error: unrecognized command line option
> > > "-Wno-address-of-packed- member"
> > > [-Werror]
> > > cc1: all warnings being treated as errors
> > > make[6]: *** [portal/dpaa2_hw_dpio.o] Error 1 In file included from
> > >
> /auto/mtrswgwork/matan/reps/matan_rep/dpdk.org/drivers/bus/fslmc/po
> > > rtal/dpaa2_hw_dpci.c:26:0:
> > >
> /auto/mtrswgwork/matan/reps/matan_rep/dpdk.org/drivers/bus/fslmc/po
> > > rtal/dpaa2_hw_pvt.h:76:2:
> > > error: #error "Annotation requirement is more than
> > > RTE_PKTMBUF_HEADROOM"
> > >  #error "Annotation requirement is more than
> RTE_PKTMBUF_HEADROOM"
> > >   ^
> > > cc1: error: unrecognized command line option
> > > "-Wno-address-of-packed- member"
> > > [-Werror]
> > > cc1: all warnings being treated as errors
> > > make[6]: *** [portal/dpaa2_hw_dpci.o] Error 1 In file included from
> > >
> /auto/mtrswgwork/matan/reps/matan_rep/dpdk.org/drivers/bus/fslmc/fsl
> > > mc_vfio.c:40:0:
> > >
> /auto/mtrswgwork/matan/reps/matan_rep/dpdk.org/drivers/bus/fslmc/po
> > > rtal/dpaa2_hw_pvt.h:76:2:
> > > error: #error "Annotation requirement is more than
> > > RTE_PKTMBUF_HEADROOM"
> > >  #error "Annotation requirement is more than
> RTE_PKTMBUF_HEADROOM"
> > >   ^
> > >
> > > --
> > > You are receiving this mail because:
> > > You are the assignee for the bug.
> 
> It seems reasonable for a driver to require headroom to store extra data in
> receive buffer. It should be documented though.

Yes.

But if so, this driver should not be compiled by default, or change to raise run-time error instead.

What do you think?

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dpdk-dev] [Bug 335] Compilation fails when HEADROOM is 0
  2019-07-24 16:40     ` Matan Azrad
@ 2019-07-25  6:04       ` Hemant Agrawal
  0 siblings, 0 replies; 5+ messages in thread
From: Hemant Agrawal @ 2019-07-25  6:04 UTC (permalink / raw)
  To: Matan Azrad, Stephen Hemminger; +Cc: Sachin Saxena, dev

HI Matan,
> > On Wed, 24 Jul 2019 15:37:40 +0000
> > Matan Azrad <matan@mellanox.com> wrote:
> >
> > > Hi Hemant, Sachin
> > >
> > > Looks like issue in dpaa.
> > > Please check.
> > >
> > > > -----Original Message-----
> > > > From: dev <dev-bounces@dpdk.org> On Behalf Of bugzilla@dpdk.org
> > > > Sent: Wednesday, July 24, 2019 6:35 PM
> > > > To: dev@dpdk.org
> > > > Subject: [dpdk-dev] [Bug 335] Compilation fails when HEADROOM is 0
> > > >
> > > > https://bugs.
> > > >
> >
> dpdk.org%2Fshow_bug.cgi%3Fid%3D335&amp;data=02%7C01%7Cmatan%40
> > > >
> >
> mellanox.com%7Cef4c519dd7b1495178f808d7104c7400%7Ca652971c7d2e4d
> 9
> > > >
> >
> ba6a4d149256f461b%7C0%7C0%7C636995792862104273&amp;sdata=DrdcC
> J
> > > >
> >
> mYUMZxk3j%2F%2BxPlqXMOAb9GDNBPzSNzpifzcMU%3D&amp;reserved=0
> > > >
> > > >             Bug ID: 335
> > > >            Summary: Compilation fails when HEADROOM is 0
> > > >            Product: DPDK
> > > >            Version: unspecified
> > > >           Hardware: All
> > > >                 OS: All
> > > >             Status: UNCONFIRMED
> > > >           Severity: normal
> > > >           Priority: Normal
> > > >          Component: ethdev
> > > >           Assignee: dev@dpdk.org
> > > >           Reporter: matan@mellanox.com
> > > >   Target Milestone: ---
> > > >
> > > > The compilation error:
> > > > In file included from
> > > >
> >
> /auto/mtrswgwork/matan/reps/matan_rep/dpdk.org/drivers/bus/fslmc/po
> > > > rtal/dpaa2_hw_dpbp.c:28:0:
> > > >
> >
> /auto/mtrswgwork/matan/reps/matan_rep/dpdk.org/drivers/bus/fslmc/po
> > > > rtal/dpaa2_hw_pvt.h:76:2:
> > > > error: #error "Annotation requirement is more than
> > > > RTE_PKTMBUF_HEADROOM"
> > > >  #error "Annotation requirement is more than
> > RTE_PKTMBUF_HEADROOM"
> > > >   ^
> > > > cc1: error: unrecognized command line option
> > > > "-Wno-address-of-packed- member"
> > > > [-Werror]
> > > > cc1: all warnings being treated as errors
> > > > make[6]: *** [portal/dpaa2_hw_dpbp.o] Error 1
> > > > make[6]: *** Waiting for unfinished jobs....
> > > > In file included from
> > > >
> >
> /auto/mtrswgwork/matan/reps/matan_rep/dpdk.org/drivers/bus/fslmc/po
> > > > rtal/dpaa2_hw_dpio.c:37:0:
> > > >
> >
> /auto/mtrswgwork/matan/reps/matan_rep/dpdk.org/drivers/bus/fslmc/po
> > > > rtal/dpaa2_hw_pvt.h:76:2:
> > > > error: #error "Annotation requirement is more than
> > > > RTE_PKTMBUF_HEADROOM"
> > > >  #error "Annotation requirement is more than
> > RTE_PKTMBUF_HEADROOM"
> > > >   ^
> > > > cc1: error: unrecognized command line option
> > > > "-Wno-address-of-packed- member"
> > > > [-Werror]
> > > > cc1: all warnings being treated as errors
> > > > make[6]: *** [portal/dpaa2_hw_dpio.o] Error 1 In file included
> > > > from
> > > >
> >
> /auto/mtrswgwork/matan/reps/matan_rep/dpdk.org/drivers/bus/fslmc/po
> > > > rtal/dpaa2_hw_dpci.c:26:0:
> > > >
> >
> /auto/mtrswgwork/matan/reps/matan_rep/dpdk.org/drivers/bus/fslmc/po
> > > > rtal/dpaa2_hw_pvt.h:76:2:
> > > > error: #error "Annotation requirement is more than
> > > > RTE_PKTMBUF_HEADROOM"
> > > >  #error "Annotation requirement is more than
> > RTE_PKTMBUF_HEADROOM"
> > > >   ^
> > > > cc1: error: unrecognized command line option
> > > > "-Wno-address-of-packed- member"
> > > > [-Werror]
> > > > cc1: all warnings being treated as errors
> > > > make[6]: *** [portal/dpaa2_hw_dpci.o] Error 1 In file included
> > > > from
> > > >
> >
> /auto/mtrswgwork/matan/reps/matan_rep/dpdk.org/drivers/bus/fslmc/fsl
> > > > mc_vfio.c:40:0:
> > > >
> >
> /auto/mtrswgwork/matan/reps/matan_rep/dpdk.org/drivers/bus/fslmc/po
> > > > rtal/dpaa2_hw_pvt.h:76:2:
> > > > error: #error "Annotation requirement is more than
> > > > RTE_PKTMBUF_HEADROOM"
> > > >  #error "Annotation requirement is more than
> > RTE_PKTMBUF_HEADROOM"
> > > >   ^
> > > >
> > > > --
> > > > You are receiving this mail because:
> > > > You are the assignee for the bug.
> >
> > It seems reasonable for a driver to require headroom to store extra
> > data in receive buffer. It should be documented though.
> 
> Yes.
> 
> But if so, this driver should not be compiled by default, or change to raise
> run-time error instead.
> 
> What do you think?
[Hemant] We will change it to run-time error.

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2019-07-25  6:04 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-24 15:34 [dpdk-dev] [Bug 335] Compilation fails when HEADROOM is 0 bugzilla
2019-07-24 15:37 ` Matan Azrad
2019-07-24 16:24   ` Stephen Hemminger
2019-07-24 16:40     ` Matan Azrad
2019-07-25  6:04       ` Hemant Agrawal

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).