From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C7339A046B for ; Wed, 24 Jul 2019 18:40:23 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5B52C1C231; Wed, 24 Jul 2019 18:40:23 +0200 (CEST) Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80059.outbound.protection.outlook.com [40.107.8.59]) by dpdk.org (Postfix) with ESMTP id 5D68A1C230 for ; Wed, 24 Jul 2019 18:40:22 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NoKxXTCYZcIy8O1Qk1IZHWN2RreIK3Fu2OC/9SuMBZtPxEm9bhz++E16wuFVxx+w6kXVFCZ9qiYTfse+YCPSZBShBilHpzMVIGeunT/n94/u0SoQ1Mg9G1HJKhUOqE/mAHVUpZ6ESDcP1fW/Pi2mNFm8b1mVQ/43KTM55dVh5eJuICVuRlpr5cORXcTNMxEQlVHOAmUc00WbADaoKmOxoALtlDGLjBvMJ+Doh6o8NVXwrOFgSKqckI5wZ/hDB6h8ABZHOAetSe6wUbkMPVykp5+fWGJg5DQCimtyAmKeJ1a0p8y/NCMjY4qXMmXxbzSpRUb20Tf1YKTa3fqRgHzNqQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=33uPbyquADmyJQW1Fo8gJH0bYRP7F9NQuHB2EE34+sA=; b=a4oOnucrGqxRCq9ruIYxUskbi8lad6bh+s3zQMGBgm1MerXWL7SbWM5WyO6MgswmIAexS4Oa+rtA9TDh7YSA40vW5tTMl7wJZPyE2faXuxDU9UREu+/ca/VDDOeRglY9VfF6JAPOKkglOv8OePX4ygc5mOBYdMCRVye3iXzM19ianoA08DvyW/DCYfpRoC1M6dbmWeC5Debbu6wW5HV29ueheRZlEY2/EOWWr/5rh8bMl2mut6D1S4eZyRBwm8nF2+trtgHwEbP22aU8AvJSjBRKbj8OAwx1TjKVcnZ+CQKvYI94X3Z88jDelzDX1vzWCSZ4vMMsU74m1DsFAaIkiA== ARC-Authentication-Results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=mellanox.com;dmarc=pass action=none header.from=mellanox.com;dkim=pass header.d=mellanox.com;arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=33uPbyquADmyJQW1Fo8gJH0bYRP7F9NQuHB2EE34+sA=; b=NtUYdtHKUOjXI5pN5kwUMbbO3NFDMEnBNSkoPTOzHemKCJIsC/WjLwQz/ijxxdUVv5cJGLIzfuV6T6GK3MhWOSBTHNPDi/1fjbRFf9Dg6JphXEEWC/3xyec+9agsBky0rMhj7yx3bZCyocolnRrFSUwbkdXlJZbQ0AlKnlAMOl8= Received: from AM0PR0502MB4019.eurprd05.prod.outlook.com (52.133.39.139) by AM0PR0502MB3905.eurprd05.prod.outlook.com (52.133.45.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2115.10; Wed, 24 Jul 2019 16:40:20 +0000 Received: from AM0PR0502MB4019.eurprd05.prod.outlook.com ([fe80::ccc2:2dd4:ca86:7639]) by AM0PR0502MB4019.eurprd05.prod.outlook.com ([fe80::ccc2:2dd4:ca86:7639%3]) with mapi id 15.20.2094.013; Wed, 24 Jul 2019 16:40:20 +0000 From: Matan Azrad To: Stephen Hemminger CC: Hemant Agrawal , "sachin.saxena@nxp.com" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [Bug 335] Compilation fails when HEADROOM is 0 Thread-Index: AQHVQjVSQGY4CZEr+EaeVIDqHAIULabZ5mRQgAANnYCAAAQCYA== Date: Wed, 24 Jul 2019 16:40:20 +0000 Message-ID: References: <20190724092405.7d2405a8@hermes.lan> In-Reply-To: <20190724092405.7d2405a8@hermes.lan> Accept-Language: en-US, he-IL Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=matan@mellanox.com; x-originating-ip: [77.127.47.140] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 146e13d1-921e-4400-d60b-08d710559e08 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020); SRVR:AM0PR0502MB3905; x-ms-traffictypediagnostic: AM0PR0502MB3905: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-forefront-prvs: 0108A997B2 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(346002)(376002)(366004)(136003)(39860400002)(396003)(189003)(199004)(13464003)(7696005)(6436002)(76176011)(76116006)(55016002)(68736007)(86362001)(5660300002)(305945005)(74316002)(25786009)(229853002)(6916009)(6246003)(99286004)(4326008)(7736002)(53936002)(54906003)(316002)(14454004)(966005)(8936002)(9686003)(81166006)(81156014)(3846002)(71200400001)(71190400001)(6116002)(256004)(6306002)(8676002)(6506007)(53546011)(66946007)(186003)(102836004)(66556008)(66476007)(64756008)(66446008)(33656002)(446003)(11346002)(26005)(486006)(478600001)(66066001)(52536014)(2906002)(476003); DIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR0502MB3905; H:AM0PR0502MB4019.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: aO+WruyvL49AFyrYhyYZXv3HlkJaEgn35Rfyht915Wd074ACyI/JmVzNADPKBFE7ZjoDxdV87we6UxhuFSW+guxLr+YW2wxdBppeW4NUoUWVUchniIYl6yS1VvOKGJBwxLJ11Hb4xkXVfWjh3rlwjSg0QndxRK060PKfahTmJL6j9sDeNDl7v6u3OoBSaeMSDKPG/SsgfcN7y3kNRpycp19TOeJRpT58NyngC+T1/eMaTYSoc8bT4CUyUYkRZ4XTkOnqdhhcuBmohYoubU8UvQpbjwje1xd6MP9PtVh1+OISJesi4lp9ZF+KO4RJKF7HGnP3ebAtzVA0JSX9A43hkitJXWzwu6MQ5hP8q9SL6mBcCkHJ/gduUao8EqOGF+iIfpScnCSELIkQiXFgJv9Qh3U4XrThBQ/J4d+O7oWBeI4= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 146e13d1-921e-4400-d60b-08d710559e08 X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Jul 2019 16:40:20.4609 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: matan@mellanox.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR0502MB3905 Subject: Re: [dpdk-dev] [Bug 335] Compilation fails when HEADROOM is 0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Stephen Hemminger > Sent: Wednesday, July 24, 2019 7:24 PM > To: Matan Azrad > Cc: Hemant Agrawal ; sachin.saxena@nxp.com; > dev@dpdk.org > Subject: Re: [dpdk-dev] [Bug 335] Compilation fails when HEADROOM is 0 >=20 > On Wed, 24 Jul 2019 15:37:40 +0000 > Matan Azrad wrote: >=20 > > Hi Hemant, Sachin > > > > Looks like issue in dpaa. > > Please check. > > > > > -----Original Message----- > > > From: dev On Behalf Of bugzilla@dpdk.org > > > Sent: Wednesday, July 24, 2019 6:35 PM > > > To: dev@dpdk.org > > > Subject: [dpdk-dev] [Bug 335] Compilation fails when HEADROOM is 0 > > > > > > https://bugs. > > > > dpdk.org%2Fshow_bug.cgi%3Fid%3D335&data=3D02%7C01%7Cmatan%40 > > > > mellanox.com%7Cef4c519dd7b1495178f808d7104c7400%7Ca652971c7d2e4d9 > > > > ba6a4d149256f461b%7C0%7C0%7C636995792862104273&sdata=3DDrdcCJ > > > > mYUMZxk3j%2F%2BxPlqXMOAb9GDNBPzSNzpifzcMU%3D&reserved=3D0 > > > > > > Bug ID: 335 > > > Summary: Compilation fails when HEADROOM is 0 > > > Product: DPDK > > > Version: unspecified > > > Hardware: All > > > OS: All > > > Status: UNCONFIRMED > > > Severity: normal > > > Priority: Normal > > > Component: ethdev > > > Assignee: dev@dpdk.org > > > Reporter: matan@mellanox.com > > > Target Milestone: --- > > > > > > The compilation error: > > > In file included from > > > > /auto/mtrswgwork/matan/reps/matan_rep/dpdk.org/drivers/bus/fslmc/po > > > rtal/dpaa2_hw_dpbp.c:28:0: > > > > /auto/mtrswgwork/matan/reps/matan_rep/dpdk.org/drivers/bus/fslmc/po > > > rtal/dpaa2_hw_pvt.h:76:2: > > > error: #error "Annotation requirement is more than > > > RTE_PKTMBUF_HEADROOM" > > > #error "Annotation requirement is more than > RTE_PKTMBUF_HEADROOM" > > > ^ > > > cc1: error: unrecognized command line option > > > "-Wno-address-of-packed- member" > > > [-Werror] > > > cc1: all warnings being treated as errors > > > make[6]: *** [portal/dpaa2_hw_dpbp.o] Error 1 > > > make[6]: *** Waiting for unfinished jobs.... > > > In file included from > > > > /auto/mtrswgwork/matan/reps/matan_rep/dpdk.org/drivers/bus/fslmc/po > > > rtal/dpaa2_hw_dpio.c:37:0: > > > > /auto/mtrswgwork/matan/reps/matan_rep/dpdk.org/drivers/bus/fslmc/po > > > rtal/dpaa2_hw_pvt.h:76:2: > > > error: #error "Annotation requirement is more than > > > RTE_PKTMBUF_HEADROOM" > > > #error "Annotation requirement is more than > RTE_PKTMBUF_HEADROOM" > > > ^ > > > cc1: error: unrecognized command line option > > > "-Wno-address-of-packed- member" > > > [-Werror] > > > cc1: all warnings being treated as errors > > > make[6]: *** [portal/dpaa2_hw_dpio.o] Error 1 In file included from > > > > /auto/mtrswgwork/matan/reps/matan_rep/dpdk.org/drivers/bus/fslmc/po > > > rtal/dpaa2_hw_dpci.c:26:0: > > > > /auto/mtrswgwork/matan/reps/matan_rep/dpdk.org/drivers/bus/fslmc/po > > > rtal/dpaa2_hw_pvt.h:76:2: > > > error: #error "Annotation requirement is more than > > > RTE_PKTMBUF_HEADROOM" > > > #error "Annotation requirement is more than > RTE_PKTMBUF_HEADROOM" > > > ^ > > > cc1: error: unrecognized command line option > > > "-Wno-address-of-packed- member" > > > [-Werror] > > > cc1: all warnings being treated as errors > > > make[6]: *** [portal/dpaa2_hw_dpci.o] Error 1 In file included from > > > > /auto/mtrswgwork/matan/reps/matan_rep/dpdk.org/drivers/bus/fslmc/fsl > > > mc_vfio.c:40:0: > > > > /auto/mtrswgwork/matan/reps/matan_rep/dpdk.org/drivers/bus/fslmc/po > > > rtal/dpaa2_hw_pvt.h:76:2: > > > error: #error "Annotation requirement is more than > > > RTE_PKTMBUF_HEADROOM" > > > #error "Annotation requirement is more than > RTE_PKTMBUF_HEADROOM" > > > ^ > > > > > > -- > > > You are receiving this mail because: > > > You are the assignee for the bug. >=20 > It seems reasonable for a driver to require headroom to store extra data = in > receive buffer. It should be documented though. Yes. But if so, this driver should not be compiled by default, or change to rais= e run-time error instead. What do you think?