From: Matan Azrad <matan@mellanox.com>
To: wangyunjian <wangyunjian@huawei.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: Shahaf Shuler <shahafs@mellanox.com>,
Slava Ovsiienko <viacheslavo@mellanox.com>,
"jerry.lilijun@huawei.com" <jerry.lilijun@huawei.com>,
"xudingke@huawei.com" <xudingke@huawei.com>
Subject: Re: [dpdk-dev] [PATCH] net/mlx5: remove unnecessary NULL check
Date: Tue, 31 Mar 2020 10:53:52 +0000 [thread overview]
Message-ID: <AM0PR0502MB4019BA76DC7D2DF1C1DD6498D2C80@AM0PR0502MB4019.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <1585650269-11556-1-git-send-email-wangyunjian@huawei.com>
From: wangyunjian
> From: Yunjian Wang <wangyunjian@huawei.com>
>
> This NULL check is unnecessary, container_of is never NULL.
>
> Signed-off-by: Yunjian Wang <wangyunjian@huawei.com>
> ---
> drivers/net/mlx5/mlx5.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c index
> 94aaa6057..2e4edb123 100644
> --- a/drivers/net/mlx5/mlx5.c
> +++ b/drivers/net/mlx5/mlx5.c
> @@ -747,7 +747,6 @@ mlx5_free_table_hash_list(struct mlx5_priv *priv)
> if (pos) {
> tbl_data = container_of(pos, struct
> mlx5_flow_tbl_data_entry,
> entry);
> - MLX5_ASSERT(tbl_data);
So, maybe the assert should be on entry?
> mlx5_hlist_remove(sh->flow_tbls, pos);
> rte_free(tbl_data);
> }
> @@ -756,7 +755,6 @@ mlx5_free_table_hash_list(struct mlx5_priv *priv)
> if (pos) {
> tbl_data = container_of(pos, struct
> mlx5_flow_tbl_data_entry,
> entry);
> - MLX5_ASSERT(tbl_data);
> mlx5_hlist_remove(sh->flow_tbls, pos);
> rte_free(tbl_data);
> }
> @@ -766,7 +764,6 @@ mlx5_free_table_hash_list(struct mlx5_priv *priv)
> if (pos) {
> tbl_data = container_of(pos, struct
> mlx5_flow_tbl_data_entry,
> entry);
> - MLX5_ASSERT(tbl_data);
> mlx5_hlist_remove(sh->flow_tbls, pos);
> rte_free(tbl_data);
> }
> --
> 2.19.1
>
next prev parent reply other threads:[~2020-03-31 10:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-31 10:24 wangyunjian
2020-03-31 10:53 ` Matan Azrad [this message]
2020-04-01 11:13 ` wangyunjian
2020-11-18 2:15 ` Suanming Mou
2020-11-18 2:41 ` wangyunjian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM0PR0502MB4019BA76DC7D2DF1C1DD6498D2C80@AM0PR0502MB4019.eurprd05.prod.outlook.com \
--to=matan@mellanox.com \
--cc=dev@dpdk.org \
--cc=jerry.lilijun@huawei.com \
--cc=shahafs@mellanox.com \
--cc=viacheslavo@mellanox.com \
--cc=wangyunjian@huawei.com \
--cc=xudingke@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).