From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3F40CA046B for ; Wed, 24 Jul 2019 22:23:51 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0BD851C25C; Wed, 24 Jul 2019 22:23:51 +0200 (CEST) Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-eopbgr50087.outbound.protection.outlook.com [40.107.5.87]) by dpdk.org (Postfix) with ESMTP id 043861C257 for ; Wed, 24 Jul 2019 22:23:50 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ND7bD1OclMyXcBdZ2F0w0BJYJ7Wvrcjo8rrO2l3ZxhSRwWGID1IWX9XTnyGpCRn+iIxbdpkbzZayaWOHIVSwmpYn215QfmQ6cTh+m7NLQ+lFBGSdSCyoMp+wWE6wUgSRlnlpbSKF9wWc2hiRaJiwraST8npS0a4qMNsGO0BUWpSucIaT0BWIggASZiB2CauvMEAzBzLgTOnvxY7L4KFduEhfF5EZ5nv3Wvv4a68lFyzlEoYJ+KQgW2ltwxOrvnq0VvV8D3uHKvAF8AneiQYjhxN1oQIOBNB920qCGMLyTKalg49pEboXYXOTDObVCNznW6RggCR6yRwvMN9C/JtYpw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sehNydE20gRXUpKV9KMeOhPPQvZc7l3neUVPtRGfRn8=; b=gsOgqfmgJc+NDPfQ4r3DF88e3m9JSIHmr54TVzyEVdfUdciRi1Sjrsf0MT5SkuFPM/ZJRFTzS+5iEGajQB1u66OsZ9EvsnTUVIyTY7TC5wvkZHj5qDtTTiKQ112pT08xbKnkA6e+uG+dv+/PpzAzEWdscyXWK/vJDLFYW/2mYHHNYCgRgKs0/8d1iGs00cjxO2fFRDSTh2U1axhf8bg0T3lw4PKmoRaVDKxEyAeNZIlgHtTqfeTT00MM5d0DBvMkalFLTnU8DoY1gZjs492S5h9sfWdXQfSGqNdDKq9GoCHa+dsp/JIMaCsCtO4OLUVO1hExhJtwx1brlMoQZx0EBg== ARC-Authentication-Results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=mellanox.com;dmarc=pass action=none header.from=mellanox.com;dkim=pass header.d=mellanox.com;arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sehNydE20gRXUpKV9KMeOhPPQvZc7l3neUVPtRGfRn8=; b=iPRkKF0DN3oOxnwZ6BMx5ynhIlMZ8jJdIpqtsyGmnvOBmnEqtRXKYY5fgfRZ8SkCfBOaTzrPDsL5GYpg3pPUuOUDPtlikcPuifMFROpP28t3HuVoQ3lrQyqKopaJ7D24ctTlkGves2Uj60l05W7jKEy4nqbN+Gh/2NqTyCsfbDA= Received: from AM0PR0502MB4019.eurprd05.prod.outlook.com (52.133.39.139) by AM0PR0502MB4018.eurprd05.prod.outlook.com (52.133.37.138) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2094.12; Wed, 24 Jul 2019 20:23:49 +0000 Received: from AM0PR0502MB4019.eurprd05.prod.outlook.com ([fe80::ccc2:2dd4:ca86:7639]) by AM0PR0502MB4019.eurprd05.prod.outlook.com ([fe80::ccc2:2dd4:ca86:7639%3]) with mapi id 15.20.2094.013; Wed, 24 Jul 2019 20:23:49 +0000 From: Matan Azrad To: Dekel Peled , Yongseok Koh , Slava Ovsiienko , Shahaf Shuler CC: Ori Kam , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v3] net/mlx5: fix Rx queue release of resources Thread-Index: AQHVQf77sXa9SyDMjEGOyyk3WGFFvKbaN1m1 Date: Wed, 24 Jul 2019 20:23:48 +0000 Message-ID: References: <657215c5e0635b452d5245cd0bfbdcf8315baf6a.1563958238.git.dekelp@mellanox.com>, In-Reply-To: Accept-Language: en-US, he-IL Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=matan@mellanox.com; x-originating-ip: [77.127.47.140] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 4b12bf73-a0bf-486a-e794-08d71074d613 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020); SRVR:AM0PR0502MB4018; x-ms-traffictypediagnostic: AM0PR0502MB4018: x-ms-exchange-purlcount: 1 x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2399; x-forefront-prvs: 0108A997B2 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(396003)(346002)(366004)(39860400002)(136003)(376002)(189003)(199004)(8936002)(76176011)(102836004)(256004)(7696005)(54906003)(186003)(68736007)(76116006)(7736002)(25786009)(14444005)(33656002)(81156014)(6506007)(6436002)(91956017)(606006)(86362001)(26005)(478600001)(74316002)(8676002)(476003)(14454004)(45080400002)(81166006)(6636002)(54896002)(486006)(5660300002)(55016002)(2906002)(53936002)(9686003)(6306002)(316002)(6116002)(6246003)(236005)(4326008)(3846002)(64756008)(99286004)(446003)(66946007)(66446008)(110136005)(66556008)(71190400001)(71200400001)(66476007)(52536014)(229853002)(11346002)(66066001); DIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR0502MB4018; H:AM0PR0502MB4019.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: TXCF4G21t8WTMPti1qBo5GvBH1Y2oTsh4lSz8r7Wuk3xC1Wq10xBzbXpX44qj146PZVIiBHaUJA3EFqV2FkanuR5/vkoQZNRrtVnS6BzYiL+3g0QGLeP9ihz9nfdzzldYYnrmwG1zPaGQjwg/ByR6aDVgeMn2XGaFQodIBlvKTFkyOKzKJO8yeCsO+GCTUjHVi4vaW77AlELTixQ2cCAAaFLVDGrhY7uO2NM7rrIRBsXCKFaC/wMLH6sy/eO6jU2COLQUByXTlBN2Rb8Ue88SuFHQvzNjUL/Vo080zjXc6anYUlMCt+mLyH7LDpygHXxZARqve9ZA4oxhVR3QeVrOBYrgA8dscI+AC1HJe8OiKUcQdwVZykehNK2hmVLMEPIgayvf2ijYHz/mbkUuG14zOWQk0hOeMsTm0LBzsZowBA= MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4b12bf73-a0bf-486a-e794-08d71074d613 X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Jul 2019 20:23:48.9224 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: matan@mellanox.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR0502MB4018 Content-Type: text/plain; charset="iso-8859-8-i" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v3] net/mlx5: fix Rx queue release of resources X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" =E4=F9=E2 =E0=FA Outlook =F2=E1=E5=F8 Android =EE=E0=FA: Dekel Peled =F0=F9=EC=E7: =E9=E5=ED =F8=E1=E9=F2=E9, 24 =E1=E9=E5=EC=E9, 12:05 =F0=E5=F9=E0: [dpdk-dev] [PATCH v3] net/mlx5: fix Rx queue release of resou= rces =E0=EC: Yongseok Koh, Slava Ovsiienko, Shahaf Shuler =F2=E5=FA=F7: Ori Kam, dev@dpdk.org Function rxq_release_rq_resources() releases resources of RQ object created by DevX API. This patch updates this function to properly clear the released resources, to avoid repeated release of the same resource. Fixes: 13f4e1b32137 ("net/mlx5: create advanced RxQ using new API") --- v3: Use adequate 'Fixes' reference. --- Signed-off-by: Dekel Peled Acked-by: Viacheslav Ovsiienko Acked-by: Matan Azrad --- drivers/net/mlx5/mlx5_rxq.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/mlx5/mlx5_rxq.c b/drivers/net/mlx5/mlx5_rxq.c index c9df8b0..441f158 100644 --- a/drivers/net/mlx5/mlx5_rxq.c +++ b/drivers/net/mlx5/mlx5_rxq.c @@ -573,8 +573,10 @@ rte_free((void *)(uintptr_t)rxq_ctrl->rxq.wqes); rxq_ctrl->rxq.wqes =3D NULL; } - if (rxq_ctrl->wq_umem) + if (rxq_ctrl->wq_umem) { mlx5_glue->devx_umem_dereg(rxq_ctrl->wq_umem); + rxq_ctrl->wq_umem =3D NULL; + } } /** -- 1.8.3.1