From: Matan Azrad <matan@mellanox.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>,
Bill Zhou <dongz@mellanox.com>,
"wenzhuo.lu@intel.com" <wenzhuo.lu@intel.com>,
"jingjing.wu@intel.com" <jingjing.wu@intel.com>,
"bernard.iremonger@intel.com" <bernard.iremonger@intel.com>,
Ori Kam <orika@mellanox.com>,
"john.mcnamara@intel.com" <john.mcnamara@intel.com>,
"marko.kovacevic@intel.com" <marko.kovacevic@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2] app/testpmd: support flow aging
Date: Fri, 1 May 2020 15:14:50 +0000 [thread overview]
Message-ID: <AM0PR0502MB4019CFDBF96E10C1ED2941CCD2AB0@AM0PR0502MB4019.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <4fb5f2ba-a3c1-4d39-f121-b197ab6bc589@intel.com>
From: Ferruh Yigit:
> On 5/1/2020 1:45 PM, Matan Azrad wrote:
> >
> >
> > From: Ferruh Yigit:
> >> On 5/1/2020 12:28 PM, Matan Azrad wrote:
> >>>
> >>> Hi Ferruh
> >>>
> >>> From: Ferruh Yigit:
> >>>> On 5/1/2020 7:51 AM, Matan Azrad wrote:
> >>>>> Hi Ferruh
> >>>>>
> >>>>> From: Ferruh Yigit
> >>>>>> On 4/30/2020 4:53 PM, Bill Zhou wrote:
> >>>>>>> Currently, there is no way to check the aging event or to get
> >>>>>>> the current aged flows in testpmd, this patch include those
> >>>>>>> implements, it's
> >>>>>> included:
> >>>>>>> - Registering aging event when the testpmd application start, add
> new
> >>>>>>> command to control if the event expose to the applications. If it's
> be
> >>>>>>> set, when new flow be checked age out, there will be one-line
> >>>>>>> output
> >>>> log.
> >>>>>>> - Add new command to list all aged flows, meanwhile, we can set
> >>>>>> parameter
> >>>>>>> to destroy it.
> >>>>>>>
> >>>>>>> Signed-off-by: Bill Zhou <dongz@mellanox.com>
> >>>>>>> ---
> >>>>>>> v2: Update the way of registering aging event, add new command
> >>>>>>> to control if the event need be print or not. Update the output
> >>>>>>> of the delete aged flow command format.
<...>
> >>>> What do you think about a more generic "set event_verbose on|off"
> >>>> command, which can control to logging for all event handlers, but
> >>>> right now only for aged events?
> >>>
> >>> Looks good to me, but maybe instead of on | off it is better to use
> >>> bitmap
> >> in order to indicate the event?
> >>
> >> No objection but not sure that level fine grain needed now, or later,
> >> why not add the basic on/off now and add the bitmap when we need to
> >> control for each event.
> >
> > It will be good to the user to reduce logs of non-interested events (maybe
> even more often) which makes his log bigger.
>
> Right now, is there any other event that logs? And how much log do they
> produce?
I don't really familiar with all, but looks like IPSEC, VF_MBOX and AGED may make the log bigger than others.
So, if we open verbose for all, the events log bitmap may be very usable.
<....>
next prev parent reply other threads:[~2020-05-01 15:14 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-24 10:55 [dpdk-dev] [PATCH] " Bill Zhou
2020-04-24 16:25 ` Ferruh Yigit
2020-04-26 7:23 ` Bill Zhou
2020-04-27 14:13 ` Ferruh Yigit
2020-04-27 15:12 ` Matan Azrad
2020-04-30 22:26 ` Ferruh Yigit
2020-04-30 15:53 ` [dpdk-dev] [PATCH v2] " Bill Zhou
2020-04-30 22:43 ` Ferruh Yigit
2020-05-01 6:51 ` Matan Azrad
2020-05-01 9:27 ` Ferruh Yigit
2020-05-01 11:28 ` Matan Azrad
2020-05-01 11:54 ` Ferruh Yigit
2020-05-01 12:45 ` Matan Azrad
2020-05-01 13:38 ` Ferruh Yigit
2020-05-01 15:14 ` Matan Azrad [this message]
2020-05-01 15:44 ` Ferruh Yigit
2020-05-02 14:00 ` [dpdk-dev] [PATCH v3] " Bill Zhou
2020-05-03 8:59 ` [dpdk-dev] [PATCH v4] " Bill Zhou
2020-05-03 9:46 ` Matan Azrad
2020-05-03 14:58 ` Ori Kam
2020-05-05 8:37 ` Ferruh Yigit
2020-05-05 9:11 ` Matan Azrad
2020-05-05 9:23 ` Ferruh Yigit
2020-05-05 9:49 ` [dpdk-dev] [PATCH v5] " Bill Zhou
2020-05-05 10:09 ` Ori Kam
2020-05-05 15:11 ` Ferruh Yigit
2020-05-06 8:04 ` Matan Azrad
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM0PR0502MB4019CFDBF96E10C1ED2941CCD2AB0@AM0PR0502MB4019.eurprd05.prod.outlook.com \
--to=matan@mellanox.com \
--cc=bernard.iremonger@intel.com \
--cc=dev@dpdk.org \
--cc=dongz@mellanox.com \
--cc=ferruh.yigit@intel.com \
--cc=jingjing.wu@intel.com \
--cc=john.mcnamara@intel.com \
--cc=marko.kovacevic@intel.com \
--cc=orika@mellanox.com \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).