From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D0829A2EEB for ; Tue, 10 Sep 2019 09:35:15 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1DF771EBF7; Tue, 10 Sep 2019 09:35:15 +0200 (CEST) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70080.outbound.protection.outlook.com [40.107.7.80]) by dpdk.org (Postfix) with ESMTP id 298591EBB6; Tue, 10 Sep 2019 09:35:14 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TWMrl0F4lSUInTolvnF7oV2cam1jcIJY2vC27MJW7jJKCTNxD+oZv6bvklb9FtG+WO673YcSdcOt27ogxMRpXZ7TeFFveqdgzb1dfzmt6nFX9dFGj6tlXXo8ywVmmHz13vdVsmcyj1mRerQSrDViYSvDwagncuiOLTCVMJGiD+NFHk2yPxaC9bHxaHFjiCKjHdmlaw77lxDtP0zT4lJBClhucmxx+n7fPHrKI9btrV5v+HIOGkSyJOEy2YyJi2xeUVkTSKFTYNLpl4lP9sAfWowrWLJElCyrfxxGgrDPhOMGWRecf2NE/eLZB5AtEjXJjn0R/nNurO3ASeTXfqJsrw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=P17BzJfH0PP0ceERy2eoeP4Vja+B40WyOqrqCNMVSK4=; b=CX4sBd4zZDMJ6jogafOWS+C5p/geUVN7tu9PK8oWceovQS9Rs/ieZ+NvhzBGnJfwj33b98DgzrGmD9ui1/5vZUbL1rsxK4FX9rVYEyAnaDm7g7e+gbt+aUYY+rts6QZ8nUnmWz5lnfMrGXXXNPfeARfkspxnqGai14jdG6hG3TvmQRmOgiOofciKl3ESyRp1rXODWq30TXrYkHgw9vrCCoz+29H3wR9Twbvr0FiGmWTUkSfHLnXmxU190ADo+9dl+yvXom8hWqmBGqAjKKLNZps7mlaqLlevIcEV+QXGBnO4CA8lHSLe7RX/m57XO0Pv/3s4C+Xw4OZV/C6b/W9Rog== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=P17BzJfH0PP0ceERy2eoeP4Vja+B40WyOqrqCNMVSK4=; b=oWpdg7r44oLZgtrjE/8w7f7edLd21IFUBgIb22rVZD9N3cyAkZ8s1U211dWhaaoc0RGmP6VmJkINlHndtUjLAIHSGnbUF++oHql4tYsPcGTghb7R5cQi3DzB+6V8ymoXzAgWtki8oTKkRE2w7m2xK7zMWuMQPiLRws6P5RB3z/I= Received: from AM0PR0502MB4019.eurprd05.prod.outlook.com (52.133.39.139) by AM0PR0502MB3859.eurprd05.prod.outlook.com (52.133.45.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2241.13; Tue, 10 Sep 2019 07:35:11 +0000 Received: from AM0PR0502MB4019.eurprd05.prod.outlook.com ([fe80::7deb:8e17:1363:e00e]) by AM0PR0502MB4019.eurprd05.prod.outlook.com ([fe80::7deb:8e17:1363:e00e%7]) with mapi id 15.20.2241.018; Tue, 10 Sep 2019 07:35:11 +0000 From: Matan Azrad To: Slava Ovsiienko , "dev@dpdk.org" CC: "stable@dpdk.org" Thread-Topic: [PATCH] net/mlx5: fix transmit descriptor with VLAN insertions Thread-Index: AQHVYlQWS/d6+THJ1EeaDlm5n/3ba6ckj71A Date: Tue, 10 Sep 2019 07:35:11 +0000 Message-ID: References: <1567514105-24264-1-git-send-email-viacheslavo@mellanox.com> In-Reply-To: <1567514105-24264-1-git-send-email-viacheslavo@mellanox.com> Accept-Language: en-US, he-IL Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=matan@mellanox.com; x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: e4adda70-9503-47c7-e61d-08d735c169f6 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600166)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020); SRVR:AM0PR0502MB3859; x-ms-traffictypediagnostic: AM0PR0502MB3859:|AM0PR0502MB3859: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5236; x-forefront-prvs: 01565FED4C x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(39860400002)(366004)(346002)(376002)(396003)(136003)(189003)(199004)(5660300002)(81166006)(229853002)(6436002)(76176011)(316002)(110136005)(86362001)(256004)(3846002)(6116002)(476003)(26005)(11346002)(186003)(8936002)(66556008)(64756008)(486006)(66446008)(66476007)(76116006)(66946007)(99286004)(7696005)(2501003)(25786009)(33656002)(4326008)(450100002)(9686003)(446003)(8676002)(2906002)(74316002)(14454004)(7736002)(305945005)(478600001)(66066001)(71190400001)(71200400001)(4744005)(53936002)(6246003)(6506007)(81156014)(52536014)(55016002)(102836004); DIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR0502MB3859; H:AM0PR0502MB4019.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: hkyvPgUxLsZaZyqrUX19qJoDHjMUAko5E/yTDDB5Ga260ELJv6YsHkt585IaJU05OxfSbg7/RqMtiBA5fLcYLVwqesuigzipu8oew40ZLU+b8A1RRd1i8EQUFBRt54yZRzgB8nmRBgiRWh2XJNT0G8XbaXAe/KHZ30bhkCLT/Ajwl6tFya+PGWrqnp0fELi1TLsfwe8H0iTMztdyikJVgnuJqhBgAbv4g9uOKnjhgCLlRmECknuUePPCoSa9raNmkTvYmQNTbbMoosxxE39tUH3q75MoIIMS4gUHAD6rNu4luPg26JdUDjw14/s2TlZaz2hgR6FNtQpwnkX6gWpcIgEGuzSh2+WKKvHEoi9EID6V1f7CeN5CjWkqCfbPBAF2XXgjtolsw/gTRwV09937xuKXteTTye65kgBvooGcMyg= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: e4adda70-9503-47c7-e61d-08d735c169f6 X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Sep 2019 07:35:11.8603 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 8Y1fgqpDaEqxYcEOkJFZoGarLRtdZ4Fn3c6mEz3fjAuP84MMZ8T7LFbX3eq4b2bCFuUVCWMMnSyECGroLcYWGw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR0502MB3859 Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix transmit descriptor with VLAN insertions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Viacheslav Ovsiienko > If VLAN tag insertion transmit offload is engaged > (DEV_TX_OFFLOAD_VLAN_INSERT in tx queue configuration is set) the > transmit descriptor may be built with wrong format, due to packet length = is > not adjusted. Also, the ring buffer wrapup is not handled correctly. >=20 > Fixes: 18a1c20044c0 ("net/mlx5: implement Tx burst template") > Cc: stable@dpdk.org >=20 > Signed-off-by: Viacheslav Ovsiienko Acked-by: Matan Azrad