From: Matan Azrad <matan@mellanox.com>
To: Dekel Peled <dekelp@mellanox.com>,
Slava Ovsiienko <viacheslavo@mellanox.com>,
Raslan Darawsheh <rasland@mellanox.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2] net/mlx5: fix match on Ethertype and CVLAN tag
Date: Thu, 20 Feb 2020 12:01:18 +0000 [thread overview]
Message-ID: <AM0PR0502MB4019DF57D480AE1DF30CBF55D2130@AM0PR0502MB4019.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <b58f1aaed9b164a10f7a5efa6814c1975f9ecab6.1582198154.git.dekelp@mellanox.com>
From: Dekel Peled <dekelp@mellanox.com>
> HW supports match on one Ethertype, the Ethertype following the last VLAN
> tag of the packet (see PRM).
> Previous patch added specific handling for packets with VLAN tag, after
> setting match on Ethertype.
>
> This patch moves the handling of packets with VLAN tag, to be done before
> and instead of setting match on Ethertype.
>
> Previous patch also added, as part of specific handling for packets with VLAN
> tag, the setting of cvlan_tag mask bit in translation of
> L3 items.
> In case of L3 tunnel there is no inner L2 header, so setting this mask bit is
> wrong and causes match failures.
>
> This patch adds check to make sure L2 header exists before setting cvlan_tag
> mask bit for L3 items.
>
> Fixes: 00f75a40576b ("net/mlx5: fix VLAN match for DV mode")
> Cc: stable@dpdk.org
>
> Signed-off-by: Dekel Peled <dekelp@mellanox.com>
Acked-by: Matan Azrad <matan@mellanox.com>
next prev parent reply other threads:[~2020-02-20 12:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-19 15:15 [dpdk-dev] [PATCH] net/mlx5: fix match on Ethertype Dekel Peled
2020-02-20 11:33 ` [dpdk-dev] [PATCH v2] net/mlx5: fix match on Ethertype and CVLAN tag Dekel Peled
2020-02-20 12:01 ` Matan Azrad [this message]
2020-02-20 13:23 ` Raslan Darawsheh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM0PR0502MB4019DF57D480AE1DF30CBF55D2130@AM0PR0502MB4019.eurprd05.prod.outlook.com \
--to=matan@mellanox.com \
--cc=dekelp@mellanox.com \
--cc=dev@dpdk.org \
--cc=rasland@mellanox.com \
--cc=stable@dpdk.org \
--cc=viacheslavo@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).