From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 15435A0556; Thu, 20 Feb 2020 13:01:22 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5EA051C036; Thu, 20 Feb 2020 13:01:20 +0100 (CET) Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80072.outbound.protection.outlook.com [40.107.8.72]) by dpdk.org (Postfix) with ESMTP id 66E761C028; Thu, 20 Feb 2020 13:01:19 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AFXKSKz2JuLDNMm6MZ1zKz1RrZecI4ZKJhxqxR/l4lUSuTnMa2YdpoP5VpKEx6hAskI0Vwomv3+AcXG0yqWSzm05JvkcTYtM/EPh0fEfNZ0dNZpWuszYpMkWNlS5qL9LXtL6A6zaQC1n784XsVlRJ/s6B7S52yHvxJciIPV5kY5/llPm2bZ/dK+OtMhRI8fzQDtsXGMzcHe1HaUO7bcFLWmjShLGw0bVB1RnvmQRkFKMUrMS9wm3A2AuOEUs4HhQEjz3t430kHf5TFr9un0gIChGOQ3nFz3C/dgiQon+YPmMUTqvxcPZdEUep5Z4OzhFjKrCZfGyPl12SxKEQOr0vg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZP8HEXSa1DmAQVGkTJvgRbHNwAdjM88C6wWL+4ERRKw=; b=dbXGdKrE0zdk2i4iNl1f32e4+luoDSGpJ2iXBfw8pTvR1UvVBF2vre9Tj96AeiOTIWNYkpnHQ42CCB3kyoZVbx3R3K07PapP+DmGyg4Ju70ivzAVOVyzxjlP5wdl+y5nJYfD14pBvxL/vCCKvpun0zEm4WYdpl28oYR5HlxKJ5SC2idb9lM8VAUUQOwSKXOgJnV9RAVJ5+rTW+yINVs8svMBa2OTOIBfL1bnLR3YSh9HttORo1pQ0EyB4zWCw8lkkiwl82Nb1r4JzMvb2K8oukKovWeH0QC2FgEadaOApwhHQLnZf+9Fgv2Ox+HJ9tFk9UTaXHShDkzGa67go7cxEw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZP8HEXSa1DmAQVGkTJvgRbHNwAdjM88C6wWL+4ERRKw=; b=A8SH2hn+4YpOZ8tu2eOifsR0ci1QomYKqMUwP0TXmhFMRrfPCH1xm4Uyp9sLWKV8yjKtioLfii/LDl+n0i9IiCOnHREHE/yaWvtk+9VA3WmMXqj8wf1CiVIv29ExUYGk4GlB+/Qr+Oebr/mJOcWVbl8zA2J81WpRMeJWuRsj8k8= Received: from AM0PR0502MB4019.eurprd05.prod.outlook.com (52.133.39.139) by AM0PR0502MB4001.eurprd05.prod.outlook.com (52.133.36.157) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2729.25; Thu, 20 Feb 2020 12:01:18 +0000 Received: from AM0PR0502MB4019.eurprd05.prod.outlook.com ([fe80::e495:9258:db09:1de8]) by AM0PR0502MB4019.eurprd05.prod.outlook.com ([fe80::e495:9258:db09:1de8%7]) with mapi id 15.20.2729.032; Thu, 20 Feb 2020 12:01:18 +0000 From: Matan Azrad To: Dekel Peled , Slava Ovsiienko , Raslan Darawsheh CC: "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [PATCH v2] net/mlx5: fix match on Ethertype and CVLAN tag Thread-Index: AQHV5+HRkS6NxF6akke0WnznrQasK6gj+vpQ Date: Thu, 20 Feb 2020 12:01:18 +0000 Message-ID: References: <15d7594cc67448389e09213b2ed13e907c471e3a.1582124890.git.dekelp@mellanox.com> In-Reply-To: Accept-Language: en-US, he-IL Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=matan@mellanox.com; x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 5bec624d-acbe-4c71-b09d-08d7b5fc981c x-ms-traffictypediagnostic: AM0PR0502MB4001:|AM0PR0502MB4001: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtFwd x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7219; x-forefront-prvs: 031996B7EF x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(136003)(396003)(39850400004)(366004)(346002)(376002)(189003)(199004)(4744005)(316002)(4326008)(110136005)(8676002)(81166006)(8936002)(81156014)(450100002)(26005)(76116006)(186003)(6636002)(33656002)(54906003)(6506007)(86362001)(55016002)(66556008)(7696005)(66946007)(9686003)(66446008)(71200400001)(66476007)(64756008)(5660300002)(52536014)(2906002)(478600001); DIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR0502MB4001; H:AM0PR0502MB4019.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: x6dHNhQilQxKR3yCCaIuTwNt6foHIehmwBD95eSzqv9yisK2ogoIIOpTO7Z32mJdCemiRk9Pnjq3UV73AEStnTpXjSFYRHYw2VfkUOCEC6BwQCYTsC6FR69/PX7FowSF6EhAn7AtpfgoQa3UHTb1KWMvm+CI+ubMvsKYKMk+7sAlyAqG7d6JTtsPjyvQq5sb5g7InWNogHa5xBoiBkrxh8cu9guHxiPuDKtgTYozg8p9Ugv+bDZhUipdldqOJa1S5pR5HgWrUvj07pW7Mv8Md1bTgIQ+G7JlIkB91NgiTEcRxjfJPwQ9iLGOmFN2YT4too7ljbZekZEdK15n5ZQ2jxUDMlCvl/hp9Neh1t1Rx//6dnZZehTzyJCFProYVgbzwy8hMiOdCwFFz9DheuwwpjeQl7KYrYNDORjUebG617Xs49PfR0UQSKS9E9y9JHro x-ms-exchange-antispam-messagedata: 8/Pa1lXEfBBD9PfYl4N3xZtlE14SdUYW5uwGoMHimJYMbuc7TB0rYbIZHPdKavo7D0IOsBC//WVGTVegnP4xhKr22JaohG+Hne2wwtzoXN8TRSiFuu7rxsoKfeOnWNZPHtzbASXxGxG4ZNVNnVybmg== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5bec624d-acbe-4c71-b09d-08d7b5fc981c X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Feb 2020 12:01:18.2238 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: c08epScSXDuB2cOKyFqjZTJ9g+/oiZzMfzb5MuNnGOB7p+v6fY95eo1w1bsKXs/c4QDIokv9OIMnYuoYHyXGTg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR0502MB4001 Subject: Re: [dpdk-dev] [PATCH v2] net/mlx5: fix match on Ethertype and CVLAN tag X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Dekel Peled > HW supports match on one Ethertype, the Ethertype following the last VLAN > tag of the packet (see PRM). > Previous patch added specific handling for packets with VLAN tag, after > setting match on Ethertype. >=20 > This patch moves the handling of packets with VLAN tag, to be done before > and instead of setting match on Ethertype. >=20 > Previous patch also added, as part of specific handling for packets with = VLAN > tag, the setting of cvlan_tag mask bit in translation of > L3 items. > In case of L3 tunnel there is no inner L2 header, so setting this mask bi= t is > wrong and causes match failures. >=20 > This patch adds check to make sure L2 header exists before setting cvlan_= tag > mask bit for L3 items. >=20 > Fixes: 00f75a40576b ("net/mlx5: fix VLAN match for DV mode") > Cc: stable@dpdk.org >=20 > Signed-off-by: Dekel Peled Acked-by: Matan Azrad