From: Matan Azrad <matan@mellanox.com>
To: Andrew Rybchenko <arybchenko@solarflare.com>,
"Liang, Cunming" <cunming.liang@intel.com>,
"Bie, Tiwei" <tiwei.bie@intel.com>
Cc: "Wang, Xiao W" <xiao.w.wang@intel.com>,
Thomas Monjalon <thomas@monjalon.net>,
"maxime.coquelin@redhat.com" <maxime.coquelin@redhat.com>,
"Wang, Zhihong" <zhihong.wang@intel.com>,
"Yigit, Ferruh" <ferruh.yigit@intel.com>,
Shahaf Shuler <shahafs@mellanox.com>,
Ori Kam <orika@mellanox.com>, "dev@dpdk.org" <dev@dpdk.org>,
Slava Ovsiienko <viacheslavo@mellanox.com>,
Asaf Penso <asafp@mellanox.com>, Olga Shern <olgas@mellanox.com>
Subject: Re: [dpdk-dev] discussion: creating a new class for vdpa driversxiao.w.wang@intel.com
Date: Sun, 8 Dec 2019 07:06:05 +0000 [thread overview]
Message-ID: <AM0PR0502MB4019F5651928D730E9354A42D2590@AM0PR0502MB4019.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <dcc4d77b-c03b-3dfc-0f09-72484157d019@solarflare.com>
From: Andrew Rybchenko
> On 12/6/19 8:32 AM, Liang, Cunming wrote:
> >
> >
> >> -----Original Message-----
> >> From: Bie, Tiwei <tiwei.bie@intel.com>
> >> Sent: Friday, December 6, 2019 12:28 PM
> >> To: Matan Azrad <matan@mellanox.com>
> >> Cc: Wang, Xiao W <xiao.w.wang@intel.com>; Thomas Monjalon
> >> <thomas@monjalon.net>; maxime.coquelin@redhat.com; Wang,
> Zhihong
> >> <zhihong.wang@intel.com>; Yigit, Ferruh <ferruh.yigit@intel.com>;
> >> Shahaf Shuler <shahafs@mellanox.com>; Ori Kam
> <orika@mellanox.com>;
> >> dev@dpdk.org; Slava Ovsiienko <viacheslavo@mellanox.com>; Asaf
> Penso
> >> <asafp@mellanox.com>; Olga Shern <olgas@mellanox.com>; Liang,
> Cunming
> >> <cunming.liang@intel.com>
> >> Subject: Re: discussion: creating a new class for vdpa
> >> driversxiao.w.wang@intel.com
> >>
> >> On Thu, Dec 05, 2019 at 01:26:36PM +0000, Matan Azrad wrote:
> >>> Hi all
> >>>
> >>> As described in RFC “[RFC] net: new vdpa PMD for Mellanox devices”,
> >>> a new vdpa drivers is going to be added for Mellanox devices –
> >>> mlx5_vdpa
> >>>
> >>> The only vdpa driver now is the IFC driver that is located in net directory.
> >>>
> >>> The IFC driver and the new mlx5_vdpa driver provide the vdpa ops and
> >>> not the eth_dev ops.
> >>>
> >>> All the others drivers in net provide the eth-dev ops.
> >>>
> >>> I suggest to create a new class for vdpa drivers, to move IFC to
> >>> this class and to add the mlx5_vdpa to this class too.
> >>>
> >>> Later, all the new drivers that implements the vdpa ops will be
> >>> added to the vdpa class.
> >>
> >> +1. Sounds like a good idea to me.
> > +1
>
> vDPA drivers are vendor-specific and expected to talk to vendor NIC. I.e.
> there are significant chances to share code with network drivers (e.g. base
> driver). Should base driver be moved to drivers/common in this case or is it
> still allows to have vdpa driver in drivers/net together with ethdev driver?
Yes, I think this should be the method, shared code should be moved to the drivers/common directory.
I think there is a precedence with shared code in common which shares a vendor specific code between crypto and net.
Actually, this is my plan to share mlx5 vdpa code with mlx5 net code by the drivers/common dir (see RFC).
Matan
next prev parent reply other threads:[~2019-12-08 7:06 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-05 13:26 Matan Azrad
2019-12-06 4:27 ` Tiwei Bie
2019-12-06 5:32 ` Liang, Cunming
2019-12-06 9:05 ` Andrew Rybchenko
2019-12-06 10:04 ` Maxime Coquelin
2019-12-06 11:22 ` Tiwei Bie
2019-12-08 7:06 ` Matan Azrad [this message]
2019-12-09 7:44 ` Andrew Rybchenko
2019-12-09 10:41 ` Ori Kam
2019-12-09 11:22 ` Andrew Rybchenko
2019-12-10 2:41 ` Tiwei Bie
2019-12-10 8:00 ` Thomas Monjalon
2019-12-10 13:24 ` Tiwei Bie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM0PR0502MB4019F5651928D730E9354A42D2590@AM0PR0502MB4019.eurprd05.prod.outlook.com \
--to=matan@mellanox.com \
--cc=arybchenko@solarflare.com \
--cc=asafp@mellanox.com \
--cc=cunming.liang@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=maxime.coquelin@redhat.com \
--cc=olgas@mellanox.com \
--cc=orika@mellanox.com \
--cc=shahafs@mellanox.com \
--cc=thomas@monjalon.net \
--cc=tiwei.bie@intel.com \
--cc=viacheslavo@mellanox.com \
--cc=xiao.w.wang@intel.com \
--cc=zhihong.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).