From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5FB5AA00C5; Thu, 21 May 2020 17:02:30 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 475BF1D6E2; Thu, 21 May 2020 17:02:29 +0200 (CEST) Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-eopbgr150081.outbound.protection.outlook.com [40.107.15.81]) by dpdk.org (Postfix) with ESMTP id 2D6C01D6C6 for ; Thu, 21 May 2020 17:02:28 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZXZkPiMG6soCsL1lstv1SH1NQYLAWBK3usx8Mwxs7BWZBK6kgJbnd+dT2EA/RgBhJpxIGOttI/Vxb8rwy8MJir3suBKGfrX+UcyBvXW9EigAYf6Ain17Q3RQrDsJG59bsL2QEPkDzlVIc+/9ii/s++Crk0Mf3YdolTflB2owao0NDdKJTbJyAFSuEb5M3gdkcCGIwZsQ0ypi5OyBBbm3V4ekPu0zC5N4ds0jJ45qXZiHRGYYfzy3DqgvK5Si5FXMXSOx3tPomBIjX5S8QOpAnVCcst/9mTR4qSEP3EoDz7oxZfvYiJVLupsZSwxufC0ekxCU87Y05kmD7Q0GfzMj4g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZYkHQS+UGjGGA9scF8S3zahzfq6ES4nVezNvyHhtJno=; b=MWtReBZ49VJKeHw8D7bV8fzYxacvA5hf+TNhederOXBtzi8KStrhmRYRbh0uF1/KNgdodgIXj4behH5jed2pYfGM1cFDv54luw08lJFI1+FToAto/eQKbY2Ba9Q190pKBFJOM/0R04FgUNPPI+GIco5iazt4VaVaKfM0Qn+88jnipNxERzPtUnYgcsMghZHRjuDnD5XY9VEGlmktMGOqVCF+ARk83uXsb9hw/aJfnIoSTW0X0f2U49q8eRKvSeem3iI5cbtMp6VgsrYUk/1oIanYOIZn025WnIsLcBh7Nsc6kaOumW5l3a8/lqhZ78FPB/SdrUh9TETPLnzWgCfJ3Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZYkHQS+UGjGGA9scF8S3zahzfq6ES4nVezNvyHhtJno=; b=nirm4u9dO4OxPDl+czk9ACYpa6Bf4mc0txmXP9uElRPtl7qPdJg9jDqOBrVsBERHuAEeNZBVsDO6YPzkFscfeOaWtT2eR6ZCGywTZ4BfTeByM863BfP68F+KhiQoeiekLIN0uccNDWr0zr33R6l3sKxH/fcu1j4os4iQgav1pV8= Received: from AM0PR0502MB4034.eurprd05.prod.outlook.com (2603:10a6:208:12::14) by AM0PR0502MB3938.eurprd05.prod.outlook.com (2603:10a6:208:2::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3021.24; Thu, 21 May 2020 15:02:26 +0000 Received: from AM0PR0502MB4034.eurprd05.prod.outlook.com ([fe80::a0ec:2aee:7f28:8d22]) by AM0PR0502MB4034.eurprd05.prod.outlook.com ([fe80::a0ec:2aee:7f28:8d22%7]) with mapi id 15.20.3021.027; Thu, 21 May 2020 15:02:26 +0000 From: Fady Bader To: Honnappa Nagarahalli , "dev@dpdk.org" CC: Thomas Monjalon , Tal Shnaiderman , Yohad Tor , "olivier.matz@6wind.com" , "harini.ramakrishnan@microsoft.com" , "ocardona@microsoft.com" , "anand.rawat@intel.com" , "ranjit.menon@intel.com" , "dmitry.kozliuk@gmail.com" , nd , nd Thread-Topic: [dpdk-dev] [PATCH v2] ring: build on Windows Thread-Index: AQHWLpO4W7c95JRAV0CTurvmZG5fKaix8EQAgACzNsA= Date: Thu, 21 May 2020 15:02:26 +0000 Message-ID: References: <20200520104445.9072-1-fady@mellanox.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=mellanox.com; x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 00ab6a25-1708-4f44-295e-08d7fd97f974 x-ms-traffictypediagnostic: AM0PR0502MB3938: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:390; x-forefront-prvs: 041032FF37 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: mu/hMPIHJdgJEwPg0FCXXy1JvNl3Pw3PwveEW+CnIURV7odr3QvwE/AuZyr2Aiyucht7eLA982hirThdBI/KGLlavgkUZdJunjrxIoj6MHx49UX4/6nv7AoiMDV/yGLa9wHCozZ824g73S78tFnnK0avNiwatxLG0xEtxKPXLEhZc0PQvnn5z+b7HhHxPmdLieFFduoj5Fc/WVsr+9hMVhsGJEzckfviEToFisWyE35FqM4U7+kBOZHztIlp4ctr7Lim4Tz/S9ceVcWzfdEm4wOkgfUZRh/UFxLQo2atri5PXki7WJhdsJogZCaPdD4T31LNBVEhUb8zPLLFiewEpQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM0PR0502MB4034.eurprd05.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(376002)(39860400002)(396003)(346002)(366004)(136003)(54906003)(2906002)(110136005)(316002)(478600001)(4326008)(33656002)(45080400002)(8676002)(7696005)(26005)(9686003)(8936002)(6506007)(53546011)(55016002)(7416002)(66556008)(52536014)(66946007)(66476007)(186003)(86362001)(76116006)(5660300002)(64756008)(71200400001)(66446008); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: JMY3TZkFdWKTdzmcIfxNTpWemHsqowOB+xGZfFm2oKnBOviSEQp0e2ois+0EuPGVdgELe5Lqpw6lAf50+IOXyBNz3CRV2KBYp+AY5A2rOJEp1/Etvz+F+uHh6srAn7z0r3jFOtt2ZkkjJ1Va3W5MJ1eef1Fu5e0EkGKIEewls3WmdPBbIDOy/0jY1g+IuAb3A81NteRyuB0I664dkpWQ5ObP4sWY/yDONLXvC4XRzH+4W4FcgOEcPKu29m9MTIdInDdgvO1F1i8rOYRkcGapK4+/cvyaLBViWYbD9CWi2AdaF+HPOG2EOt1PpGG9zX8ontkYD+Zk03KHg3knh/D2BPPDFwszP25r9ivkkLyYGzkUWXM3F0DkLJjEA2T3NyrIxSMrpYsJ7BZoOnJa2fJWDP7cFR5buNEoB8velYb5/+jsRgCnvIUDnHEWgZOUhAWQuMVMiQBDyNt4xZS4og3AWJvKxDqRGG/vTSW2/1u5E4M3ZFuj7S6ABu/EwBzSNkCr Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 00ab6a25-1708-4f44-295e-08d7fd97f974 X-MS-Exchange-CrossTenant-originalarrivaltime: 21 May 2020 15:02:26.1773 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: HlB9cVbuXVjP8Uop2tiRgtO6OiLrzdBLvX8KvOt7G1ENzpeLhgWyADmP86j+oL6FD2695ym/CbSr+aKQkjjopw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR0502MB3938 Subject: Re: [dpdk-dev] [PATCH v2] ring: build on Windows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Honnappa Nagarahalli > Sent: Thursday, May 21, 2020 7:17 AM > To: Fady Bader ; dev@dpdk.org > Cc: Thomas Monjalon ; Tal Shnaiderman > ; Yohad Tor ; > olivier.matz@6wind.com; harini.ramakrishnan@microsoft.com; > ocardona@microsoft.com; anand.rawat@intel.com; > ranjit.menon@intel.com; dmitry.kozliuk@gmail.com; Honnappa Nagarahalli > ; nd ; nd > Subject: RE: [dpdk-dev] [PATCH v2] ring: build on Windows >=20 > >=20 > > Subject: [dpdk-dev] [PATCH v2] ring: build on Window > ^^^^ change t= his to 'eal'. >=20 > Even though the compilation error points to rte_ring, this is not a issue= in > rte_ring library. Suggest changing the commit message to something like > "eal: add per_lcore__rte_errno to export list for Windows". >=20 > > > > Exported per_lcore__rte_errno function to compile ring for windows. > > > > compilation error logs: > > librte_ring_rte_ring.c.obj : error LNK2019: unresolved external symbol > > per_lcore__rte_errno referenced in function rte_ring_lookup > > > > The cause was that per_lcore__rte_errno function wasn't included in > > the export list. > > To solve this per_lcore__rte_errno was added to the Windows export list= . > > > > Signed-off-by: Fady Bader > > Depends-on: series-9374 ("Windows basic memory management") > > --- > > lib/librte_eal/rte_eal_exports.def | 1 + > > lib/librte_eal/rte_eal_version.map | 3 > > +++ > > lib/meson.build | 5 ++++- > > 3 files changed, 8 insertions(+), 1 deletion(-) > > > > diff --git a/lib/librte_eal/rte_eal_exports.def > > b/lib/librte_eal/rte_eal_exports.def > > index 854b83bcd..cbb6b8cfe 100644 > > --- a/lib/librte_eal/rte_eal_exports.def > > +++ b/lib/librte_eal/rte_eal_exports.def > > @@ -1,5 +1,6 @@ > > EXPORTS > > __rte_panic > > + per_lcore__rte_errno > > rte_calloc > > rte_calloc_socket > > rte_eal_get_configuration > > diff --git a/lib/librte_eal/rte_eal_version.map > > b/lib/librte_eal/rte_eal_version.map > > index bdd014638..0f1b983b8 100644 > > --- a/lib/librte_eal/rte_eal_version.map > > +++ b/lib/librte_eal/rte_eal_version.map > > @@ -390,4 +390,7 @@ EXPERIMENTAL { > > rte_trace_point_lookup; > > rte_trace_regexp; > > rte_trace_save; > > + > > + # added in 20.08 > > + __emutls_v.per_lcore__rte_errno; > Not sure why this is required. per_lcore__rte_errno is present already in= this > file. It is needed for the mingw64 compilation on windows. >=20 > > }; > > diff --git a/lib/meson.build b/lib/meson.build index > > d190d84ef..98ee5ec57 > > 100644 > > --- a/lib/meson.build > > +++ b/lib/meson.build > > @@ -36,7 +36,10 @@ libraries =3D [ > > 'flow_classify', 'bpf', 'graph', 'node'] > > > > if is_windows > > - libraries =3D ['kvargs','eal'] # only supported libraries for windows > > + libraries =3D [ > > + 'kvargs', > > + 'eal', > > + 'ring'] # only supported libraries for windows > > endif > > > > default_cflags =3D machine_args > > -- > > 2.16.1.windows.4