From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01on0089.outbound.protection.outlook.com [104.47.0.89]) by dpdk.org (Postfix) with ESMTP id 7D22DDE0; Wed, 28 Feb 2018 09:22:23 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=SuNn23w4vK1EdzOwxtgSQiJJU47+d4v7sFyNmfpQ8cI=; b=CHiR/NobLwDSSkcqWFUVq6UliMvhg4/ceurvGstmD9tcmC4ecKtNRvMdjDX+KMZWrQjAsyDn4flAFfFFF6q+0O1ooXksn1Mt1vJpH2WAc2tw8ZB1V9ZFMzQBz6lL9zpWo3Uq0HAcuawnnyytZqOmw8seDZPtOxThQszYS5a0pmw= Received: from AM0PR0502MB4082.eurprd05.prod.outlook.com (52.133.41.26) by AM0PR0502MB3891.eurprd05.prod.outlook.com (52.133.48.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.527.15; Wed, 28 Feb 2018 08:22:21 +0000 Received: from AM0PR0502MB4082.eurprd05.prod.outlook.com ([fe80::c1e6:bf80:9cd9:739b]) by AM0PR0502MB4082.eurprd05.prod.outlook.com ([fe80::c1e6:bf80:9cd9:739b%13]) with mapi id 15.20.0527.021; Wed, 28 Feb 2018 08:22:21 +0000 From: Shahaf Shuler To: =?iso-8859-1?Q?N=E9lio_Laranjeiro?= CC: Adrien Mazarguil , Yongseok Koh , "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [PATCH] net/mlx5: fix tunnel offloads cap query Thread-Index: AQHTrtmnXqCAdBZUwU+zdXISWpUMLqO5fK7g Date: Wed, 28 Feb 2018 08:22:21 +0000 Message-ID: References: <20180225072837.85663-1-shahafs@mellanox.com> <20180226081234.4e4c7res6g3ccyca@laranjeiro-vm.dev.6wind.com> In-Reply-To: <20180226081234.4e4c7res6g3ccyca@laranjeiro-vm.dev.6wind.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=shahafs@mellanox.com; x-originating-ip: [31.154.10.107] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; AM0PR0502MB3891; 7:w0GXRjOTGJdUk8UL4yuxbozAWFJ3xkIBl4p+tAOkOp7/3dzXfUyLDVYWS9ZRLv+71iwxI8F5eO44wab54BQkxVROR0aaUUE/yJP2k6/4/8vGrIsnuNNlU+x8A9YNvciQjmCNd0+U8EanWYAp9G9rqamEWky+Kdt+Z/Q9ZOxINfcnnf9OqrwKS2be2yOmDWgsoiLcejkmC8tdfmqzbKPq53DWaNIs9cu0yoB9qok94XBHOwCHHFBt/T23WtVz3CJN x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: ec060ec7-d5ae-4d1d-8bf6-08d57e8463c3 x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(4534165)(4627221)(201703031133081)(201702281549075)(48565401081)(5600026)(4604075)(3008032)(2017052603307)(7153060)(7193020); SRVR:AM0PR0502MB3891; x-ms-traffictypediagnostic: AM0PR0502MB3891: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040501)(2401047)(8121501046)(5005006)(3002001)(93006095)(93001095)(10201501046)(3231220)(944501217)(52105095)(6055026)(6041288)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123558120)(20161123562045)(20161123564045)(6072148)(201708071742011); SRVR:AM0PR0502MB3891; BCL:0; PCL:0; RULEID:; SRVR:AM0PR0502MB3891; x-forefront-prvs: 0597911EE1 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(366004)(39380400002)(39860400002)(346002)(396003)(376002)(189003)(199004)(8936002)(186003)(3660700001)(106356001)(99286004)(7696005)(76176011)(3280700002)(81166006)(8676002)(81156014)(5660300001)(66066001)(316002)(3846002)(53936002)(6116002)(26005)(97736004)(9686003)(6246003)(54906003)(5250100002)(55016002)(74316002)(33656002)(6436002)(2900100001)(305945005)(229853002)(105586002)(59450400001)(25786009)(102836004)(2950100002)(68736007)(6506007)(7736002)(14454004)(86362001)(6916009)(2906002)(4326008)(478600001); DIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR0502MB3891; H:AM0PR0502MB4082.eurprd05.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: /eiS4ijB895TF8I74enttS5VVm9wRRr2xmAwofo85n+4RpmT09C6XYhrvlauOxcfUu1/YELy+E8WbkRZTgf+f2b2/pzsaLhumWtQq0XqRR/W2eSfE0Ydc0x7pqXmmfS8hrytomYtjsASGOgR+GIrrpTViP9ogDSE85wwYrx1xhs= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: ec060ec7-d5ae-4d1d-8bf6-08d57e8463c3 X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Feb 2018 08:22:21.6867 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR0502MB3891 Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix tunnel offloads cap query X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Feb 2018 08:22:23 -0000 Monday, February 26, 2018 10:13 AM, N=E9lio Laranjeiro: > On Sun, Feb 25, 2018 at 09:28:37AM +0200, Shahaf Shuler wrote: > > The query for the tunnel stateless offloads is wrongly implemented > > because of: > > > > 1. It was using the device id to query for the offloads. > > 2. It was using a compilation flag for Verbs which no longer exits. > > > > The main reason was lack of proper API from Verbs. > > > > Fixing the query to use rdma-core API. The capability returned from > > rdma-core refer to both Tx and Rx sides. > > Eventhough there is a separate cap for GRE and VXLAN, implementation > > merge them into a single flag in order to simplify the checks on the > > data path. > > > > Fixes: 43e9d9794cde ("net/mlx5: support upstream rdma-core") > > Fixes: f5fde5205101 ("net/mlx5: add hardware checksum offload for > > tunnel packets") > > Cc: stable@dpdk.org > > > > Signed-off-by: Shahaf Shuler > > Acked-by: Yongseok Koh > > Acked-by: Xueming Li [...] > Acked-by: Nelio Laranjeiro Applied to next-net-mlx, thanks.=20 >=20 > -- > N=E9lio Laranjeiro > 6WIND