From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2105FA0350; Wed, 6 May 2020 10:58:26 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 07E571D6D4; Wed, 6 May 2020 10:58:26 +0200 (CEST) Received: from EUR03-DB5-obe.outbound.protection.outlook.com (mail-eopbgr40059.outbound.protection.outlook.com [40.107.4.59]) by dpdk.org (Postfix) with ESMTP id 4C1F91D6D2 for ; Wed, 6 May 2020 10:58:25 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jlITk56gVDFubCRmk7pFjRYaABxxk+QEnUhGw+8Zv/H1qlPgnlFos2LLPWQtVxYaBHsovdlmWUf+lAAcDFJEoo8uD0asXF+iZasUvzrj5rgJDLDg7I45kz2iNz/wSN8MEXNzKJJZfYN0GIRkJarypD8oaYiQDF0goUSpWuB41byb2abOh7N4cXufNrPCZiLTTcVezT5ozwonwkUW0bgNpfoUxW2DmzAhztnQUDInddODjSkJwjiDvI59ov+W8XbOrWF26JQH02V6PG7CAR8lvFPQ8FP7pJ66c57tASbwNpaj5rxbN5EkGlGWjhcj7LBed6lixp/pmLzRGfPPWyVUnQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wh5qYjW80/3XyGw+PeunWT86J/bwQ4ZZUn+L4mIFd9M=; b=duS8gd/ec2N1glznnOTHowVKY816bbwfOoAWOTjbYQ7G2HQQBJEhUgEY5zj1PIgU5zhSg8HAoJ9by8FPoqx+Hi0n1NlOx08zvre6U0tWsoOfyMoqi6S14GJ+tqnJ90CNFkFiZfMQQJT1Txc2jSgBOaKdf5/E3vP93jZTaEMl+BLaKu4UzyF4Yn5mHo5PeLAoURHErbVTpwtHpvrK2hEjUCM1iTrbHeIxuLk9Wduj82mTfu6lryJFj1AViJV06xlJ/lkfoblv7bci7lDlRW8NXqE/wmLfJvtr2WBInIBZ/I6hVFJ3GOJTZ6MGb0g2zLMcEr7+HXiEHiKqXzTGykJg4Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wh5qYjW80/3XyGw+PeunWT86J/bwQ4ZZUn+L4mIFd9M=; b=HyOJ/5+ILEdtBxvLEusw24MMrG2aoqG27YnpxCjMA0/y2zaLl1LBSkuSCUQxHgrSOjrdLa6hQkuqu9yGykIINdUaWroIVnvu6g4NjbnqTuRM8M8EjcGiWLqsVMbsd8cpeJGE9FpiDlWRt/xrKmlR12IBegxTo1wuLBfq30v+DBg= Received: from AM0PR05MB4401.eurprd05.prod.outlook.com (2603:10a6:208:62::20) by AM0PR05MB6628.eurprd05.prod.outlook.com (2603:10a6:20b:15b::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2979.27; Wed, 6 May 2020 08:58:23 +0000 Received: from AM0PR05MB4401.eurprd05.prod.outlook.com ([fe80::7913:410a:98a6:bec5]) by AM0PR05MB4401.eurprd05.prod.outlook.com ([fe80::7913:410a:98a6:bec5%4]) with mapi id 15.20.2979.025; Wed, 6 May 2020 08:58:23 +0000 From: Ali Alnubani To: Gaetan Rivet , "dev@dpdk.org" CC: "wangyunjian@huawei.com" Thread-Topic: [PATCH v1 3/3] net/failsafe: fix default service proxy state Thread-Index: AQHWIxDeT2xO91Y2bUGJiE9DUeFqLqiawoOg Date: Wed, 6 May 2020 08:58:23 +0000 Message-ID: References: <7286631f479ef296b4c6b3ff41c5ca52504b0834.1588705694.git.grive@u256.net> In-Reply-To: <7286631f479ef296b4c6b3ff41c5ca52504b0834.1588705694.git.grive@u256.net> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: u256.net; dkim=none (message not signed) header.d=none;u256.net; dmarc=none action=none header.from=mellanox.com; x-originating-ip: [46.244.76.226] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 997f8d2e-0168-419c-3508-08d7f19ba1bc x-ms-traffictypediagnostic: AM0PR05MB6628: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2043; x-forefront-prvs: 03950F25EC x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 7KJGBPHzyBTRfeylv3Myl977LenmD2I0OmzHCAZ1yLsvLDQdGyci21G6lNjlru14uy3vEtPmIeSI1t0NX2yk420n/rUUO4K2bboaz9WwDeBe1qOiQaj3o+G+elz5rpO/ab61d+7qWIkTrtvmOR/sZDe3y8Qre/e5LZKiQXIxCM0vbl4Yigi7jU01H/AE4012ALFEVtCLEZUL8Kw9J3zdpFXYrRWIxVkP/KalXW9i5VYmB8FYAqQdD1uX7Y88QC8Klf8GX1A8Zxoljswq5Yfrd9R4QrHYjUfxTY25jXDW8Rp/ZeBxqSDqPi/RV/CUXe7yU/f8rwO4utUuYWTrexCog9DQ/oFWz9wAhwwt6MaEYJGx15z7EaMtrtLR7hzdpBZBSZtJ7Y6pNsM4J5dzuJPLKavt7vjXkUY/x1zl0Wt8n7xzlOFPyWJsTffl87kFwmhOL/NAKL6XaJ8Hctln5iPj+2/sOYItlYAHSzQ9ukP7RtnJ1RDqyRSA6eAvcyvv7BK8rCRJw4MKEBcPA6AYY8gXdg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM0PR05MB4401.eurprd05.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(346002)(366004)(136003)(39860400002)(396003)(376002)(33430700001)(4744005)(186003)(110136005)(2906002)(71200400001)(6506007)(53546011)(26005)(478600001)(76116006)(64756008)(5660300002)(66556008)(66446008)(316002)(86362001)(33440700001)(66476007)(7696005)(66946007)(8676002)(9686003)(55016002)(8936002)(33656002)(52536014)(4326008); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: Cvi1m23qfCulkaWSfahQjZLZAOWlqCppto0sYa2PtLP87GRyPW6vuD9flnHUFgAlXPL8th9n+1mcWgIisI5KBPbKKxLkK+CGQDmgul3bWAdL0mAepo47PIjFsH3w2d6XUH831XsKXUImf0VqTP2mIqdLhQzHHTf8uCNWePQ7RF232gQEm/FLKVabYSCIkSOYj5WnJyY1XYMvT65h9g1gDW1gk7Ll23C2tVz3rGU3+fFnE0OGrJjHkL44hh/lf8XLGNjuOcVcJxwjvV0pAVxgFAmyylV4XjzqSmSpRtMAGtEUZuLf0QVKsHL8C38yJ5h37sEIyQ4jMIhBCfJebKjEEoVuLjhjyRsDQJ2dup4TiXYdaU4CIestPgvO2yqyb7st6KWTt/HsbGg7t3/7/36mdkCONxdMx2zBbIk/R/h42gly8VPr8GZtqHcX5DQYqPFZXFgbjaNDXfIDc0ePQ9rIlCIQFEPXTb8psBk6i5HKcOHJmjGELmwc+80O7Uj26CHyWW5CzulKAgg7qZz7obOCVbVBLftEbWUZlXkn0EzVF6RUeECzIN0gKeCnAEdfojlyqW5vwu1tjxkwydPmGqMR1GWKbLvC6kL0A9Oel8AcJXK2P7J9a2Zi/TnIa696dOBm7yFcSLBgijWwsMA0MzDr0cqxehQVO8if8JOLTI5ZwlAHsZSAY/r5vOBtclHM0ho2yR5JJbBQ67PXox0RlvanvgpevZ0vRch/7Bmrikmly0qb3ItMopu9BgNjxkCwATyZ7Ngc662347iezT16pTtavG30QmNZTpP3wRzIcH//JV0= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 997f8d2e-0168-419c-3508-08d7f19ba1bc X-MS-Exchange-CrossTenant-originalarrivaltime: 06 May 2020 08:58:23.0586 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 234rXK8s+WG5JF1QRt0tAi17Pc3aUaL9B91aja2oDadSHbWtY0Ex5tm7Yu0NyNOBq2CEKdxSq+9xHNB3ZdHLww== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR05MB6628 Subject: Re: [dpdk-dev] [PATCH v1 3/3] net/failsafe: fix default service proxy state X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Thanks Gaetan. > -----Original Message----- > From: Gaetan Rivet > Sent: Tuesday, May 5, 2020 10:11 PM > To: dev@dpdk.org > Cc: wangyunjian@huawei.com; Ali Alnubani > Subject: [PATCH v1 3/3] net/failsafe: fix default service proxy state >=20 > The service proxy is initialized at 0. This is assuming that all of its f= ields are > invalid at 0. The issue is that a file descriptor at 0 is a valid one. >=20 > The value -1 is used as sentinel during cleanup. Initialize the RX proxy = file > descriptor to -1. >=20 > Fixes: 366226dd859f ("net/failsafe: fix fd leak") > Signed-off-by: Gaetan Rivet > Cc: wangyunjian@huawei.com > Cc: Ali Alnubani Tested-by: Ali Alnubani