From: Ali Alnubani <alialnu@mellanox.com>
To: David Marchand <david.marchand@redhat.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"vattunuru@marvell.com" <vattunuru@marvell.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] eal/linux: fix build when VFIO is disabled
Date: Sun, 22 Dec 2019 12:13:58 +0000 [thread overview]
Message-ID: <AM0PR05MB440175358685CAB72AE3869AD72F0@AM0PR05MB4401.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <CAJFAV8zj_uaGF4XnU8bH4ACOBr7PR+8=4eiDUrwPUmVkJh0hVg@mail.gmail.com>
> -----Original Message-----
> From: David Marchand <david.marchand@redhat.com>
> Sent: Monday, December 16, 2019 7:22 PM
> To: Ali Alnubani <alialnu@mellanox.com>
> Cc: dev@dpdk.org; vattunuru@marvell.com; stable@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] eal/linux: fix build when VFIO is disabled
>
> On Wed, Dec 11, 2019 at 7:26 PM Ali Alnubani <alialnu@mellanox.com>
> wrote:
> > The header linux/version.h isn't included when CONFIG_RTE_EAL_VFIO is
> > explicitly disabled. LINUX_VERSION_CODE and KERNEL_VERSION are
> > therefore undefined, causing the build failure:
> >
> > lib/librte_eal/linux/eal/eal.c: In function ‘rte_eal_init’:
> > lib/librte_eal/linux/eal/eal.c:1076:32: error: "LINUX_VERSION_CODE" is
> > not defined, evaluates to 0 [-Werror=undef]
>
> The patch itself is ok.
> But, out of curiosity, why would you disable vfio support?
No reason. I noticed the build error by accident actually.
>
>
> --
> David Marchand
Regards,
Ali
next prev parent reply other threads:[~2019-12-22 12:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-11 18:25 Ali Alnubani
2019-12-16 17:22 ` David Marchand
2019-12-22 12:13 ` Ali Alnubani [this message]
2020-01-19 22:42 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM0PR05MB440175358685CAB72AE3869AD72F0@AM0PR05MB4401.eurprd05.prod.outlook.com \
--to=alialnu@mellanox.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
--cc=vattunuru@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).