From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 50CF7A0613 for ; Tue, 30 Jul 2019 13:36:34 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 277821C0D1; Tue, 30 Jul 2019 13:36:34 +0200 (CEST) Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-eopbgr10080.outbound.protection.outlook.com [40.107.1.80]) by dpdk.org (Postfix) with ESMTP id 5625F1C0C1; Tue, 30 Jul 2019 13:36:32 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FMHFEarfjlfeOVjRIHrr2UYga6s93+Q6Z8vz66F01cmrMPS66c8J6uC2v6hiWQpIAjRyuZl3CMcI6IZp1XJi19NEVevfTkC1RzwQ8x5szfoeLP6sCQCxX2l621z75XMhuEtxKIW2f9qilTuH/7nuAQefxBJFWu71KoBNmF7iOQEVHcuAJ9Mf8mggfeTv94WircsT9pRkaJ4nXlRkqwOOCcR2QjM9ghFnc7gwur92J88U4KxpYTJ6kP3lr/yoVERfvI2+OOGnvzPKbeOhcppt7ic74ygdYMWIkvqDvWjAfoK50D69DjMH99NMKu/YfLT+VNnmAo/qEsPBOKNg3hkneA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/DgF3HFuCVLbJKPGPt9euzdUjkh8l03j5dgiwTnBD7Y=; b=TfjlmNYqG8upAk9FMoGoIp6OzQwDZg8hF1csJcuI6O1g3W8N7sSVvYeoG4NUDox+B5dPdnPC9ZR4hQCTBqAC+Ut07hUgrHFyG1c5fOvLtdIu6jeYrB5EKAEE97FsM7HrJ4U/nWSKoao6Oy7r8p9x6aqiQ+Dybd8fTZxVqIQzQflDsth8/vVo9dIuT7YpUYa+vAs+birVGG9R/xRxHAMi4MkJyDb1L4d2WHUzB57v7EMCLGGG66PEfEgj4DVE9x8LMfstT0mDt4eUgi8zZPrevKFI8ApRPcAPm3Jh69+GsY35YJT5zHWYIUIKuPj3NmcACMMzRZjhmI/TjpVCgeRK3Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=mellanox.com;dmarc=pass action=none header.from=mellanox.com;dkim=pass header.d=mellanox.com;arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/DgF3HFuCVLbJKPGPt9euzdUjkh8l03j5dgiwTnBD7Y=; b=KfubiBEb/8X3KrGOpRZ+T5KXknmlskrPtmxlKsYhtmqyWQPu48A66pwlcK4a49vmikpAt5GJpED9Y5s472pZ0GDBCOBtJGHZ3quwPSxGg9gFebCo6OjzN47/qX9DEOyocUPAkp5pio+MgKzZPmH5n/z19TTV1qS0JUy0ht773tQ= Received: from AM0PR05MB4435.eurprd05.prod.outlook.com (52.134.95.151) by AM0PR05MB6611.eurprd05.prod.outlook.com (20.178.117.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2115.15; Tue, 30 Jul 2019 11:36:30 +0000 Received: from AM0PR05MB4435.eurprd05.prod.outlook.com ([fe80::d4a1:f970:c1ae:a0e]) by AM0PR05MB4435.eurprd05.prod.outlook.com ([fe80::d4a1:f970:c1ae:a0e%7]) with mapi id 15.20.2115.005; Tue, 30 Jul 2019 11:36:30 +0000 From: Moti Haimovsky To: Matan Azrad , Matan Azrad , Wenzhuo Lu , Jingjing Wu , "dev@dpdk.org" CC: "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH 1/2] app/testpmd: fix scatter offload configuration Thread-Index: AQHVRrVGDuKwL53X0UWiNjDyjrdTaqbjB+xQ Date: Tue, 30 Jul 2019 11:36:30 +0000 Message-ID: References: <1564403817-13438-1-git-send-email-matan@mellanox.com> In-Reply-To: Accept-Language: he-IL, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=motih@mellanox.com; x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 25b95b24-d20f-46fe-f756-08d714e22ac7 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(5600148)(711020)(4605104)(1401327)(4618075)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7193020); SRVR:AM0PR05MB6611; x-ms-traffictypediagnostic: AM0PR05MB6611: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4125; x-forefront-prvs: 0114FF88F6 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(39860400002)(376002)(396003)(366004)(346002)(136003)(13464003)(189003)(199004)(76176011)(81156014)(2906002)(66446008)(66556008)(64756008)(66066001)(33656002)(53546011)(66946007)(478600001)(76116006)(486006)(66476007)(14444005)(74316002)(9686003)(446003)(86362001)(7736002)(305945005)(55016002)(53936002)(256004)(6506007)(71200400001)(71190400001)(11346002)(5660300002)(68736007)(476003)(52536014)(81166006)(25786009)(14454004)(6436002)(110136005)(6246003)(2501003)(8936002)(6116002)(4326008)(3846002)(229853002)(26005)(102836004)(7696005)(99286004)(316002)(186003); DIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR05MB6611; H:AM0PR05MB4435.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: AJqOiAJdmI6ww+7YtkKcM/rXDfD0b8fZtIpWNATMhzy97CYDuM3D4Pl5sf5xnKdXMziSLdFnBdYsFASfSgwu5HPAtTqFipRPj63qAgTWYVlc4PKod01gw37m1ZI/rvjgpFk1YpL49G1AjnX3Q17uqiOdg4/fQvbWM5weAP4yUoi3q+lXO9wXIfaw5FtWvYmY7BmHkvP6v++7QOLj7VG2jT5HX91gbzhK4ETcWrIptZgjHM7zwp6BzLrT0NXG7E2jQqVW9KZ2WtVQniTVgX552nr9Fn9VD5IaDk5mY94m7qf8xESRYXHBEZWkwoi5WkVT1W6RC8LZNisDPF5zl3OWYEKLeHgFir6n42yUvktwYMZfUjQi6CYrIrSAbAfAMRD4rmju0UIfqOwQN0ZbGav4Gk1ErJ4IGkmXUpfcpBfBlAs= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 25b95b24-d20f-46fe-f756-08d714e22ac7 X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Jul 2019 11:36:30.7747 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: motih@mellanox.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR05MB6611 Subject: Re: [dpdk-dev] [PATCH 1/2] app/testpmd: fix scatter offload configuration X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > > -----Original Message----- > > From: dev On Behalf Of Matan Azrad > > Sent: Monday, July 29, 2019 3:37 PM > > To: Wenzhuo Lu ; Jingjing Wu > > > > Cc: dev@dpdk.org; stable@dpdk.org > > Subject: [dpdk-dev] [PATCH 1/2] app/testpmd: fix scatter offload > > configuration > > > > When the mbuf data size cannot contain the maximum Rx packet length > > with the mbuf headroom, a packet should be scattered in more than one > mbuf. > > > > The application did not configure scatter offload in the above case. > > > > Enable the Rx scatter offload in the above case. > > > > Fixes: 33f9630fc23d ("app/testpmd: create mbuf based on max supported > > segments") > > Cc: stable@dpdk.org > > > > Signed-off-by: Matan Azrad Acked-by: Moti Haimovsky > > --- > > app/test-pmd/testpmd.c | 11 +++++++++++ > > 1 file changed, 11 insertions(+) > > > > diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index > > 518865a..4ae70ef 100644 > > --- a/app/test-pmd/testpmd.c > > +++ b/app/test-pmd/testpmd.c > > @@ -1191,6 +1191,17 @@ struct extmem_param { > > warning =3D 1; > > } > > } > > + if (rx_mode.max_rx_pkt_len + RTE_PKTMBUF_HEADROOM > > > > > + mbuf_data_size) { > > + if (port->dev_info.rx_queue_offload_capa & > > + DEV_RX_OFFLOAD_SCATTER) > > + port->dev_conf.rxmode.offloads |=3D > > + DEV_RX_OFFLOAD_SCATTER; > > + else > > + TESTPMD_LOG(WARNING, "Configure > > scatter is" > > + " needed and cannot be > > configured" > > + " in the port %u\n", pid); > > + } > > } > > > > if (warning) > > -- > > 1.8.3.1