DPDK patches and discussions
 help / color / mirror / Atom feed
From: Alexander Kozyrev <akozyrev@mellanox.com>
To: "eugeny.parshutin@linux.intel.com"
	<eugeny.parshutin@linux.intel.com>,
	Thomas Monjalon <thomas@monjalon.net>,
	"ferruh.yigit@intel.com" <ferruh.yigit@intel.com>,
	"john.mcnamara@intel.com" <john.mcnamara@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
	"roman.p.khatko@intel.com" <roman.p.khatko@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2] ethdev: fix for compiler warning when vtune	profiling option is enabled
Date: Wed, 1 Apr 2020 19:48:44 +0000	[thread overview]
Message-ID: <AM0PR05MB4561F2676BF5D7A8FD23FF79A2C90@AM0PR05MB4561.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <20200401122611.12173-1-eugeny.parshutin@linux.intel.com>

Hi Eugeny, 

> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of
> eugeny.parshutin@linux.intel.com
> Sent: Wednesday, April 1, 2020 8:26
> To: Thomas Monjalon <thomas@monjalon.net>; ferruh.yigit@intel.com;
> john.mcnamara@intel.com
> Cc: dev@dpdk.org; eugeny.parshutin@linux.intel.com;
> roman.p.khatko@intel.com
> Subject: [dpdk-dev] [PATCH v2] ethdev: fix for compiler warning when vtune
> profiling option is enabled
> 
> From: Eugeny Parshutin <eugeny.parshutin@linux.intel.com>
> 
> Add the previous prototype for the 'profile_hook_rx_burst_cb' function to
> fix the compiler warning when the DPDK is built with
> 'RTE_ETHDEV_PROFILE_WITH_VTUNE' config option enabled:
> /home/dpdk/lib/librte_ethdev/ethdev_profile.c:17:1: warning:
> no previous prototype for profile_hook_rx_burst_cb [-Wmissing-
> prototypes]
> 
> Signed-off-by: Eugeny Parshutin <eugeny.parshutin@linux.intel.com>
> ---
> v2: Fix the commit message
> ---
>  lib/librte_ethdev/ethdev_profile.h | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/lib/librte_ethdev/ethdev_profile.h
> b/lib/librte_ethdev/ethdev_profile.h
> index 65031e6f3..b8c3c6848 100644
> --- a/lib/librte_ethdev/ethdev_profile.h
> +++ b/lib/librte_ethdev/ethdev_profile.h
> @@ -24,4 +24,14 @@
>  int
>  __rte_eth_dev_profile_init(uint16_t port_id, struct rte_eth_dev *dev);
> 
> +#ifdef RTE_ETHDEV_PROFILE_WITH_VTUNE
> +
> +uint16_t
> +profile_hook_rx_burst_cb(
> +	__rte_unused uint16_t port_id, __rte_unused uint16_t queue_id,
> +	__rte_unused struct rte_mbuf *pkts[], uint16_t nb_pkts,
> +	__rte_unused uint16_t max_pkts, __rte_unused void
> *user_param);
> +
> +#endif /* RTE_ETHDEV_PROFILE_WITH_VTUNE */
> +
>  #endif
> --
> 2.17.1

Could you please fix the check-git-log.sh warnings:

Headline too long:
        ethdev: fix for compiler warning when vtune profiling option is enabled
Missing 'Fixes' tag:
        ethdev: fix for compiler warning when vtune profiling option is enabled

Regards,
Alex


      reply	other threads:[~2020-04-01 19:48 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-01 11:16 [dpdk-dev] [PATCH] " eugeny.parshutin
2020-04-01 12:26 ` [dpdk-dev] [PATCH v2] " eugeny.parshutin
2020-04-01 19:48   ` Alexander Kozyrev [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AM0PR05MB4561F2676BF5D7A8FD23FF79A2C90@AM0PR05MB4561.eurprd05.prod.outlook.com \
    --to=akozyrev@mellanox.com \
    --cc=dev@dpdk.org \
    --cc=eugeny.parshutin@linux.intel.com \
    --cc=ferruh.yigit@intel.com \
    --cc=john.mcnamara@intel.com \
    --cc=roman.p.khatko@intel.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).