From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 842B1A0350; Tue, 23 Jun 2020 08:45:58 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 398C61D53E; Tue, 23 Jun 2020 08:45:57 +0200 (CEST) Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-eopbgr10060.outbound.protection.outlook.com [40.107.1.60]) by dpdk.org (Postfix) with ESMTP id 6BD101D53A for ; Tue, 23 Jun 2020 08:45:55 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=i7kNOiw35R5GLzRjrpKQJWUNT5nVqIbF6BwC6BUr+S4h6QW+UJi79y9tiKUsfYB4EXSJu2Hvfa3RBbs/yxDr8PYqRki/YGyI0UIPIh0S9WkphWVUiJ8oXmvO6C1vuiN1vL3V1jrKSEzZveR2oAit9j7pHF/k8ilajdlMNPqbcMLSH5Th7ZFRhDP6M+eR0uHYJBV8rfQD5BKP1QFt16tANMeIMgRYZIVjvZGvRvVFdmba2Mjy5UURVlwCPoARuLjRhdo1UEmlytMCyUjgeOKPzN0NVvBvBRwFeuJMBaGK7o8o8pAFiwqnat/TJ9/TcyCqx/5shDtEHA/HWPTTFTnTlQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vZr5Y0gce2s4uHa9ejQz5e9npHA/S+YVkXzwZt70j0o=; b=n6CYFyCaruSwdTZzU03EgUKYdG60U3E7ZRrx1VlUrQc5aau+L0pxXxTk60H2UEyVw4y3eN6wA4rc8eXPaaJM11kwwUMAf7J8Jkz7pfBEQRz2U0YbtTREnQVIzojRSzu3efOlUzmCP1MzVCQWnNwCV3cXoDnxUKoKTtESg7gS5X+Jk6/YSW50BTTjl6UNveEhPza7QFrXMS0lrpgCbRzmmD1jMtZZm9wGPt4ub7VQUF0KQp2OF4iW7qckSN49TfGBOmMZj6QP0Y0jmx9riOGKy+dzflwclC/LxGM7Js3AgRFbF7gbmxZ4jHd/iVVhUIm4CdcwZrb0CO0ukijpDbqh5g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vZr5Y0gce2s4uHa9ejQz5e9npHA/S+YVkXzwZt70j0o=; b=VMkgSmPgjQcE8ubDFhQ6V9LESxwq5EFtfiVipL4lP42lSMUJxUuaZ1MNeeIzCW497KtedCgoHls8dRUYd/17NKXvbajC30tbjkz+12ojTusJ2HSunVALHqxFaVGFKPLK49bPsGXHYsxt28DeUQZSHc51ktyOofiKe8WcfqqxB14= Received: from AM0PR05MB5313.eurprd05.prod.outlook.com (2603:10a6:208:f2::28) by AM0PR05MB4132.eurprd05.prod.outlook.com (2603:10a6:208:61::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3109.22; Tue, 23 Jun 2020 06:45:54 +0000 Received: from AM0PR05MB5313.eurprd05.prod.outlook.com ([fe80::3069:d8f4:fadc:4d7]) by AM0PR05MB5313.eurprd05.prod.outlook.com ([fe80::3069:d8f4:fadc:4d7%5]) with mapi id 15.20.3109.027; Tue, 23 Jun 2020 06:45:54 +0000 From: Tal Shnaiderman To: Thomas Monjalon CC: "dev@dpdk.org" , "pallavi.kadam@intel.com" , "dmitry.kozliuk@gmail.com" , "david.marchand@redhat.com" , "grive@u256.net" , "ranjit.menon@intel.com" , "navasile@linux.microsoft.com" , "harini.ramakrishnan@microsoft.com" , "ocardona@microsoft.com" , "anatoly.burakov@intel.com" , Fady Bader , "bruce.richardson@intel.com" Thread-Topic: [dpdk-dev] [PATCH v8 1/9] eal: move OS common functions to single file Thread-Index: AQHWSGqO2oKyxB9UDEOqmsJoJRr/cqjkuUcAgAEFcEA= Date: Tue, 23 Jun 2020 06:45:54 +0000 Message-ID: References: <20200621102612.22740-2-talshn@mellanox.com> <20200622075529.24180-1-talshn@mellanox.com> <20200622075529.24180-2-talshn@mellanox.com> <1982686.VIimsLeXWE@thomas> In-Reply-To: <1982686.VIimsLeXWE@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=none action=none header.from=mellanox.com; x-originating-ip: [37.142.1.17] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 13306d1c-4217-48a0-8e5c-08d8174113b3 x-ms-traffictypediagnostic: AM0PR05MB4132: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-forefront-prvs: 04433051BF x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: J1h+GEwN2lRLGVkCtnLH1sqW1EMG8mtt871o0CqEFSUmjngJ/pM7xhzJmNapURKzZ6thEgmFdYxzp1bedIVAVOqZROnS2DZFRmnInwD6zjGxUnvEr/1c0bfJZKWED1tqn0yd2/MmnwBxnIqYZWKUj4bDlG0YNLUAUuzCi34KlV1BX6JXcq83UFGMC918ogtzuAi/My+rDSUsXyTgqr2RV4O9c422WT45KBcXoPWDvcZ9zWfwsL8x9quPspWaRJYnZxguS9tqTMBL/Q/oyZHVjEcbD7FF+V1wRjTGERGrbyEhldBCJt7J45zSF5QR19TEVZAIGCr2d+C+e6DmaPIEXg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM0PR05MB5313.eurprd05.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(39860400002)(136003)(396003)(376002)(366004)(346002)(8936002)(478600001)(2906002)(316002)(4326008)(26005)(186003)(33656002)(5660300002)(8676002)(55016002)(66446008)(64756008)(66556008)(83380400001)(66476007)(71200400001)(66946007)(9686003)(76116006)(7696005)(7416002)(52536014)(6916009)(6506007)(86362001)(54906003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: zn+D4mPeRMsk8EW1wCKSF1UmL6s9+Gb9LXFgX20Qd/61Uzx2njAu3WpMBO72mPYx2jeRrvZYC7SOvCbcvouLjpzIfWiKQ/POgr/PEzPQWTwBIwTZp9efnJlyY5oSVt/XpMuYPUBgPUGs3SrY5YJJ/rT2GyTcaMxQkg/W9aPjLnFzkakJqW+d0siunY+u7nhGtipAlFFj6BxMHp1I5ob5NI6YJuQ+PowZb61yblvZbgreJWRWi1U1mq66Se9OY6quODn4B7WD+ZfALpplxFNqN8zwI1fKCf0e/3HAOcAmgIGme4BfLwUdljadxOCKh88OgfqBd5Fyg5xpMoOHvi0+6N1mgXQ0Y/mKLY9aJgIQ49+O847lItxkAuRdyZTx4OoLB83XULA670FlMsr3/3J0C1YLbg07xAHoa1VmQvhQDfj5KYTGZ5RWlUWJ2Rbm+kdZ6ulDhNza1qnAupUoEWhn1MnC7P2loZrl64Vp9PJWcwM= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 13306d1c-4217-48a0-8e5c-08d8174113b3 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Jun 2020 06:45:54.1633 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: NEyt9gEr2tNlmcKtUkLbE4JfS5QyXUUq4Vu6MXOGarN88BgF9CwKk2t5kKPjBxT7fRcd7BONMji7WMIVr9SUdA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR05MB4132 Subject: Re: [dpdk-dev] [PATCH v8 1/9] eal: move OS common functions to single file X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > Subject: Re: [dpdk-dev] [PATCH v8 1/9] eal: move OS common functions to > single file >=20 > Can we reduce the scope in the title? > This patch is about EAL config in general, so I would reword it to: > eal: move OS common config objects >=20 Agree, will change in v9. > 22/06/2020 09:55, talshn@mellanox.com: > > +#include > > + > > +#include > > +#include >=20 > Local files, like eal_*, are usually included with "". >=20 > [...] > > +/* Allow the application to print its usage message too if set */ > > +static rte_usage_hook_t rte_application_usage_hook; >=20 > This is not config-related. > Could it be in a separate patch? > Moved to lib/librte_eal/common/eal_common_options.c? >=20 Agree, will change in v9. > [...] > > +void > > +rte_eal_set_runtime_dir(char *run_dir, size_t size) { > > + strncpy(runtime_dir, run_dir, size); } >=20 > This function should be private to EAL, no rte_ prefix. >=20 > [...] > > +/* Return a pointer to theinternal configuration structure */ >=20 > Space missing >=20 > > +struct internal_config * > > +rte_eal_get_internal_configuration(void) > > +{ > > + return &internal_config; > > +} >=20 > This function should be private to EAL, no rte_ prefix. > When creating the new functions I based the pattern on the already existing= function rte_eal_get_configuration() which encapsulates the formally global rte_conf= ig. Do we want to remove the rte_ prefix from this function as well? =20 > [...] > > --- a/lib/librte_eal/include/rte_eal.h > > +++ b/lib/librte_eal/include/rte_eal.h > > +void > > +rte_eal_set_runtime_dir(char *run_dir, size_t size); > > + > > +void > > +rte_eal_config_remap(void *mem_cfg_addr); > > + > > +struct internal_config * > > +rte_eal_get_internal_configuration(void); > > + > > +rte_usage_hook_t * > > +rte_eal_get_application_usage_hook(void); >=20 > If some new function must be added in the API, they must be clearly > documented with doxygen. > But as part of this refactoring, I guess we should have zero new API. > Probably that those 4 functions are candidate to internal header files. >=20