From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 32581A0350; Sun, 28 Jun 2020 14:32:17 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D5B201C220; Sun, 28 Jun 2020 14:32:16 +0200 (CEST) Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-eopbgr50058.outbound.protection.outlook.com [40.107.5.58]) by dpdk.org (Postfix) with ESMTP id 0B8841C21F for ; Sun, 28 Jun 2020 14:32:15 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=A8twx0mRzG3KqRJc2FSb3t28zSG87/1QOVErJP/ruMKz19FKHlPoP58Tkyx+Y+wK9ljjasti0K0jcyEf7u1R8zW1reP7B5Be6NDWXNIUneSpORArOsAqIh2TVhXCBnw3bcBXtxkvFPfveGdOAc/caoUxRG26LfxGhYSRKCH8dg/q/XrTVbMiQCPmX+acZ9WEYe6ENmQobUTU8DsfnluSZyqaFQb8MhaHGxoiz4hNV+F1Jrlds15b922IDLPWx4BIbtwrTNveyL0j8S6mfuWp5MRdCRZSI/hz5FuZJx8iMC7o4uKoLmj4r705Ey0HMOiboW8+8Qwfu6YpEg0aefCJ5g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=w+GtU1hD9zWJkDaicDF6cpMrIxEX8cf8HYF+iOUxAuI=; b=WIFIQZLgELLWjSzM44IeqsHtPjL0x1Dh6VoNPq8ettR/CIC0BqJo4aTM+ZEfGjcqkfOgybdUkTlJRjWKlqRf8AANDb2wJeg0GObKPT4ZakZrc1uEGTidLy+7RQ8BoG/OCMdWp47W4U8jPLBz+av/64hii1oWhxaHyAw6k2Dxo7TUUZUOL126/6MCIP6sKKkVPNcIuPGiWxo1LamaoqgZyvRcJtvowQoonLuFr1YEElcF6eanPJmslaa+iBoJFwU6RI81HhqvKIHw7LR+B93Jp135sdA892SpI2CHdSEe9TRqHUxQ38+T/66F1gzvZwKEe8YLx7BNfBHOqBHAFI7nMw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=w+GtU1hD9zWJkDaicDF6cpMrIxEX8cf8HYF+iOUxAuI=; b=YEhU3/a8UPKB9WwEDnK/cNFxWr5UcDA5fl0KR/OCHm7/b6nVRGPb43yJFKwGhw17M68lkYBmic1eFWMv0ljzA0hIRMXwVhxqgK1Y8TT5zIP+L/0q4AxhYjnWpwW81RhU9hLvsFLq/j7CvjpkecVrB6FudFTeXC8a2/EHiJ0GkYs= Received: from AM0PR05MB5313.eurprd05.prod.outlook.com (2603:10a6:208:f2::28) by AM0PR05MB6834.eurprd05.prod.outlook.com (2603:10a6:20b:15e::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3131.21; Sun, 28 Jun 2020 12:32:15 +0000 Received: from AM0PR05MB5313.eurprd05.prod.outlook.com ([fe80::9da9:e159:add2:64ee]) by AM0PR05MB5313.eurprd05.prod.outlook.com ([fe80::9da9:e159:add2:64ee%3]) with mapi id 15.20.3131.026; Sun, 28 Jun 2020 12:32:14 +0000 From: Tal Shnaiderman To: Narcisa Ana Maria Vasile CC: "dev@dpdk.org" , Thomas Monjalon , "pallavi.kadam@intel.com" , "dmitry.kozliuk@gmail.com" , "david.marchand@redhat.com" , "grive@u256.net" , "ranjit.menon@intel.com" , "harini.ramakrishnan@microsoft.com" , "ocardona@microsoft.com" , "anatoly.burakov@intel.com" , Fady Bader , "bruce.richardson@intel.com" Thread-Topic: [PATCH v9 00/10] Windows bus/pci support Thread-Index: AQHWSgGUDQcV/okX+06K2wTPauTSpqjrt9KAgAI+SwA= Date: Sun, 28 Jun 2020 12:32:14 +0000 Message-ID: References: <20200622075529.24180-2-talshn@mellanox.com> <20200624082847.21344-1-talshn@mellanox.com> <20200627015439.GB10439@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> In-Reply-To: <20200627015439.GB10439@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: linux.microsoft.com; dkim=none (message not signed) header.d=none;linux.microsoft.com; dmarc=none action=none header.from=mellanox.com; x-originating-ip: [37.142.1.17] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: d580a8e9-2a8f-473b-a79d-08d81b5f49ef x-ms-traffictypediagnostic: AM0PR05MB6834: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1148; x-forefront-prvs: 0448A97BF2 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 2FhgGEP/DJ6ncPTleENJCa9pfhkggAgtiir9aocCepuRNYk03akSfUWwbJflCvwAhwGunez8hyj7zFmXFXshvLQloPHYE1St0qdv8h5Txj0RGcfTb4cijVhjXjeVukOLMnvO/AUau/tFb2InSY0XlSgztty2SHZ6pY2DqbFaAZx1SHZ/3NYZl+p9YJrmkC4R8Qn6F8kEiZ2rw1dCWfYRTPkPPFqfxfq8ENER+JycRQkyeIz21rzvdVY6KFKvYnpYJMZm0GJHTGjxZpC+VSvADUZUv+65+rPBCroEIgDYsFibLBwntHm6riUwqasZH8IY x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM0PR05MB5313.eurprd05.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(39860400002)(346002)(136003)(396003)(376002)(366004)(2906002)(7416002)(5660300002)(52536014)(316002)(8676002)(8936002)(86362001)(6916009)(54906003)(6506007)(4326008)(55016002)(9686003)(76116006)(66946007)(66446008)(64756008)(66556008)(66476007)(7696005)(71200400001)(33656002)(26005)(83380400001)(186003)(478600001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: fxvvz3XsXjIAIwrLepndy3AZd2zDWLmBokl6TFvGlr3pKgPZjVWPXx2EkIJWHaobEVSWtvinDEk2ez8S6601SQlXRJ6CVR2+sOC6c3ORw8Pims2n4qy/Av3fkuSQSu5HYJEMH+jdtA8lkCRJ9U2vmL0I9eZirzYT06agjsrw5l4f2H20Eyqcgha1Jugsn5eFf3ClvxF+ESal3OB1xCnWZlBI2gsy6PPwoWiJ2H2sE2h5zIyDpP0+kVBqAKnEEjc2BH+y6Og5je7XGhI+bz0fHLqFRa95iFHcl4awAvwMZxBo6ujSnW7bPNHXcrBhWOSKhX6XrQlJNLGn/PV+T7aVcaSy9WvGlwFFQZe5VeXR/u3a18IfF4hfDxaUIxgLEVdpMAQUTEdfMJDkq0u1/mHnNxQqn5SucrdkeCRautQ4/LIn1H6y8V1cHYVtJqcQf50vw5PKKo96Ri6DX5Yv230tMK4Ys8HaaE2Ci99p/5TCql4= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AM0PR05MB5313.eurprd05.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d580a8e9-2a8f-473b-a79d-08d81b5f49ef X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Jun 2020 12:32:14.7362 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: +1pjBXjnTNL5pzgOqm4I8em+oVjTRepysJSW7VcmwptOI0kT4zy1Pm4CYrKPdQguiFOzIxkacYsizZnf4N8GMw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR05MB6834 Subject: Re: [dpdk-dev] [PATCH v9 00/10] Windows bus/pci support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > From: Narcisa Ana Maria Vasile > Subject: Re: [PATCH v9 00/10] Windows bus/pci support >=20 > On Wed, Jun 24, 2020 at 11:28:37AM +0300, talshn@mellanox.com wrote: > > From: Tal Shnaiderman > > > > This patchset implements the EAL and PCI functions needed for probing > PMDs using RTE_KDRV_NONE on Windows. > > > > --- > > v9: > > * Split the patch of common OS file to config and options patches > (ThomasM). > > * Remove rte_ prefixes from new functions as they are eal internal > (ThomasM). > > ^ Move common declarations to eal_private.h. > > * Add get_pci_hardware_id and parse_pci_hardware_id in pci.c > (DmitryK) > > * Fix issues in pci.c (DmitryK) > > v8: > > * Move internal_config to static inside eal_common_config.c and use > getters for all external uses. > > * Fix duplicated export line (FadyB) > > * Fix FreeBSD missing function. > > v7: > > * Remove Unneeded code from MinGW mapping script (DmitryK) > > * Fix error flow issues in pci.c (DmitryK) > > * Fix Unix build errors following unity of common functions. > > * Move strerror to rte_strerror (DmitryK) > > v6: > > * Fix duplication of exported functions for mingw by modifying the > version.map in build (new commit) > > * Fix comments and move additional functions to > eal_common_config (DavidM) > > * Fix cross-compilation in mingw (DmitryK) > > * Fix Warnings > > * Move off_t type to pci (ThomasM) > > v5: > > * Adjust mem-mapping functions to changes in latest memory > management patchset. > > * Fix incorrect implib definition in drivers/meson.build > > v4: > > * Fixed various warnings and naming conventions(DmitryK). > > * Fixed broken mingw-64 build(DmitryK). > > * Improved logging(DmitryK). > > * Added patch to fix warnings on rte_pci_addr logging. > > * Fixed broken make on linux/freebsd. > > v3: > > * Changes in BDF and hardware ids retrieval(DmitryK). > > * Apply new generic MM to all pci unix callers(DmitryK). > > * Minor corrections in pci.c(DmitryK). > > v2: > > * fix style issues. > > * fix error handing flow in pci.c > > * change eal_config.c to eal_common_config.c > > --- > Compiled successfully with clang 9.0.0. > 2 warnings are generated, suggesting using safer versions of getenv() and > strncpy(). strncpy() warning will go away in v10 after applying the comment from Thoma= s to modify it to strlcpy. getenv() is a bit tricky: a) The function it is being used in (rte_pci_get_sysfs_path) is a UNIX only= function, from the usage of the function it seems getenv is safe to use. b) Changing to code to getenv_s, _dupenv_s or GetEnvironmentVariable would= mean that the user will now need to handle a buffer to store the value of = the environment variables. Do we want to modify it for rte_pci_get_sysfs_path and all of the call site= s? Looks like we can ignore this warning in this case. > Do we have any test application to test with? dpdk-helloworld runs > successfully. You can use rte_bus_scan() inside rte_eal_init() to test the scanning proce= ss.