From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id DF4ACA00C5; Mon, 6 Jul 2020 10:01:10 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id DDE6A1D420; Mon, 6 Jul 2020 10:00:59 +0200 (CEST) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2070.outbound.protection.outlook.com [40.107.20.70]) by dpdk.org (Postfix) with ESMTP id 782B51C199 for ; Mon, 6 Jul 2020 10:00:59 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=De5nJD2cNhHRulVprs/cFq47bEZhqTSxtmzqRvsIjtCx04r6WKt0b9vPovtjHwtSclQ+A4FbhwAgJHDhGJzfBoc072Nik0+5CtJdBlGAb30pbFYuvfVhvHRMtoRZiguA0WJkuOCrRvPkU2tb/gdmPjz268PjRQnooWk182SV5EgHmyLKF4yIt8/JrtBDHxu5vzdlpFA/VaXyXXc77SN5mzLEj+WhjoGxL9MLi6VRQGRVPzBCfJ0Cqief7qhCZn3mAauuG1qoxQuDF83+Wo6S25W6aAOIX15l28zvud1OAwK+W9oOaDN1VNJf4+Xrkz9efA/c29wje9BGL+OlGGe+sg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wmkDQvEmW93VwpNp/S5bqGBSR9e9+KG+SFM8Ivi8pIs=; b=ftAqmi4drKFN/9YXaoYpkk8UfOWOHh7uRVRh27hOhys+ApfM58Y7fBtxJ3JKJ61PxIgF2BcYlYJv0qihnpo7SAGcQpktnveH+J9WTtIMJPb8xojeBWUTyxA6NnvgN8Wc3iHjmJXPY7xoMu+PvDXGvoZlFLneeSzlyJyBQaC2EMfCvGXoKPrQCnkkXuksEzb4ESKLa0nQjCsKSNNwStzuygZaSeE3dIoV+poAe/40xGQNjrfjxOChCU6wUWXqNIH97WfR5GUMQLpXRh2FqO/l49yKeVbomDwpKQ0UYVlbG+BSTkOqv3h64rfuAt1tze2GJ0e58QDpynTdIX5yy5S3UA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wmkDQvEmW93VwpNp/S5bqGBSR9e9+KG+SFM8Ivi8pIs=; b=mohIjrihBHugMHzKkF3EKMtecReRGQCXLUlKkCV6WYdu9LjdcawjIaMEnnpSexU8nt1hEViFOwGLN3SmJW+6SDHXkq4QpcoTj9TR40PxFisq7yBNir04hzqxB2sSqu+9JEEV0ZRkNxNnKBmchPX5UJAlOWRgfN8TY3oCP5VgtUM= Received: from AM0PR05MB6610.eurprd05.prod.outlook.com (2603:10a6:208:12f::18) by AM0PR05MB6321.eurprd05.prod.outlook.com (2603:10a6:208:13e::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3153.20; Mon, 6 Jul 2020 08:00:58 +0000 Received: from AM0PR05MB6610.eurprd05.prod.outlook.com ([fe80::103:d46f:87df:6525]) by AM0PR05MB6610.eurprd05.prod.outlook.com ([fe80::103:d46f:87df:6525%7]) with mapi id 15.20.3153.029; Mon, 6 Jul 2020 08:00:58 +0000 From: Wisam Monther To: Thomas Monjalon CC: Jack Min , "david.marchand@redhat.com" , "dev@dpdk.org" , Asaf Penso , "arybchenko@solarflare.com" Thread-Topic: [dpdk-dev] [PATCH] app/flow-perf: fix condition of hairpin queues setup Thread-Index: AQHWTrX3dXulJ21bRUKFwM4AIqMi3aj5e1wAgAC+HjA= Date: Mon, 6 Jul 2020 08:00:58 +0000 Message-ID: References: <20200630081028.21339-1-wisamm@mellanox.com> <31256849.VAYTUQ5BGV@thomas> In-Reply-To: <31256849.VAYTUQ5BGV@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=none action=none header.from=mellanox.com; x-originating-ip: [84.242.49.134] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 77cf143e-1fa9-4123-d7ed-08d82182b7da x-ms-traffictypediagnostic: AM0PR05MB6321: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-forefront-prvs: 04569283F9 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: bKJu+aNuKc+E6mHOOggVRwgTc/qd3OVESNcBRygtQPke/WuZ2OJLq9snWji8gOZgaYV/15Rnm8/qb1pbl71guU3UVRdc38Pcy2N+p0XZwpH8YEsuJCnrZ1azJ4BAlhUh4GxRPQyC3vDOpIKjgFjF7PlMAVKvTmeYt8tbJUR2zVylkI5G15/bQ8RXAdQ0nAj14/pBFMKUqt/pdnf8ilMo/KAqtWNYMvpRUPNonmb8MwksF13dOK/j23x6CwBT38k9nqWpOfkcfDLwuTfl1z1WThzWQ5Fsb4YDzDi0WryZA6I0T18Oi8AcxnqStB6Imxw9TyXyOQ0ihcnucjV9l4Zogkm39sjUG9qz63ozzb9atp76QPKoGCOPncKhn7NLQU+59jkC0I2uSOfx8N1OINz66w== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM0PR05MB6610.eurprd05.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(136003)(396003)(39860400002)(346002)(376002)(366004)(76116006)(4326008)(186003)(54906003)(6916009)(86362001)(8936002)(8676002)(2906002)(33656002)(55016002)(316002)(9686003)(6506007)(966005)(26005)(83380400001)(478600001)(66446008)(71200400001)(52536014)(66946007)(66556008)(66476007)(64756008)(7696005)(5660300002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: CobYPehMIag/9+wnZ4A+xqrZoLAFKvn4DY1hyAZlk5S5WrSxDfnQ3mazwBs0fcGp8n6z3o/3aLF+M35vIvOeCdPJpQthm51LiQ3NSxf0oEN3pQWyvcebbRrr22SOsWfxlE6TboQcbeFMlXYMvbLp3lGQBvfy2e6DnejC3Hx3UZFjm3Ag5X9A1VBQ4TOi16Jq3dX1a82+n7PPgKxEDos3UEY2QlK1pW1wTVrzj6HYppKeOVpVUz2hwSy/Fg82sPCbipwpFfcGJEZeuia+WOajMynBUNBUTTqpnTnGyMFTEJYyr2ntSnunN4/SrD35wh4AOK/B7Rr7OI4iODNh7aJS5OBQVokVbTaLtIRB6ZM+dyHo0uQNXU6/jf89aoNdMBJpjAL/zu1neSmZ2A9DnH33AFkgvX9GfvFGbAS1p5IGMcjFPksMO4Pn0FiqCRgD0Awt6cH/h3kL+n3uXOqE9KmwlFf2E4TgmIeOgg6YTyqsz2M= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AM0PR05MB6610.eurprd05.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 77cf143e-1fa9-4123-d7ed-08d82182b7da X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Jul 2020 08:00:58.6033 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ukmajjx/9DQSHm8Qm78ny6QGWzcBspTHEtSNzoK92+wPie50r49h6XSukZtcUFi05m/e8A69T2bnbuaHx1oZBA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR05MB6321 Subject: Re: [dpdk-dev] [PATCH] app/flow-perf: fix condition of hairpin queues setup X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, >-----Original Message----- >From: Thomas Monjalon >Sent: Sunday, July 5, 2020 11:40 PM >To: Wisam Monther >Cc: Jack Min ; david.marchand@redhat.com; >dev@dpdk.org; Asaf Penso ; >arybchenko@solarflare.com >Subject: Re: [dpdk-dev] [PATCH] app/flow-perf: fix condition of hairpin qu= eues >setup > >30/06/2020 10:10, Wisam Jaddo: >> The hairpin queue is the one that start from normal rxq, and will be >> less than nr_queues where nr_queues is the sum of normal and hairpin >> >> Fixes: bf3688f1e816 ("app/flow-perf: add insertion rate calculation") >> Cc: wisamm@mellanox.com >> >> Signed-off-by: Wisam Jaddo > >You should take this opportunity to document the logic for the allocation = and >peering of hairpin queues. > >It would be good to add short code comments for the variables as well. >It confusing to have hairpinq and hairpin_q variables. > >Currently, we cannot really understand whether this fix is good or not. I've sent V2 with the fix + those documentation. > >On hairpin topic, I suggest fixing this typo: > hairping-rss -> hairpin-rss I've provided another patch to fix this typo: http://patches.dpdk.org/patch/73162/ > >