* [dpdk-dev] [PATCH] net/mlx5: fix zero value check for set tag action
@ 2020-03-09 13:12 Wisam Jaddo
2020-03-12 9:35 ` Wisam Monther
0 siblings, 1 reply; 2+ messages in thread
From: Wisam Jaddo @ 2020-03-09 13:12 UTC (permalink / raw)
To: dev, rasland, matan; +Cc: viacheslavo, stable
If we allow to have data <xxx> and mask <0x0> we might
hit a zero data value that will not do any effect
Fixes: e554b672aa05 ("net/mlx5: support flow tag")
Cc: viacheslavo@mellanox.com
Cc: stable@dpdk.org
Signed-off-by: Wisam Jaddo <wisamm@mellanox.com>
---
drivers/net/mlx5/mlx5_flow_dv.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/net/mlx5/mlx5_flow_dv.c b/drivers/net/mlx5/mlx5_flow_dv.c
index e7278f0..edd0065 100644
--- a/drivers/net/mlx5/mlx5_flow_dv.c
+++ b/drivers/net/mlx5/mlx5_flow_dv.c
@@ -2160,6 +2160,10 @@ flow_dv_validate_action_set_tag(struct rte_eth_dev *dev,
return rte_flow_error_set(error, EINVAL,
RTE_FLOW_ERROR_TYPE_ACTION, action,
"zero mask doesn't have any effect");
+ if (!(conf->data & conf->mask))
+ return rte_flow_error_set(error, EINVAL,
+ RTE_FLOW_ERROR_TYPE_ACTION, action,
+ "zero value has no effect");
ret = mlx5_flow_get_reg_id(dev, MLX5_APP_TAG, conf->index, error);
if (ret < 0)
return ret;
--
2.7.4
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dpdk-dev] [PATCH] net/mlx5: fix zero value check for set tag action
2020-03-09 13:12 [dpdk-dev] [PATCH] net/mlx5: fix zero value check for set tag action Wisam Jaddo
@ 2020-03-12 9:35 ` Wisam Monther
0 siblings, 0 replies; 2+ messages in thread
From: Wisam Monther @ 2020-03-12 9:35 UTC (permalink / raw)
To: dev, Raslan Darawsheh, Matan Azrad; +Cc: Slava Ovsiienko, stable
-----Original Message-----
From: Wisam Monther <wisamm@mellanox.com>
Sent: Monday, March 9, 2020 3:13 PM
To: dev@dpdk.org; Raslan Darawsheh <rasland@mellanox.com>; Matan Azrad <matan@mellanox.com>
Cc: Slava Ovsiienko <viacheslavo@mellanox.com>; stable@dpdk.org
Subject: [PATCH] net/mlx5: fix zero value check for set tag action
If we allow to have data <xxx> and mask <0x0> we might hit a zero data value that will not do any effect
Fixes: e554b672aa05 ("net/mlx5: support flow tag")
Cc: viacheslavo@mellanox.com
Cc: stable@dpdk.org
Signed-off-by: Wisam Jaddo <wisamm@mellanox.com>
---
drivers/net/mlx5/mlx5_flow_dv.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/net/mlx5/mlx5_flow_dv.c b/drivers/net/mlx5/mlx5_flow_dv.c index e7278f0..edd0065 100644
--- a/drivers/net/mlx5/mlx5_flow_dv.c
+++ b/drivers/net/mlx5/mlx5_flow_dv.c
@@ -2160,6 +2160,10 @@ flow_dv_validate_action_set_tag(struct rte_eth_dev *dev,
return rte_flow_error_set(error, EINVAL,
RTE_FLOW_ERROR_TYPE_ACTION, action,
"zero mask doesn't have any effect");
+ if (!(conf->data & conf->mask))
+ return rte_flow_error_set(error, EINVAL,
+ RTE_FLOW_ERROR_TYPE_ACTION, action,
+ "zero value has no effect");
ret = mlx5_flow_get_reg_id(dev, MLX5_APP_TAG, conf->index, error);
if (ret < 0)
return ret;
--
2.7.4
Hey Guys,
This patch not relevant anymore
Thanks,
Wisam Jaddo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-03-12 9:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-09 13:12 [dpdk-dev] [PATCH] net/mlx5: fix zero value check for set tag action Wisam Jaddo
2020-03-12 9:35 ` Wisam Monther
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).