From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id AA932A0556; Thu, 20 Feb 2020 15:06:16 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D34F91BF98; Thu, 20 Feb 2020 15:06:15 +0100 (CET) Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2062.outbound.protection.outlook.com [40.107.21.62]) by dpdk.org (Postfix) with ESMTP id B8A6123D; Thu, 20 Feb 2020 15:06:14 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=N9zS7U7DlWbfw54AcW3I/hkESkpVTXHOq7m2lyyqwYheOX5w9G4acim6mQ3UMvfv4R4ET3Bd0Gv9vV4cgfhb2karR/Ox0fg7r4J7QS6wIVAcrEr6kYeXH64+VpV/VFeTNqR42fCbhWJXf7Elg5+a9xumMii2hJeENIRrVKuEdVvrMqLJZkPd4T+G/JGJMKB2FQTIhyH4NyxPPStgAxw/JN6J+a7H9cpwJo8fbTgLjrTVX6ilbzeNacVkC6soWmTjkpkBm7lCMyiywMMc/HK2iPet6UpssbfM4L7gSFCK6K2fJpPajXWY7mws+JySkpv5ZBYxusJDzqeL77opZWa0yg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9KeW1w5orlgknezOTFHcdxWThfqIVR0h5WnyPtNRIhw=; b=cDITJ7g5bljtP70UKCEu7Aa+MA9TlrknNDmI+JEWbW6U7BMgF6dV1xZ1tJQ2EyBijhcaF2uoHqcW8OnfAMQqNGIv2X1BcrPeZnsT2aZ08E9JzvMlXmenUOnOpfdAtq6VSzGdqJA5uMG8vJmHPtgve+ghFKJDSqREBtcPeecsheysNY4Ge98FOirRmf9q8ZYe9Q/rwXbQV6unffZhWw+xsqw0GojXJwHM3baBpbzxH3eLbBIYO7XqUVHPB4cETYxdR/4JEfulpJqchs0jrLJMHPp4ttRphZHAGmtSxax6D2OJocxLXc4oHAEqzGzK5tqdYHrec8l0hDavj/k7ZgA79g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9KeW1w5orlgknezOTFHcdxWThfqIVR0h5WnyPtNRIhw=; b=E40aBSSvqQxFCWQojkoD1RBvefvJo/j6F/MYHI2rhYtB9srIiJttAFBtHsEw0FckpRb2T1xOB6VArN0nZTqju6lFGkrylXImifzUcym1SxSYfx8tlcTfHDJB8zaXWHLICdZN5lKOjFUABY9ov3u1f2AfAUoii9njk8kFzZVYMr4= Received: from AM0PR05MB6610.eurprd05.prod.outlook.com (20.178.202.18) by AM0PR05MB5921.eurprd05.prod.outlook.com (20.178.117.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2729.31; Thu, 20 Feb 2020 14:06:12 +0000 Received: from AM0PR05MB6610.eurprd05.prod.outlook.com ([fe80::f9b0:5b27:21a3:c758]) by AM0PR05MB6610.eurprd05.prod.outlook.com ([fe80::f9b0:5b27:21a3:c758%3]) with mapi id 15.20.2750.016; Thu, 20 Feb 2020 14:06:12 +0000 From: Wisam Monther To: Thomas Monjalon CC: "dev@dpdk.org" , Raslan Darawsheh , "stable@dpdk.org" , "olivier.matz@6wind.com" , "bernard.iremonger@intel.com" Thread-Topic: [dpdk-stable] [PATCH] lib/cmdline_rdline: increase command line buf size Thread-Index: AQHV5/BCwHQemeTezkyKJVffJRqGaagkF1oAgAABOOA= Date: Thu, 20 Feb 2020 14:06:12 +0000 Message-ID: References: <1582204709-7992-1-git-send-email-wisamm@mellanox.com> <4718348.687JKscXgg@xps> In-Reply-To: <4718348.687JKscXgg@xps> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=wisamm@mellanox.com; x-originating-ip: [212.29.221.74] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: fbb43af4-1039-47a7-b821-08d7b60e0b04 x-ms-traffictypediagnostic: AM0PR05MB5921:|AM0PR05MB5921: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtFwd,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-forefront-prvs: 031996B7EF x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(396003)(346002)(39850400004)(136003)(366004)(376002)(189003)(199004)(52536014)(186003)(33656002)(71200400001)(4326008)(5660300002)(66946007)(76116006)(7696005)(6916009)(8676002)(66476007)(86362001)(2906002)(55016002)(54906003)(81166006)(8936002)(316002)(53546011)(26005)(66556008)(66446008)(64756008)(81156014)(478600001)(6506007)(9686003); DIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR05MB5921; H:AM0PR05MB6610.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: tblyqKuSR+0rEpgjv9bxdiwU9897gB0F9iIoVPMSG/Ht1wFbA7kRXBMLJ/TRzrn2Kev+qrRtu4xxonhhSAH7YzydPN0nqjF4jqZnkVG9G/UCA78JNdr6ZGJriUeb55sTPXGMpFgzXQnvawdZ/TAjttNZGNYDE1C9JmMa/DMVkmg4LM/VlxJnDSQ3A0i2j9TIs4LOsiJakJc20vtqegtMkvkxocwjD3lyxOUSMerw1uizMsmVgkComMGx/ySleYVApXkf/ayCpGGv40eIxcyCq0JbxiTfGWPsqIm9+oIYj671wqWcncQ0ScmEY/PxT5yUZ9zXHguHAWUKbnNB+GgTJE0iX4WGFoeLm+/du0sOraj3TdQTqpi6RIqsFc12nuDeQy9eZ2SxJ6JuOeyaaQVUFfB155c4XCcebv8poNs5NI5vcM4ekbkvmkAafu0MpBQ4 x-ms-exchange-antispam-messagedata: AnrgnjUnT8OdkRwuSDqCz8TzP5CkZhH19bTJoAdT4qpz3KiYdQ1BwYRjKfUgZyQleZ20GDUJxze+avYIfOrsBDJFNM5L/CEwVOjHTfbAnCHJMI6NV4Rm0QiYaT9C8NPyJGv28Fz7i+8nMuRgkK80bQ== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: fbb43af4-1039-47a7-b821-08d7b60e0b04 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Feb 2020 14:06:12.6081 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: XphFclXh/v6VLhIHM6Q8xRxmcYSNOB+scAy9HgInvufG7hdomz99yZTjoHxuQSuCSdYKKAq/+rB8MT1h8qFQjA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR05MB5921 Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] lib/cmdline_rdline: increase command line buf size X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, Sure I'll handle the title with the right prefix. - consequence on memory usage? I don't think it will affect much, Since we are reading from the same buffer all the time, Read -> reset -> read again -> ...etc - How critical is this change? For now it's not that critical, but for testing perspective I think it's cr= itical, And it's a must to have so we can check un touched scenarios. Example: one rule can have outer items, inner items, actions =3D{ header rewrite, me= ta actions, duplicate actions, fate action, ..etc}=20 thus to test such combination we need to parse more in the cmdline - Which kind of command is so long? RTE_FLOW Example: flow create 2 ingress priority 0 group 4 transfer pattern eth / ipv4 tos sp= ec 0x0 ttl spec 0x0 proto spec 0x6 src spec 4.4.4.11 dst spec 4.4.4.10 tos = mask 0x0 ttl mask 0x0 proto mask 0x0 src mask 255.255.255.255 dst mask 255.= 255.255.255 / tcp src spec 5001 dst spec 38392 flags spec 0x0 src mask 6553= 5 dst mask 65535 flags mask 0x5 / tag index is 0 data spec 0x00000200 data = mask 0x0000ff00 / end actions count / set_tag index 0 data 0x00000200 mask = 0x0000ff00 / set_tag index 0 data 0x0000002a mask 0x000000ff / set_meta dat= a 0x00000001 mask 0x0000ffff / jump group 7 / end BRs, Wisam Jaddo -----Original Message----- From: Thomas Monjalon =20 Sent: Thursday, February 20, 2020 3:43 PM To: Wisam Monther Cc: dev@dpdk.org; Raslan Darawsheh ; stable@dpdk.org;= olivier.matz@6wind.com; bernard.iremonger@intel.com Subject: Re: [dpdk-stable] [PATCH] lib/cmdline_rdline: increase command lin= e buf size Hi, About the title, I suggest: cmdline: increase maximum line length 20/02/2020 14:18, Wisam Jaddo: > The current size of buffer is not enough to fit all allowed=20 > items/actions, thus it will block a lot of testing. >=20 > Cc: stable@dpdk.org +Cc maintainers of cmdline and testpmd > Signed-off-by: Wisam Jaddo [...] > -#define RDLINE_BUF_SIZE 512 > +#define RDLINE_BUF_SIZE 2048 I feel 2k is reasonable. What is the consequence on memory usage? How critical is this change? Which kind of command is so long?