From: Raslan Darawsheh <rasland@mellanox.com>
To: Michael Baum <michaelba@mellanox.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: Matan Azrad <matan@mellanox.com>,
Slava Ovsiienko <viacheslavo@mellanox.com>
Subject: Re: [dpdk-dev] [PATCH] net/mlx4: use anonymous DV allocator argument
Date: Sun, 28 Jun 2020 15:07:17 +0000 [thread overview]
Message-ID: <AM0PR05MB67071325D5F752FF1D7446F7C2910@AM0PR05MB6707.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <1593005395-5408-1-git-send-email-michaelba@mellanox.com>
Hi,
> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Michael Baum
> Sent: Wednesday, June 24, 2020 4:30 PM
> To: dev@dpdk.org
> Cc: Matan Azrad <matan@mellanox.com>; Slava Ovsiienko
> <viacheslavo@mellanox.com>
> Subject: [dpdk-dev] [PATCH] net/mlx4: use anonymous DV allocator
> argument
>
> The mlx4_pci_probe function defines an struct mlx4dv_ctx_allocators type
> variable several hundred rows after it starts, with the only use it
> being passed as a parameter to the mlx4_glue->dv_set_context_attr
> function.
> However, according to DPDK Coding Style Guidelines, variables should be
> declared at the start of a block of code rather than in the middle.
> Therefore, to improve the Coding Style, the variable is passed directly
> to the function without declaring it before.
>
> Signed-off-by: Michael Baum <michaelba@mellanox.com>
> Acked-by: Matan Azrad <matan@mellanox.com>
> ---
> drivers/net/mlx4/mlx4.c | 11 +++++------
> 1 file changed, 5 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/net/mlx4/mlx4.c b/drivers/net/mlx4/mlx4.c
> index 5d72027..ff270b4 100644
> --- a/drivers/net/mlx4/mlx4.c
> +++ b/drivers/net/mlx4/mlx4.c
> @@ -1054,14 +1054,13 @@ struct mlx4_conf {
> eth_dev->dev_ops = &mlx4_dev_ops;
> #ifdef HAVE_IBV_MLX4_BUF_ALLOCATORS
> /* Hint libmlx4 to use PMD allocator for data plane resources
> */
> - struct mlx4dv_ctx_allocators alctr = {
> - .alloc = &mlx4_alloc_verbs_buf,
> - .free = &mlx4_free_verbs_buf,
> - .data = priv,
> - };
> err = mlx4_glue->dv_set_context_attr
> (ctx, MLX4DV_SET_CTX_ATTR_BUF_ALLOCATORS,
> - (void *)((uintptr_t)&alctr));
> + (void *)((uintptr_t)&(struct mlx4dv_ctx_allocators){
> + .alloc = &mlx4_alloc_verbs_buf,
> + .free = &mlx4_free_verbs_buf,
> + .data = priv,
> + }));
> if (err)
> WARN("Verbs external allocator is not supported");
> else
> --
> 1.8.3.1
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
prev parent reply other threads:[~2020-06-28 15:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-24 13:29 Michael Baum
2020-06-28 15:07 ` Raslan Darawsheh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM0PR05MB67071325D5F752FF1D7446F7C2910@AM0PR05MB6707.eurprd05.prod.outlook.com \
--to=rasland@mellanox.com \
--cc=dev@dpdk.org \
--cc=matan@mellanox.com \
--cc=michaelba@mellanox.com \
--cc=viacheslavo@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).