From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 907B7A0350; Sun, 28 Jun 2020 17:07:22 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 175AC1C436; Sun, 28 Jun 2020 17:07:21 +0200 (CEST) Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80077.outbound.protection.outlook.com [40.107.8.77]) by dpdk.org (Postfix) with ESMTP id 545762AB for ; Sun, 28 Jun 2020 17:07:19 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OQJc/l1C5V7zu7g0Y054Lo41dZjvt2INPzkHf93YcMs+nN9MrNryvFJRPNbd4lketBgmGpoTJbFukFfBpdluKInhUS7/8gn/Wst7yCoC0/ECuVWzqrpNDp7CaG4VU5u6c091TxqOyfoCRl6imzbmzFe8pBIyzM94PYlGJJyf5y+0qc/7N17mB7Pq7NK9D87ElJHMBMLcJ1RV27uCtDfEm8cOWTmMUpVZedsQwaVaoPq31Zt3LJyw9kGoAgXVeTVAUmw3bBxAbANMjEeOUXyW05++xbFCapSoM3OXx6cYBxktQskuQHu7oUNQUmc1I8ZdTM/MbaJtT/KiHcJwjWFO0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wOSKUA2me0m0nNkKDP42GSVqRfIJ66PKPOoY37f2afM=; b=mnyTxoDZTGqlx0IAyMAtKj2t0DwTvRrkjFa+Q2N+B+IuY3t/vdNCwAuXuOpB2ayR9rC7m0biRfjpIu9cDH6/u/xbhxoal3dI9OtUWrryIAaUitqJ/FYlla0flFkk0Bi70OGPZ87W11kMO8VoXOEbylE8VzG1whQ4gQMW7HQdcmnVkROcHYrW1r0PYOrA4fhpZZDIam1OE1egqnr5MwJpmuH/fOY8CfGFbsbCsIsX72d5bO9HQzy9YsjuOUHDOsh/GtoaGpl2dfYGtY72ZUf4Yll2KFgj65a22+NdjR4HAnjdARmrRSzu4a30+96bXfBLqQsi43FaG4OJtK1sVUouqw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wOSKUA2me0m0nNkKDP42GSVqRfIJ66PKPOoY37f2afM=; b=BLCsEWYs4qsU2A0mlFz80OydgkXR/T/16K0qqhEEW/mk39DzhRbe8ZoFL+75+i0rCTi68GGXjYDZNIuCqHVSKF/MZ+W9B+SEyGVvc4N7JYcy2jwj4psYP0wTIfX26ix/AEkYahogpzY8Bk2iiM8C86sR153HG/UeVAI0gUPrC/U= Received: from AM0PR05MB6707.eurprd05.prod.outlook.com (2603:10a6:20b:15b::17) by AM4PR0501MB2657.eurprd05.prod.outlook.com (2603:10a6:200:65::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3131.25; Sun, 28 Jun 2020 15:07:17 +0000 Received: from AM0PR05MB6707.eurprd05.prod.outlook.com ([fe80::ecd3:6008:3784:4012]) by AM0PR05MB6707.eurprd05.prod.outlook.com ([fe80::ecd3:6008:3784:4012%4]) with mapi id 15.20.3131.026; Sun, 28 Jun 2020 15:07:17 +0000 From: Raslan Darawsheh To: Michael Baum , "dev@dpdk.org" CC: Matan Azrad , Slava Ovsiienko Thread-Topic: [dpdk-dev] [PATCH] net/mlx4: use anonymous DV allocator argument Thread-Index: AQHWSiuXb7xsqRqQWU6OtcosLm9PT6juJoRA Date: Sun, 28 Jun 2020 15:07:17 +0000 Message-ID: References: <1593005395-5408-1-git-send-email-michaelba@mellanox.com> In-Reply-To: <1593005395-5408-1-git-send-email-michaelba@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: mellanox.com; dkim=none (message not signed) header.d=none;mellanox.com; dmarc=none action=none header.from=mellanox.com; x-originating-ip: [84.242.49.134] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 85c83183-09d2-4080-f4bb-08d81b74f2d8 x-ms-traffictypediagnostic: AM4PR0501MB2657: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-forefront-prvs: 0448A97BF2 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: SKKKZt8xv9jIdULQDUhb7/gWRxLxq0p+gFGRSpGg0vJUDx23DwISwi0LniWaLHIfr/hyDXlgB7tRcnle8FSoQ6SRxZ6wfxXU3P9zljKgOPTQQKtQfdq1CGmut0CAmgldu0j0Nr886qXIp6GNawRMgG8ZJWB5oC9nPlpLXwQhU0LAP2bf04WDvtIMHNa6rskrKK9U54/0hQGzsS7AaAhN3KK7OyvANo8Lj5iyUHMZa17NZIx82yZuoJ+lg20YD3B/Fnw08kImJYuyVG2NxthISuAX9YSk/0abIzwukqalqIiR61K0LV401h//zGEuoA7+ x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM0PR05MB6707.eurprd05.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(366004)(136003)(376002)(396003)(346002)(39860400002)(55016002)(54906003)(9686003)(71200400001)(52536014)(8676002)(186003)(26005)(83380400001)(86362001)(66946007)(8936002)(64756008)(6506007)(107886003)(5660300002)(110136005)(2906002)(66476007)(66556008)(478600001)(7696005)(4326008)(66446008)(33656002)(76116006)(316002)(53546011); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: YeGSsh2mthi38sj++cMhveiEhS6ZDSlV/gwalAsuKZv02FB54fIJeX+V22eRN7Fw1pJKKxAuxuvOAErgI4ZWK/db/P5d97W5Uq26Q7Dbgz7ghKJ5ihLkhxk8xRdnawqRjMZ8niZba9gibIWm/bzoexL8nT4v/kWe5KC5uN6hWFe+yTEEZnL7mBrVWLahRqywBPVgSSDtpv4rzNA3RlLcRN+pnAJYEzvKiwf8rk/3aVYrRkINTGu960MbJSyZAPU9s5XlhHdB8fMoSoEyjDGFi6OxSgA7kz0PqEvGceRPTazp29EhiSHpQvRWeC2e1eozts/LiadwFvmDyopZ/N3XYKbJ7xqN8BGmWLrshC8VkxTpO+qKXnm3wqEhXFZNcsrIfmnWO+2H1TTGSTcsPjbCDROMdop8MMKMTJUaYY8a+slWM55GwaibW8MILwjanEwIWRgaAa4wQGP3ADGSUVoWr3VtzuwmOf9CyT1wwX2IN7adBz+99to1zNl0X2v4wazC Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AM0PR05MB6707.eurprd05.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 85c83183-09d2-4080-f4bb-08d81b74f2d8 X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Jun 2020 15:07:17.6739 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ZuAJVMr8JAg8AXZ4JTZSyGp0eq5SBurljeY/ooB4zckplpJ145YXKnqOa2kgAoXWbJCzFLBPgVUiG4iBuvvTVw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR0501MB2657 Subject: Re: [dpdk-dev] [PATCH] net/mlx4: use anonymous DV allocator argument X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, > -----Original Message----- > From: dev On Behalf Of Michael Baum > Sent: Wednesday, June 24, 2020 4:30 PM > To: dev@dpdk.org > Cc: Matan Azrad ; Slava Ovsiienko > > Subject: [dpdk-dev] [PATCH] net/mlx4: use anonymous DV allocator > argument >=20 > The mlx4_pci_probe function defines an struct mlx4dv_ctx_allocators type > variable several hundred rows after it starts, with the only use it > being passed as a parameter to the mlx4_glue->dv_set_context_attr > function. > However, according to DPDK Coding Style Guidelines, variables should be > declared at the start of a block of code rather than in the middle. > Therefore, to improve the Coding Style, the variable is passed directly > to the function without declaring it before. >=20 > Signed-off-by: Michael Baum > Acked-by: Matan Azrad > --- > drivers/net/mlx4/mlx4.c | 11 +++++------ > 1 file changed, 5 insertions(+), 6 deletions(-) >=20 > diff --git a/drivers/net/mlx4/mlx4.c b/drivers/net/mlx4/mlx4.c > index 5d72027..ff270b4 100644 > --- a/drivers/net/mlx4/mlx4.c > +++ b/drivers/net/mlx4/mlx4.c > @@ -1054,14 +1054,13 @@ struct mlx4_conf { > eth_dev->dev_ops =3D &mlx4_dev_ops; > #ifdef HAVE_IBV_MLX4_BUF_ALLOCATORS > /* Hint libmlx4 to use PMD allocator for data plane resources > */ > - struct mlx4dv_ctx_allocators alctr =3D { > - .alloc =3D &mlx4_alloc_verbs_buf, > - .free =3D &mlx4_free_verbs_buf, > - .data =3D priv, > - }; > err =3D mlx4_glue->dv_set_context_attr > (ctx, MLX4DV_SET_CTX_ATTR_BUF_ALLOCATORS, > - (void *)((uintptr_t)&alctr)); > + (void *)((uintptr_t)&(struct mlx4dv_ctx_allocators){ > + .alloc =3D &mlx4_alloc_verbs_buf, > + .free =3D &mlx4_free_verbs_buf, > + .data =3D priv, > + })); > if (err) > WARN("Verbs external allocator is not supported"); > else > -- > 1.8.3.1 Patch applied to next-net-mlx, Kindest regards, Raslan Darawsheh