From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 00ADCA04AF; Mon, 4 May 2020 09:21:06 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id ED4461D40B; Mon, 4 May 2020 09:21:05 +0200 (CEST) Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60065.outbound.protection.outlook.com [40.107.6.65]) by dpdk.org (Postfix) with ESMTP id 0BE5D1D40A; Mon, 4 May 2020 09:21:04 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RPLajHFAuHcpIvaLJE+0EwDq9blpNA3HO2r1AAydRbnoNjR4JmYcZ48nRlLnmIPK5FUrK6kfUR4LNCHthgbyPrP7iCiVkdB0EZoKZUKo9u/G1cdsUGE1nj+hniSK1IaPXBlAN6rHFzRJur2c3bzNZ7EsvsyWXnpjZWArf4LttoWCaXpMGA2b+2kui9KJkCPYxBsILronu7bfQa7AvxXEiEwWR+Ji8rX/sAxPEKzcw5HCcGxG0TOM1YbQ2ENYe/fYAy7eVCjSkhoRbNuuFrl1fTmZUXiciUWB4ikHtt1csjDZJdtVqJVtAaR5v8MTGoE3MtFC6MfZ+tCT2YZzJjQS2A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yoHbsEgnkxjLAwO+baN4+xLDIdbgGG6HxTHiG1K+jsQ=; b=RkueC8lR/t6+kc7Oqh370uFKKAZyIkEfKctDc9hnw9xAFJW0Hx0zyw2WuqpmCMHZOHwIrw01br6PvcaFTkzuZu+GpUqcYH858uS2I9rKCRbAPE+Hx2vwv+zfxxrxEb2tpxaqXJ8LxlwDLzk0b/HTQNfo1hp6anEg607tR0RTZyv1XVAmPjEr8L8hAjFs+eEumxvcvV5AoXKTjJ3hBTHgVC2m1aq4+gmSey3o4gKe5e9fxy9WTh+iXkutPWAhebVOaPBSgss+IWgzfh8QIkjmhVTyqsr/rbfBaI+ShOExHF085sn3hvA+eMwZnrNQI3xSCbIjzbQkxz1/JSyDF/EEXw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yoHbsEgnkxjLAwO+baN4+xLDIdbgGG6HxTHiG1K+jsQ=; b=CZSRTiFbulHNCAeLwekcDSjr+GSc913VUo6yA+PTiBc20SgYNuwawscHVl6v9NkaMzyXjbI/HcGMXiNwGKl558tFd4bGDY/Z9NiEeTzkCFqMpCaWQP15x9YImvxES39sowFFyCeGhlaH4fZ7/z9Fx12drFF1gG3u/9vG/jEeyWw= Received: from AM0PR05MB6707.eurprd05.prod.outlook.com (2603:10a6:20b:15b::17) by AM0PR05MB6818.eurprd05.prod.outlook.com (2603:10a6:20b:15f::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2958.19; Mon, 4 May 2020 07:20:53 +0000 Received: from AM0PR05MB6707.eurprd05.prod.outlook.com ([fe80::508:747b:cc12:5f6e]) by AM0PR05MB6707.eurprd05.prod.outlook.com ([fe80::508:747b:cc12:5f6e%5]) with mapi id 15.20.2958.030; Mon, 4 May 2020 07:20:53 +0000 From: Raslan Darawsheh To: Bing Zhao , Slava Ovsiienko CC: Ori Kam , Matan Azrad , "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [PATCH] net/mlx5: fix wrong assert in modify converting Thread-Index: AQHWHib998uVcu1GMUW8+GC44I8s06iXjLWg Date: Mon, 4 May 2020 07:20:53 +0000 Message-ID: References: <1588165574-237391-1-git-send-email-bingz@mellanox.com> In-Reply-To: <1588165574-237391-1-git-send-email-bingz@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: mellanox.com; dkim=none (message not signed) header.d=none;mellanox.com; dmarc=none action=none header.from=mellanox.com; x-originating-ip: [188.161.230.216] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 5571f0ec-147a-40c0-9a7d-08d7effbae1f x-ms-traffictypediagnostic: AM0PR05MB6818:|AM0PR05MB6818: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-forefront-prvs: 03932714EB x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: OlOvO5H7l5MDREqQDxQGR7FGJm5Y2EqbEESuf4a2kNUGlSmZaSeUo0jaHClplaWl2ySfLiz24Iof+OBtRNA5RHib3cvdTx8nG5nNaV/dTg4mf8HfBytU3JsOF6++QrRrbvqRz4UZozsZULkE50hpgrQfp0M1CSrWHvSMqXVZ6vkko78L4DBx4u0ZBEeboIJzay8oUR+8At4/ibq0K+gUnA040URAoSkzg3rTFSiXw02JKlUtDTa8/BBLx6kiRr402VOeMLly23KRlu51BNnY9JXX0dnlweQ5e9AWZ/ahKg3xS1CyGVLcaHM41iooAVUf1O8QdSZ/BcHrVeepTbkqrcGsZ7ihH4cU21XMk/iwpZLc9aDo5r5lZybSAXN5BTH8BfEcPZX10T+2P5VWpnacj0Q+ihcaM2ibGa5SbSHqFA2N9ibZidznCvz1tiW68ji+ x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM0PR05MB6707.eurprd05.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(396003)(39860400002)(366004)(346002)(376002)(136003)(5660300002)(54906003)(110136005)(55016002)(9686003)(7696005)(71200400001)(52536014)(53546011)(6506007)(66476007)(478600001)(66556008)(64756008)(66446008)(86362001)(33656002)(8676002)(2906002)(76116006)(26005)(316002)(4326008)(186003)(66946007)(6636002)(450100002)(8936002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: fKQphDaD88GVMh2IIbs1asM3PHQB1S2O8XQmTgxbiyw5BCW4z7Apa5FmcRGgoHkQGc71E4yTQ6zQ4YyvZujc/XaHpz6ZRIBV0HWocimU0zlMn0BK2lGXHiRFdB71wS0e/uwpX2RyUAsFTjYZKrRXrpoM4tsvkZwKafGj5MPHWvtCcAdF+NKoyTzkhXNTcf1CN8+RjGo7evhFdeE33CS9v7sEU1l88rSwdl9/Y5e1BPxHPLUPKU5i8u3BuXAvzr0ChpBvu4n2cCPzR/lDio1uMWyoiL278L2PWyOudygq8zwe36uD2p+d0LLFAqZQ2oS4JErEczkaMmi4irbyXeY9om2wGWxKZlVsb8pfe/aWB+kiAhcvzWdp/8aFGWm7LFeW13wQCOkZbYA1v9DFD0RhKzryFtfDWKV6dV2QjY8Gf0GO4JMm3nrtnlg53hDXyuPMIq3Kwa5c+2rSRXsetlcDNHXpDh3YMnvvTpnjkUDaw7zs/KzDr4kyw/+g3w24oF00YirukwlqM1u7TaSLvGlRyXtVEV5hpfuRqKJ9HAfw6x2hyrZRWEugknBBB2Y0O884H7cn9IX3m3/epCKbr9ETw7tThibU145He5qXteGKFrkU4w4dwvkQBq5Q/1ciq74D9Myvd0/PUkpCSHifG+8K1kb7v89ylVsjIH+LE3yX8l4vNGvMjI/y6hd9j+gUMQn7BiukAKvF/BtNpbqK8As4vWxICpekjfjNWEjZf2MVSz6iBKaG+2LOOX7Gf0eIa5QunKk79Yi1E2MkSDeeu3KNYmOiKnpC3ZVek05j656CLbc4eQPpFCZgBgT5ODs5Tu+n Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5571f0ec-147a-40c0-9a7d-08d7effbae1f X-MS-Exchange-CrossTenant-originalarrivaltime: 04 May 2020 07:20:53.2524 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: GD7XRwz2fXx0CSZN9AbE+zCByqBNCzBslv0LLNF65cKz7k5sbxYLnb6VZcdWNANLMN4UiL8/AWqcZgm3hbLijw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR05MB6818 Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix wrong assert in modify converting X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, > -----Original Message----- > From: Bing Zhao > Sent: Wednesday, April 29, 2020 4:06 PM > To: Slava Ovsiienko ; Raslan Darawsheh > > Cc: Ori Kam ; Matan Azrad ; > dev@dpdk.org; stable@dpdk.org > Subject: [PATCH] net/mlx5: fix wrong assert in modify converting >=20 > The assertion was added incorrectly in converting the modify actions > into the format of low layer driver. > There is no mask specified in the rte_flow actions, and PMD dirver > will give a mask of all 1s to the field to be modified. For each > field, the mask could not be zero. But for the whole header which > contains this field, the masks of other fields could be zero. The > assertion needs to be removed for debug mode. >=20 > Fixes: 72a944dba163 ("net/mlx5: fix header modify action validation") > Cc: stable@dpdk.org >=20 > Signed-off-by: Bing Zhao > Acked-by: Viacheslav Ovsiienko > --- > drivers/net/mlx5/mlx5_flow_dv.c | 1 - > 1 file changed, 1 deletion(-) >=20 > diff --git a/drivers/net/mlx5/mlx5_flow_dv.c > b/drivers/net/mlx5/mlx5_flow_dv.c > index 6263ecc..8cd9c83 100644 > --- a/drivers/net/mlx5/mlx5_flow_dv.c > +++ b/drivers/net/mlx5/mlx5_flow_dv.c > @@ -434,7 +434,6 @@ struct field_modify_info modify_tcp[] =3D { > /* Fetch variable byte size mask from the array. */ > mask =3D flow_dv_fetch_field((const uint8_t *)item->mask + > field->offset, field->size); > - MLX5_ASSERT(mask); > if (!mask) { > ++field; > continue; > -- > 1.8.3.1 Patch applied to next-net-mlx, Kindest regards, Raslan Darawsheh