From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1DA0BA0528; Sat, 18 Jul 2020 15:38:34 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C7C561BFCA; Sat, 18 Jul 2020 15:38:32 +0200 (CEST) Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80040.outbound.protection.outlook.com [40.107.8.40]) by dpdk.org (Postfix) with ESMTP id 5521C1BFC3 for ; Sat, 18 Jul 2020 15:38:31 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cLPNlApTTYCRWRxDubr7al3d1RdMZk6bYFImqJ+GMEvLz0QR9V4pNItROqe4sKa6njylScOxawRDRQTUKgN5gNbsNgaRac2iZRBeeHMZJ7zQZe6DAQXH33Hn2ype4wZmisuwPs0G0mZY9a8VN12lxBg+JjZUJEoQOQOVUbtdvEEXx85TElPuDLpURwwKFYBxqu1ibX2vf49976U0vKoHf4sxOHo+7nr2S0ew+yeNncMhTUFfqzWZFcfJnxhFmSpD2osfN/NMs9Z+h9Y1SnNXqk5xpp/kIGr8GgTXwBlgfNsE1NE+j227C80xymT9YJYIff01jiJFNY5ND6+Tsa7QBQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IN5PNXNr5kV8CclujkLbgG2GaZ4u+Zut/FLEcfQkpTE=; b=SH2r412uomVv9oIOVcBKMD7kCf2fjNt8tLKVO08328BfFQ1IZSxE8ViN9PVlgdrlXaOgpH83fO102/rouKhmsT7GhUIVdnOjDA/hOBw1gha4xyeI2phoqcEe1jvpyLICno9wBFVYIxrPHae3KQNmEhfo6Jiojl9qUygTAYFqMPLBwozVy3aFDXWZaP4SQB56XQuWbW+8m69Q1PaiQet21IwH9qA9pkMB/ewtOkgIbVDRZKKOTDesvu1ryk+ejihikWXkkQFbZrG2neaZoTrlmO3k3WGdiY4z+zqWTL6FB/9b9KTxhijweYiogGl3NPuVsMW7lsLFVav6z/F17OXmtQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IN5PNXNr5kV8CclujkLbgG2GaZ4u+Zut/FLEcfQkpTE=; b=gQwiX37/HLZh9IQr3Odj1NG5BabbKvxGkQHDcNiYc698KyfqMM62LPiRU6w+SlJ2+us8Ssm/MsZ6nRhRJNx3e1e4usF03Sgp4JpBu6ofX7HrIfmHo+nM8Dzvg/F7seDqVYV2dFaLfshKSXw0CnuPm45RpxJHBM7+Rz7wBZrbH/Y= Received: from AM0PR05MB6707.eurprd05.prod.outlook.com (2603:10a6:20b:15b::17) by AM4PR05MB3459.eurprd05.prod.outlook.com (2603:10a6:205:8::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3195.23; Sat, 18 Jul 2020 13:38:27 +0000 Received: from AM0PR05MB6707.eurprd05.prod.outlook.com ([fe80::ecd3:6008:3784:4012]) by AM0PR05MB6707.eurprd05.prod.outlook.com ([fe80::ecd3:6008:3784:4012%5]) with mapi id 15.20.3195.023; Sat, 18 Jul 2020 13:38:27 +0000 From: Raslan Darawsheh To: Slava Ovsiienko , "dev@dpdk.org" CC: Matan Azrad , Thomas Monjalon Thread-Topic: [PATCH 1/3] net/mlx5: fix compilation issue with missing DevX event Thread-Index: AQHWXEaMiKUGxPx8bUiV6NEKEQe9qqkNWBfA Date: Sat, 18 Jul 2020 13:38:26 +0000 Message-ID: References: <1591771085-24959-1-git-send-email-viacheslavo@mellanox.com> <1594996104-372-1-git-send-email-viacheslavo@mellanox.com> In-Reply-To: <1594996104-372-1-git-send-email-viacheslavo@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: mellanox.com; dkim=none (message not signed) header.d=none;mellanox.com; dmarc=none action=none header.from=mellanox.com; x-originating-ip: [188.161.228.169] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: dc545334-381c-401f-ddde-08d82b1fd9be x-ms-traffictypediagnostic: AM4PR05MB3459: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: TtPhFaTqlGEYibNJ3VbQcqfdCOP0BvvFMRuAfnKib8npWb2JbI1kbCetbKZdd6jlDJeLOHp5058KjFkTjNgki2vM45Y4APhrYOFMOu2PwGA/C+7n1LFBd6wySG2ftDRCQ/6W5iLVIt2gLhL95+yVe3hiBQF2tkCn2sPb2e5t5WleP2N8OSkNDMG4dRTEXrwFVdpMwG0OrYUaRRawplXcQNR1GqOBf53MzepqXdVVasWubiS1pLqY9VidLTywO3G/MTz5mkgM4nb539yauQjhHXjfpDWAEflEtsV+pnzzEGrkrVoOUxTUenj24lfybAq6 x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM0PR05MB6707.eurprd05.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(366004)(39850400004)(376002)(396003)(136003)(346002)(6506007)(53546011)(83380400001)(26005)(7696005)(71200400001)(110136005)(54906003)(478600001)(86362001)(9686003)(8676002)(55016002)(316002)(66946007)(8936002)(66476007)(76116006)(64756008)(33656002)(66446008)(66556008)(186003)(52536014)(4326008)(2906002)(5660300002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: DFxKEBBkY2KH+WbZe4eopkrI043/Q2KdUHxE4ysQxtKEltPrrR1mo8zH9Re5hOTjwnuRolGLRgkTk9S8ql0jaCb5hKyyEZeHKLmgy0Jn13ejspfwIBSpcuvFy8K0x4rUhkO2DJzJUXLrZMWoS5/ezyZkB8n1qh+8lvVZVdj0EfVbKq6+99xcVNHy2h8t0JOhwdc89cXlFOwDY0jxyMiOULLCs9MtoQf4dAi1besB+VQ8mB5q/c5fzUp5bbFeJjCnQB1xn6EdF6JFKlm6swJU6J3b9guB9JkXMmXkJC1qlpu8q2uCeXS3hsTcFqS1CafGWtihzvuzhyC7/GE6AHuq6r+v9YsC/aolank0x+A4aXyqQtk3UxZkWxa2VDrV+hkP+uUT+vgSautuCBQotkwrwAbYpUYxKUl79D2FsPhGOcSMF511JR5Vsn7V8/x8IkPflcuXBUXr8kho8cNCKXleCVPi8rYO73Ofdkf793qn1pd7LLHHym5HXg+cbHbeWpyQ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AM0PR05MB6707.eurprd05.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: dc545334-381c-401f-ddde-08d82b1fd9be X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Jul 2020 13:38:26.8467 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: wsFu+2X6nTcfvB5njMBWRd4PJrauHIUGsgzhDCQ9wpGOc2tL9WvRqCMmTezPNvl6BYd3yG1eUWSxImGtgvlIgg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR05MB3459 Subject: Re: [dpdk-dev] [PATCH 1/3] net/mlx5: fix compilation issue with missing DevX event X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, > -----Original Message----- > From: Viacheslav Ovsiienko > Sent: Friday, July 17, 2020 5:28 PM > To: dev@dpdk.org > Cc: Matan Azrad ; Raslan Darawsheh > ; Thomas Monjalon > Subject: [PATCH 1/3] net/mlx5: fix compilation issue with missing DevX ev= ent >=20 > If there is no support for DevX event the mlx5_txpp_gather_timestamp() > is reported as "not used" causing the compilation warning/error. > This patch moves the routine to the conditional block. >=20 > Fixes: 244788055199 ("net/mlx5: introduce clock queue service routine") >=20 > Signed-off-by: Viacheslav Ovsiienko > --- > drivers/net/mlx5/mlx5_txpp.c | 30 +++++++++++++++--------------- > 1 file changed, 15 insertions(+), 15 deletions(-) >=20 > diff --git a/drivers/net/mlx5/mlx5_txpp.c b/drivers/net/mlx5/mlx5_txpp.c > index 15c9a8e..42776b8 100644 > --- a/drivers/net/mlx5/mlx5_txpp.c > +++ b/drivers/net/mlx5/mlx5_txpp.c > @@ -719,21 +719,6 @@ > mlx5_txpp_cache_timestamp(sh, ts, wq->cq_ci); > } >=20 > -/* Gather statistics for timestamp from Clock Queue CQE. */ > -static inline void > -mlx5_txpp_gather_timestamp(struct mlx5_dev_ctx_shared *sh) > -{ > - /* Check whether we have a valid timestamp. */ > - if (!sh->txpp.clock_queue.sq_ci && !sh->txpp.ts_n) > - return; > - MLX5_ASSERT(sh->txpp.ts_p < MLX5_TXPP_REARM_SQ_SIZE); > - sh->txpp.tsa[sh->txpp.ts_p] =3D sh->txpp.ts; > - if (++sh->txpp.ts_p >=3D MLX5_TXPP_REARM_SQ_SIZE) > - sh->txpp.ts_p =3D 0; > - if (sh->txpp.ts_n < MLX5_TXPP_REARM_SQ_SIZE) > - ++sh->txpp.ts_n; > -} > - > /* Waits for the first completion on Clock Queue to init timestamp. */ > static inline void > mlx5_txpp_init_timestamp(struct mlx5_dev_ctx_shared *sh) > @@ -759,6 +744,21 @@ > } >=20 > #ifdef HAVE_IBV_DEVX_EVENT > +/* Gather statistics for timestamp from Clock Queue CQE. */ > +static inline void > +mlx5_txpp_gather_timestamp(struct mlx5_dev_ctx_shared *sh) > +{ > + /* Check whether we have a valid timestamp. */ > + if (!sh->txpp.clock_queue.sq_ci && !sh->txpp.ts_n) > + return; > + MLX5_ASSERT(sh->txpp.ts_p < MLX5_TXPP_REARM_SQ_SIZE); > + sh->txpp.tsa[sh->txpp.ts_p] =3D sh->txpp.ts; > + if (++sh->txpp.ts_p >=3D MLX5_TXPP_REARM_SQ_SIZE) > + sh->txpp.ts_p =3D 0; > + if (sh->txpp.ts_n < MLX5_TXPP_REARM_SQ_SIZE) > + ++sh->txpp.ts_n; > +} > + > /* Handles Rearm Queue completions in periodic service. */ > static __rte_always_inline void > mlx5_txpp_handle_rearm_queue(struct mlx5_dev_ctx_shared *sh) > -- > 1.8.3.1 Series applied and squashed into relevant commits in master-net-mlx, Kindest regards, Raslan Darawsheh