From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E21DAA0598; Tue, 21 Apr 2020 19:56:11 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id BF7311D51C; Tue, 21 Apr 2020 19:56:11 +0200 (CEST) Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80073.outbound.protection.outlook.com [40.107.8.73]) by dpdk.org (Postfix) with ESMTP id E0A5D1D440; Tue, 21 Apr 2020 19:56:09 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CkhFGwxKGkZdgoziJtH6elJ4Asds4qBBTdtqefQ4yRXr6CbBMJrFj5cfBREEH/Rnm1qtp0ahE3kA7yNDgrIUcKxSMvObHSwJkK0ggbDdtAdvN8NdBgBX/FKLJWf2LT0pI5+JC1enn4nAggof3AoDKRbBubgq+ho0dlFjIXofs51mXU2CWidU4Xto5u5rnPAZQTviJGmFR9ooUrQ8Lj422UH/lbK9Gqy78pkEGDIuXZ7PW7r91gh0EGV+rP+ppX7tiCXE3XRbDbsgOlAdDp2qM9noE0pYhKtHo/G4Y2swBWB4uu4Mz3zOwm+mq1KKnWrOYPW5Z6/WZ0nsNCL2Rv8G6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iX3kI3eQBOz24hzKJc9YuS7IilrucGa4b0/Tfx2K1OU=; b=gBZfAhL7+AAGSSMuC11uBE3EzFJ/lVhW41tsHCJtr3KF34pJD7ywYxINDLgHRGrpcPseTe3WHjvk4WSWIMgHCLBGbrdz9JjuFdeh2iKZexjQaCslOiDVOG/KJKH1q9Hy51AWwpLy/InBmywGpjCpxJNBco+H5UEMJCInsJPXD5MVjm4IFKDEnJgPZC38IXEZsK260h+NWzVWqtoDEoCWQ6jX6QyRewPcQT+aZ8r3OnV4s4Jd/yeOIkwMjwKjdG50Hn+NA/N0qNv9autouzq4X3L7AGxOFGlDWTafskPj4lh80PbmfB1oBPI7e1qnK8kBHQDMjeAJ3uGeAke9D9K7Jg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iX3kI3eQBOz24hzKJc9YuS7IilrucGa4b0/Tfx2K1OU=; b=IFJRmzyLAc5xVfyGZxJPDuAyXEuuz9HLqirZja7N6TNyMbQ3RDPNVMexh9wetKjZPtQC7Cd7wGnXl2sk9FM6G71N4OYSh48zGDg0n/kXLFceNe5NCvElLnJNjQbVuDZRtFXoRujJneAA/cV/pJGiFyS4qLHqktljcNYZMsWppwQ= Received: from AM0PR05MB6707.eurprd05.prod.outlook.com (2603:10a6:20b:15b::17) by AM0PR05MB6435.eurprd05.prod.outlook.com (2603:10a6:208:146::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2921.25; Tue, 21 Apr 2020 17:56:09 +0000 Received: from AM0PR05MB6707.eurprd05.prod.outlook.com ([fe80::508:747b:cc12:5f6e]) by AM0PR05MB6707.eurprd05.prod.outlook.com ([fe80::508:747b:cc12:5f6e%6]) with mapi id 15.20.2921.030; Tue, 21 Apr 2020 17:56:09 +0000 From: Raslan Darawsheh To: Alexander Kozyrev , "dev@dpdk.org" CC: Slava Ovsiienko , "stable@dpdk.org" Thread-Topic: [PATCH] net/mlx5: improve logging of MPRQ selection Thread-Index: AQHWFNyYi1BoVz1oq0y98BdnqB2noqiD4ntw Date: Tue, 21 Apr 2020 17:56:09 +0000 Message-ID: References: <1587144039-24144-1-git-send-email-akozyrev@mellanox.com> In-Reply-To: <1587144039-24144-1-git-send-email-akozyrev@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=rasland@mellanox.com; x-originating-ip: [188.161.228.234] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 83581e42-310b-4331-0251-08d7e61d459c x-ms-traffictypediagnostic: AM0PR05MB6435:|AM0PR05MB6435: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7219; x-forefront-prvs: 038002787A x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM0PR05MB6707.eurprd05.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(10009020)(4636009)(366004)(76116006)(64756008)(66476007)(66946007)(66556008)(53546011)(6506007)(9686003)(52536014)(33656002)(55016002)(86362001)(186003)(4326008)(8676002)(5660300002)(54906003)(8936002)(110136005)(7696005)(81156014)(66446008)(71200400001)(26005)(2906002)(498600001)(450100002); DIR:OUT; SFP:1101; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 1NDnH8sMqWmC7kugIa002b7K2pBJRwjTZz8gI3OGDsIMOZ3kMO210cCcWs5Y8O60xxNpbypOpqxCGgjqPflJnddtwsFDOo+Kbm9WPh7EORzczsMd+g1FAmpirfIFnj4Vl3wQSqUGddVl7Rxnc9yGVA3P15RUXGyTvjgp5OQxj/Fm9u8dTYFBHyWhLm7IGqRSiFCU5BbYonmQqesFFaaA0LjwgyADbyq5MukCYevLUhxiRYqSc7Fwp9bG+YneAICK24cYQJrsqO8jixb6rG5jqJgtzxlvrz9GVo1EGbukua3m+aPt3JE487X/RAeyDzDgBxLCIPCZyiQ8qB/Wlx+BreagNrlaZbfyd4gmzTBge6o1bztj6/WAQzB0U4wdpMMRL44OiciB6eG3OGxAsZ90j4pBorc/uEp8T7P838YH7XD2HOyl/SG4yZYubwyufxSH x-ms-exchange-antispam-messagedata: tbb3TPQ4AkYmYL42sw8QhrGAPfJL3QPrFTlr81yIlnXAvO10UOfZZ0xdHfSSl7oD2iJvgFPKfXiY8HJjyBZybgdDLbf1Ca/IkSprux0A2XnnmuJrVbpMe4WzPWMqPIvIVJvuEdM9aXPmkshKFRkJTg== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 83581e42-310b-4331-0251-08d7e61d459c X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Apr 2020 17:56:09.1421 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: qe7Vpt7yFFHHbVEvlw/lM3JlBc7ALd9dVQ8C0uOgbrheBoSjKX+vXBWoThBPyYUo9bN2vTiRm9KpSqvQZjvuvA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR05MB6435 Subject: Re: [dpdk-dev] [PATCH] net/mlx5: improve logging of MPRQ selection X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, > -----Original Message----- > From: Alexander Kozyrev > Sent: Friday, April 17, 2020 8:21 PM > To: dev@dpdk.org > Cc: Raslan Darawsheh ; Slava Ovsiienko > ; stable@dpdk.org > Subject: [PATCH] net/mlx5: improve logging of MPRQ selection >=20 > MPRQ is silently turned off in case there is not enough > Rx queues configured. Improve the logging to show a > warning in this case to notify a user about the Rx burst > function selected. >=20 > Fixes: 7d6bf6b866b8 ("net/mlx5: add Multi-Packet Rx support") > Cc: stable@dpdk.org >=20 > Signed-off-by: Alexander Kozyrev > Acked-by: Viacheslav Ovsiienko > --- > drivers/net/mlx5/mlx5_rxq.c | 15 +++++++++------ > 1 file changed, 9 insertions(+), 6 deletions(-) >=20 > diff --git a/drivers/net/mlx5/mlx5_rxq.c b/drivers/net/mlx5/mlx5_rxq.c > index 9bc7af6..7a50ec6 100644 > --- a/drivers/net/mlx5/mlx5_rxq.c > +++ b/drivers/net/mlx5/mlx5_rxq.c > @@ -1921,19 +1921,22 @@ struct mlx5_rxq_ctrl * > tmpl->rxq.sges_n =3D sges_n; > max_lro_size =3D max_rx_pkt_len; > } > - if (mprq_en && !mlx5_rxq_mprq_enabled(&tmpl->rxq)) > + if (config->mprq.enabled && !mlx5_rxq_mprq_enabled(&tmpl- > >rxq)) > DRV_LOG(WARNING, > - "port %u MPRQ is requested but cannot be enabled" > - " (requested: packet size =3D %u, desc =3D %u," > - " stride_sz =3D %u, stride_num =3D %u," > - " supported: min_stride_sz =3D %u, max_stride_sz =3D > %u).", > - dev->data->port_id, non_scatter_min_mbuf_size, > desc, > + "port %u MPRQ is requested but cannot be > enabled\n" > + " (requested: pkt_sz =3D %u, desc_num =3D %u," > + " rxq_num =3D %u, stride_sz =3D %u, stride_num =3D %u\n" > + " supported: min_rxqs_num =3D %u," > + " min_stride_sz =3D %u, max_stride_sz =3D %u).", > + dev->data->port_id, non_scatter_min_mbuf_size, > + desc, priv->rxqs_n, > config->mprq.stride_size_n ? > (1U << config->mprq.stride_size_n) : > (1U << mprq_stride_size), > config->mprq.stride_num_n ? > (1U << config->mprq.stride_num_n) : > (1U << mprq_stride_nums), > + config->mprq.min_rxqs_num, > (1U << config->mprq.min_stride_size_n), > (1U << config->mprq.max_stride_size_n)); > DRV_LOG(DEBUG, "port %u maximum number of segments per > packet: %u", > -- > 1.8.3.1 Patch applied to next-net-mlx, Kindest regards, Raslan Darawsheh