From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B692CA04FA; Wed, 8 Jan 2020 09:51:28 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E3C561D6CB; Wed, 8 Jan 2020 09:51:27 +0100 (CET) Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-eopbgr130084.outbound.protection.outlook.com [40.107.13.84]) by dpdk.org (Postfix) with ESMTP id 93DCD1D6C3; Wed, 8 Jan 2020 09:51:26 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jMVwgox63aY1qxp14xdpHFqFvZ9ryl9/FziNkZtRQDTjjmn7tL3GFCFEnubJg7LHcfZA31jktFU074w2SvqmyoJtms5k6xb+OSrgd7/JVM2Lh1JICS5EHX6on0Vrg6ANeoNw4gOmKdc+tSH6vLPotx4vKdFn1OnhcDDugYlY9D0dLHNP3flp7VW4+foyI30rQEplXMvJULzBgS/5obHhpw2VBy+j1sUZuAiBp7qYQo6v96TtxfzKeDl/8jtgpKc8F91eATK06ZefT+btSJrGjcBOYPOkc9sRZ+9aXFTXHU8Cbh/haeYuPNQ4i0JRNpsSI/LVNf82Z6t+A1SNBWqqcw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8LkXQ9wcNu6hDZn06OseCz3U602C4T6FyFxQm1AbnjA=; b=hziO2kmYHYYIOopPWYXmdQ47kl/hEJGsfon1oO8SAChqEsli9anovFrycjHWqZUCmnu8tPYe4hGoMlSKWMlav97d5Kysh28mHMncGV9QznDiphkQxT1P554ce5a4z22mC4fLqmdvRvHYDLi2NLmkjmai3e9H8NbMGMd7f66ZY5gCRE5KJd1c0CcnVjNdqh4+EYFl0EbF650txZZAcacqDb/FYM341MwVm/gtvx+Bww6/yDurg8EGhwF6f5e2YNkueIw0adGyR5QdVLZ0ZT6AVqetvkc9tRdh9VDsSPfvKK9fKMt5ncMYFrNrx0K5FxnQtsUic6OtCaayNU2ow7J7+g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8LkXQ9wcNu6hDZn06OseCz3U602C4T6FyFxQm1AbnjA=; b=d7YgB5I5Yol9l0inn2PrHR+i9YVzGrUWsvEEamjkSSPxOfx18hnRP4Kll73rOu29Dg6g2lp/IQOkTa7FztRFJEYZhHq5MIj4D+ppqcw/Mx+K5Nx7oeTM6rrrGvEhufaU7qP88Qy2dO7OFYKY1RLOlqUFQvrxA1C9kDA8hfv3LKY= Received: from AM0PR05MB6707.eurprd05.prod.outlook.com (10.186.174.145) by AM0PR05MB5858.eurprd05.prod.outlook.com (20.178.118.140) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2602.15; Wed, 8 Jan 2020 08:51:24 +0000 Received: from AM0PR05MB6707.eurprd05.prod.outlook.com ([fe80::95ff:bfb2:7f11:87b2]) by AM0PR05MB6707.eurprd05.prod.outlook.com ([fe80::95ff:bfb2:7f11:87b2%5]) with mapi id 15.20.2602.017; Wed, 8 Jan 2020 08:51:24 +0000 From: Raslan Darawsheh To: Slava Ovsiienko , "dev@dpdk.org" CC: Matan Azrad , Ori Kam , "stable@dpdk.org" Thread-Topic: [PATCH] net/mlx5: fix ConnectX-4LX Tx burst routines set Thread-Index: AQHVtyMPVZmDDNOktUWzDKYetu1yv6fgk0Ow Date: Wed, 8 Jan 2020 08:51:24 +0000 Message-ID: References: <1576838905-26817-1-git-send-email-viacheslavo@mellanox.com> In-Reply-To: <1576838905-26817-1-git-send-email-viacheslavo@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=rasland@mellanox.com; x-originating-ip: [212.29.221.74] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: e13ef63d-d49d-4dd8-8594-08d79417f122 x-ms-traffictypediagnostic: AM0PR05MB5858:|AM0PR05MB5858: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5516; x-forefront-prvs: 02760F0D1C x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(346002)(376002)(39860400002)(396003)(366004)(136003)(13464003)(189003)(199004)(66476007)(66556008)(64756008)(66446008)(316002)(8936002)(2906002)(33656002)(81156014)(86362001)(8676002)(5660300002)(52536014)(110136005)(71200400001)(76116006)(66946007)(81166006)(54906003)(478600001)(55016002)(26005)(9686003)(186003)(450100002)(4326008)(7696005)(6506007)(53546011); DIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR05MB5858; H:AM0PR05MB6707.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: bAmPThoTSIieLxlgQ1cOdp/EzYu6cNsp24eClCnS9w7i0/sfj5BG7/SQmWB5JkPvyZB1xHr8HGi8JZ1q/fh8inQfWZ8SnWLwhda6aGS+PHIJxGhQTBJRl9TrfqulSgSsHLTfOjRXN7o2r0ya6jR/tsBvShBQkBrjDf4Kj5Fsz9U2zEjwskNBubu8ILLFXewVtKtVon8i2Aco1oL0BvA/JAX0CDK8CDwrfUatsjFnZ7NnSdYUyk01WYH66ulN6UZzJRoLFCf34Gq/VJfhHgxBHs+x26R/EnNwD0YEPcvR92WbZFcsgVZsOe7qToxtLc0/Lj7fNY5XO4qeJzIOgWuLbh6LybVcJZQ8Pa848E93KEw1SlxFkBR5yR6GmvNBMIQIzm9jff7kaQfN0+kZf3Z2vs7H+d1PepeWhSm6tGkYuOAbbh+mJ0N7Nmlu4TlhmPxhwIool81/HXq5WGA1KFePEQtG0klW2M417h2vtLjutpC/A0a1lmCKpMCE9Hmpiq6E Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: e13ef63d-d49d-4dd8-8594-08d79417f122 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Jan 2020 08:51:24.6556 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: UK7BghXkoIQijx1E/g+DfTa/r4F6Kt97ajx5fz3E1DUrq1bYB7pvza8ixlsFcZPB/Nk9acUVP+WijuMmXjeA3A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR05MB5858 Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix ConnectX-4LX Tx burst routines set X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, > -----Original Message----- > From: Viacheslav Ovsiienko > Sent: Friday, December 20, 2019 12:48 PM > To: dev@dpdk.org > Cc: Matan Azrad ; Raslan Darawsheh > ; Ori Kam ; > stable@dpdk.org > Subject: [PATCH] net/mlx5: fix ConnectX-4LX Tx burst routines set >=20 > The tx_burst routine supporting multi-segment packets with > legacy MPW and without inline was missed, and there was no > valid selection for these options, patch adds the missing > routine. >=20 > Fixes: 82e75f8323bf ("net/mlx5: fix legacy multi-packet Tx descriptors") > Cc: stable@dpdk.org >=20 > Signed-off-by: Viacheslav Ovsiienko > --- > drivers/net/mlx5/mlx5_rxtx.c | 9 +++++++++ > 1 file changed, 9 insertions(+) >=20 > diff --git a/drivers/net/mlx5/mlx5_rxtx.c b/drivers/net/mlx5/mlx5_rxtx.c > index a7f3bff..57804f5 100644 > --- a/drivers/net/mlx5/mlx5_rxtx.c > +++ b/drivers/net/mlx5/mlx5_rxtx.c > @@ -4984,6 +4984,10 @@ enum mlx5_txcmp_code { > MLX5_TXOFF_CONFIG_INLINE | > MLX5_TXOFF_CONFIG_EMPW | > MLX5_TXOFF_CONFIG_MPW) >=20 > +MLX5_TXOFF_DECL(mc_mpw, > + MLX5_TXOFF_CONFIG_MULTI | > MLX5_TXOFF_CONFIG_CSUM | > + MLX5_TXOFF_CONFIG_EMPW | > MLX5_TXOFF_CONFIG_MPW) > + > MLX5_TXOFF_DECL(i_mpw, > MLX5_TXOFF_CONFIG_INLINE | > MLX5_TXOFF_CONFIG_EMPW | > MLX5_TXOFF_CONFIG_MPW) > @@ -5140,6 +5144,10 @@ enum mlx5_txcmp_code { > MLX5_TXOFF_CONFIG_INLINE | > MLX5_TXOFF_CONFIG_EMPW | > MLX5_TXOFF_CONFIG_MPW) >=20 > +MLX5_TXOFF_INFO(mc_mpw, > + MLX5_TXOFF_CONFIG_MULTI | > MLX5_TXOFF_CONFIG_CSUM | > + MLX5_TXOFF_CONFIG_EMPW | > MLX5_TXOFF_CONFIG_MPW) > + > MLX5_TXOFF_INFO(i_mpw, > MLX5_TXOFF_CONFIG_INLINE | > MLX5_TXOFF_CONFIG_EMPW | > MLX5_TXOFF_CONFIG_MPW) > @@ -5297,6 +5305,7 @@ enum mlx5_txcmp_code { > DRV_LOG(DEBUG, "port %u has no selected Tx function" > " for requested offloads %04X", > dev->data->port_id, olx); > + assert(false); > return NULL; > } > DRV_LOG(DEBUG, "port %u has selected Tx function" > -- > 1.8.3.1 Patch applied to next-net-mlx, Kindest regards, Raslan Darawsheh