From: Raslan Darawsheh <rasland@mellanox.com>
To: Slava Ovsiienko <viacheslavo@mellanox.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: Matan Azrad <matan@mellanox.com>, Ori Kam <orika@mellanox.com>
Subject: Re: [dpdk-dev] [PATCH v3 0/4] net/mlx5: remove Tx descriptor reserved field usage
Date: Mon, 13 Jan 2020 09:36:23 +0000 [thread overview]
Message-ID: <AM0PR05MB6707431C067F5190D11D9B27C2350@AM0PR05MB6707.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <1578590167-10167-1-git-send-email-viacheslavo@mellanox.com>
Hi,
> -----Original Message-----
> From: Viacheslav Ovsiienko <viacheslavo@mellanox.com>
> Sent: Thursday, January 9, 2020 7:16 PM
> To: dev@dpdk.org
> Cc: Matan Azrad <matan@mellanox.com>; Raslan Darawsheh
> <rasland@mellanox.com>; Ori Kam <orika@mellanox.com>
> Subject: [PATCH v3 0/4] net/mlx5: remove Tx descriptor reserved field usage
>
> The current Tx datapath implementation in mlx5 PMD uses the 16-bit
> reserved field within transmit descriptor to store the indices of the elts array
> keeping the mbuf pointers to be freed on transmit completion. On
> completion PMD fetches the descriptor index, then fetches the elts array
> index from reserved field and frees the mbufs.
>
> The new ConnectX-6DX NIC might use this reserved descriptor field and
> existing implementation might not work in intended way.
> To resolve this issue the dedicated buffer is introduced to store indices to
> instead of descriptor field.
>
> Signed-off-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com>
>
> Viacheslav Ovsiienko (4):
> net/mlx5: move Tx complete request routine
> net/mlx5: update Tx error handling routine
> net/mlx5: add free on completion queue
> net/mlx5: engage free on completion queue
>
> drivers/net/mlx5/mlx5_rxtx.c | 153 ++++++++++++++++++++-----------------
> ------
> drivers/net/mlx5/mlx5_rxtx.h | 13 ++-- drivers/net/mlx5/mlx5_txq.c | 19
> +++++-
> 3 files changed, 94 insertions(+), 91 deletions(-)
>
> --
> v1: -
> https://eur03.safelinks.protection.outlook.com/?url=http%3A%2F%2Fpatch
> es.dpdk.org%2Fcover%2F64293%2F&data=02%7C01%7Crasland%40mell
> anox.com%7C2581e58267ee4d46f6db08d79527c2da%7Ca652971c7d2e4d9ba6
> a4d149256f461b%7C0%7C0%7C637141870319356462&sdata=rSy16E3H9
> OqxKekFtNTPSii3%2FPrKK1xjvEVddF14oMw%3D&reserved=0
> v2: -
> https://eur03.safelinks.protection.outlook.com/?url=http%3A%2F%2Fpatch
> es.dpdk.org%2Fcover%2F64331%2F&data=02%7C01%7Crasland%40mell
> anox.com%7C2581e58267ee4d46f6db08d79527c2da%7Ca652971c7d2e4d9ba6
> a4d149256f461b%7C0%7C0%7C637141870319356462&sdata=N3XndSHXY
> Ae73Ubu%2BNNlr6CBDt6ciq7HKxNnuerHpzo%3D&reserved=0
> - resolve minor compilation per patch issues
> v3: - change the fcq entry type to uint16_t in non-debug mode
>
> 1.8.3.1
Series applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
prev parent reply other threads:[~2020-01-13 9:36 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-08 16:15 [dpdk-dev] [PATCH " Viacheslav Ovsiienko
2020-01-08 16:15 ` [dpdk-dev] [PATCH 1/4] net/mlx5: move Tx complete request routine Viacheslav Ovsiienko
2020-01-08 16:15 ` [dpdk-dev] [PATCH 2/4] net/mlx5: update Tx error handling routine Viacheslav Ovsiienko
2020-01-08 16:16 ` [dpdk-dev] [PATCH 3/4] net/mlx5: add free on completion queue Viacheslav Ovsiienko
2020-01-08 16:16 ` [dpdk-dev] [PATCH 4/4] net/mlx5: engage " Viacheslav Ovsiienko
2020-01-09 10:56 ` [dpdk-dev] [PATCH v2 0/4] net/mlx5: remove Tx descriptor reserved field usage Viacheslav Ovsiienko
2020-01-09 10:56 ` [dpdk-dev] [PATCH v2 1/4] net/mlx5: move Tx complete request routine Viacheslav Ovsiienko
2020-01-09 10:56 ` [dpdk-dev] [PATCH v2 2/4] net/mlx5: update Tx error handling routine Viacheslav Ovsiienko
2020-01-09 10:56 ` [dpdk-dev] [PATCH v2 3/4] net/mlx5: add free on completion queue Viacheslav Ovsiienko
2020-01-09 15:12 ` Ferruh Yigit
2020-01-09 15:22 ` Slava Ovsiienko
2020-01-09 10:56 ` [dpdk-dev] [PATCH v2 4/4] net/mlx5: engage " Viacheslav Ovsiienko
2020-01-09 15:18 ` Ferruh Yigit
2020-01-09 15:27 ` Slava Ovsiienko
2020-01-09 15:43 ` Ferruh Yigit
2020-01-09 16:22 ` Slava Ovsiienko
2020-01-10 9:06 ` Thomas Monjalon
2020-01-10 9:28 ` Slava Ovsiienko
2020-01-10 9:34 ` Thomas Monjalon
2020-01-10 9:55 ` Slava Ovsiienko
2020-01-10 13:11 ` Thomas Monjalon
2020-01-10 13:42 ` Slava Ovsiienko
2020-01-17 10:44 ` Slava Ovsiienko
2020-01-09 14:22 ` [dpdk-dev] [PATCH v2 0/4] net/mlx5: remove Tx descriptor reserved field usage Raslan Darawsheh
2020-01-13 9:35 ` Raslan Darawsheh
2020-01-09 17:16 ` [dpdk-dev] [PATCH v3 " Viacheslav Ovsiienko
2020-01-09 17:16 ` [dpdk-dev] [PATCH v3 1/4] net/mlx5: move Tx complete request routine Viacheslav Ovsiienko
2020-01-09 17:16 ` [dpdk-dev] [PATCH v3 2/4] net/mlx5: update Tx error handling routine Viacheslav Ovsiienko
2020-01-09 17:16 ` [dpdk-dev] [PATCH v3 3/4] net/mlx5: add free on completion queue Viacheslav Ovsiienko
2020-01-09 17:16 ` [dpdk-dev] [PATCH v3 4/4] net/mlx5: engage " Viacheslav Ovsiienko
2020-01-13 9:36 ` Raslan Darawsheh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM0PR05MB6707431C067F5190D11D9B27C2350@AM0PR05MB6707.eurprd05.prod.outlook.com \
--to=rasland@mellanox.com \
--cc=dev@dpdk.org \
--cc=matan@mellanox.com \
--cc=orika@mellanox.com \
--cc=viacheslavo@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).