From: Raslan Darawsheh <rasland@mellanox.com>
To: Shiri Kuzin <shirik@mellanox.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: Matan Azrad <matan@mellanox.com>,
Slava Ovsiienko <viacheslavo@mellanox.com>
Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix LACP action type casting
Date: Tue, 30 Jun 2020 08:06:32 +0000 [thread overview]
Message-ID: <AM0PR05MB67075AF61CDF63F888AED05EC26F0@AM0PR05MB6707.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <1593446472-4335-1-git-send-email-shirik@mellanox.com>
Hi,
> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Shiri Kuzin
> Sent: Monday, June 29, 2020 7:01 PM
> To: dev@dpdk.org
> Cc: Matan Azrad <matan@mellanox.com>; Slava Ovsiienko
> <viacheslavo@mellanox.com>
> Subject: [dpdk-dev] [PATCH] net/mlx5: fix LACP action type casting
>
> The mlx5_flow_lacp_miss flow rule for matching LACP traffic was
> added to steer LACP traffic to kernel.
>
> When setting the action type of rte_flow_action to
> MLX5_RTE_FLOW_ACTION_TYPE_DEFAULT_MISS we get an error since the
> action is an enum of type mlx5_rte_flow_action_type.
>
> To solve this a casting of MLX5_RTE_FLOW_ACTION_TYPE_DEFAULT_MISS
> to rte_flow_action was added.
>
> Fixes: 6ff4a90223c4 ("net/mlx5: add default miss action to flow engine")
> Signed-off-by: Shiri Kuzin <shirik@mellanox.com>
> Acked-by: Matan Azrad <matan@mellanox.com>
> ---
> drivers/net/mlx5/mlx5_flow.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c
> index 4700ec1..4a031a5 100644
> --- a/drivers/net/mlx5/mlx5_flow.c
> +++ b/drivers/net/mlx5/mlx5_flow.c
> @@ -5060,7 +5060,8 @@ struct rte_flow *
> };
> struct rte_flow_action actions[] = {
> {
> - .type =
> MLX5_RTE_FLOW_ACTION_TYPE_DEFAULT_MISS,
> + .type = (enum rte_flow_action_type)
> +
> MLX5_RTE_FLOW_ACTION_TYPE_DEFAULT_MISS,
> },
> {
> .type = RTE_FLOW_ACTION_TYPE_END,
> --
> 1.8.3.1
Squashed into relevant commit in next-net-mlx,
Kindest regards,
Raslan Darawsheh
prev parent reply other threads:[~2020-06-30 8:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-29 16:01 Shiri Kuzin
2020-06-30 8:06 ` Raslan Darawsheh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM0PR05MB67075AF61CDF63F888AED05EC26F0@AM0PR05MB6707.eurprd05.prod.outlook.com \
--to=rasland@mellanox.com \
--cc=dev@dpdk.org \
--cc=matan@mellanox.com \
--cc=shirik@mellanox.com \
--cc=viacheslavo@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).