From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id DBFDEA04B8; Tue, 5 May 2020 12:40:37 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1B4451D14B; Tue, 5 May 2020 12:40:37 +0200 (CEST) Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-eopbgr140059.outbound.protection.outlook.com [40.107.14.59]) by dpdk.org (Postfix) with ESMTP id 73F921C43B for ; Tue, 5 May 2020 12:40:35 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AKyuHLOHISvSrIeJZI6KdKZkGzqHJMxjYMTu4X1Mf9IW5MoUGlnWX12HlxA9jElXLmkhh8WeESDeLrHCdOXk9oEXGagXTVzFt/z57/pbgd/80iKHEr2e3G04acexqrfgcwLeb7yOtzAmecA2ovR6CQ0+ZhchbSKg8iXwrzMuhKOuGE7h2pfzrdrdEvE8Pb1yafC66APiXXH1Xb+ZMU2Kz/1reWUnKYW5MukB+d6hyTGou7DHiXLomn733s0JqCSepSq0u6oI05o6QrXDCOllwvl2/tpjpzNTQaSmiGJbEx4T4B9V+KxWh1N046jfqUy7VYu4bS+AfIihwpkExeaV2A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Ws/V02HwZ0BgJXJKGiUbuf30t+6Xul/ko6DSin/u/xo=; b=KKojW62bET+jx+CeqOEpeMRQDAioe9XHAPcQH3ArvlsVlXAj4SCvN34+YFv7XHr4RQqC9bCSZ58DsGvU6zaYhoLvd/bPWDmSJuLC77jH5kESXVf1YDFuq28+gj/IltGdxgoiOQeq3jUaqIz2VrdiJ2Acj96BYL5nM1d7E5Xj163iD9dBAPupAMylT8tjRgoeiGpm3rVhYNxzRSbIJIOz/FXSgNK4sFFFpSRF74kE/KTyvWWircwVkh+r74VxdM02QpOlp2BOjUgadMB9pfaVQqRFI9WS6Vccu14T6TvWoY8zgSQT+1V7XEBTCEvCmYrP0RrJWGJ596cAnZSGgCYF/w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Ws/V02HwZ0BgJXJKGiUbuf30t+6Xul/ko6DSin/u/xo=; b=GHErjb0KMZ1AeaQbRJa6JRFn+sVxqqu8ET4sOjcW0A4KaZvkJ3kdhG8i4I86+9DEDpF3K2u95YxzG1Sf6VueeBLiUjd8G4CYwArsden5pbEiM2rruZcEdUb8lh1QtENRSKJYnD7gmRVvJ4gzeEoe2xZRyKQbO3UhLJ3+Ynq60tk= Received: from AM0PR05MB6707.eurprd05.prod.outlook.com (2603:10a6:20b:15b::17) by AM0PR05MB5859.eurprd05.prod.outlook.com (2603:10a6:208:124::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2958.29; Tue, 5 May 2020 10:40:34 +0000 Received: from AM0PR05MB6707.eurprd05.prod.outlook.com ([fe80::508:747b:cc12:5f6e]) by AM0PR05MB6707.eurprd05.prod.outlook.com ([fe80::508:747b:cc12:5f6e%5]) with mapi id 15.20.2958.030; Tue, 5 May 2020 10:40:34 +0000 From: Raslan Darawsheh To: Ophir Munk , "dev@dpdk.org" CC: Ophir Munk , Matan Azrad Thread-Topic: [PATCH v2] net/mlx5: fix resetting verbs hash fields Thread-Index: AQHWIqTRISx4jlUWDUiUU3Q8kB+006iZTdUg Date: Tue, 5 May 2020 10:40:34 +0000 Message-ID: References: <20200504063851.25030-1-ophirmu@mellanox.com> <20200505061607.15978-1-ophirmu@mellanox.com> In-Reply-To: <20200505061607.15978-1-ophirmu@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: mellanox.com; dkim=none (message not signed) header.d=none;mellanox.com; dmarc=none action=none header.from=mellanox.com; x-originating-ip: [188.161.229.217] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: a4f8e874-9e25-4f45-b4ea-08d7f0e0bdb7 x-ms-traffictypediagnostic: AM0PR05MB5859:|AM0PR05MB5859: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:419; x-forefront-prvs: 0394259C80 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: BTPTvwR+2+C06KHsqe1qI2jub8UAa8CokFVY7QMxyXKs3eIFYq4gJHHfYVuu8a1siH8ejVSUchsthh9ZerzOxAS2gAYQmavyrZheidrxyuQ5ec47MSMHFoCYRjPqTwrWRweGuJwVYh4Z4kGrnKto7ar2lJuUKCrux6FLpOpXvy921tXqS+91cDF00+7iA6ih2w4H0sycBKEnvDrw2mwwLSa9dVRHL/OhGxHQg/Yad0maxW6XQIDA/lXKocG8puZiTBwh9VMRESN4h3bEMT4Cw8Dm3z8/TU/tsgiKCEebHctHntHWBQULUwhPkJB94HbQH7sNOVXjgn+af3FyWpuw4Am2kAH3xw6u7k+c512z4FtnePYbUnP7lOAJgk0996t6RRHYYR5xXPGWwFHlU6bu71qzBl2FONqw2TMcmoWgrE5HVXQ0iPte63mJ9QERaw5G90P8nJLXoaSEcvw1OpPEdKyVG/UmyBW8Lcf3+vNvbtgmYKo3TXuHCgHMO8RYQ8tWspIvkgvR0ZM4X8eH4C7K9g== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM0PR05MB6707.eurprd05.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(39860400002)(376002)(366004)(346002)(396003)(136003)(33430700001)(8936002)(33440700001)(7696005)(71200400001)(33656002)(478600001)(8676002)(86362001)(5660300002)(54906003)(66946007)(66446008)(64756008)(66556008)(66476007)(4326008)(52536014)(107886003)(53546011)(6506007)(26005)(2906002)(316002)(110136005)(9686003)(76116006)(55016002)(186003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: 32kc658CP87xsO7DloCrCbE9h5KGOEgUUnIhzaIn03d2QqqdFz32Q6yyFchGEE/1c1oDritbMn+95kCvn5AhFm2Sg4iZfhyuW9Rqfy46GYo051Y3B0+SMxatFVTk9BsdgqjZGgU5R8o+emjeNQLnTO7GT8IX5rL863nIs0wRks0r82hYcbG5e9W4mH8DkCpSSe4OaphssWDExXJsAIWxJ0lFzBaz6NlEQeb1oWLpIopKMy5NhsFNBOBiNMgc7nSf8bmp3LULwbWCpCC8VZZeXwFJqe4riqZRQPSL6HSuiaVz+WVAZSpTP80uaQClsEORj6rm16c3RRFR7DMkrd++NiqR3J11xR7kph1pyuy+rbtStIShf8e/HBDDYpXvkWugZ1eXS4OqXifeG/b4cBomruyws2R9zt3/9fxq4rZ79vNaFKFWbpi4RNCeImwNV69nkfXchmWjnovtJeQ9Ok17gqectAoF9sv6lUVdFQKs3qRmzQJfTAmU5B1Lc4lru3FWMRbI4Pn9zH+DbNm6lxgqN9LEKjT1bJ4gNm6SsiHWj97Ho0Hrq7Spg2zlXZF4oCaHU9TP2iCKr3PvOR+0gnEAldRHjhXoj0ZoxKGvLWvrWHpUnDrTWSA8v/+AKNxR6Is0jNU5Q9+YP76Ewuomz1whYYQY5t1vo3BO7OFLo4Sdj2mZp0121bxELy+mzIpwmz/9NV4qnbhaYwyWyu94fxOrjNNssS0aYr4YXUaYO9xg9jvNKBSsF5lP5d0GMCF/6jwMZjib9SzdXRh5Ab2iS2P1nKp+ui5Xv18lBwpNRb6qpGh6PzH+HNSUkRUnS8gXJpbs Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: a4f8e874-9e25-4f45-b4ea-08d7f0e0bdb7 X-MS-Exchange-CrossTenant-originalarrivaltime: 05 May 2020 10:40:34.2169 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: afQfiXXCIVh/fyK2HvaqHIUzFVQHEUrKjfncVCUPEzoGfhnXCaH+q3S37A53AsuU49Lh7mlqDCJA0D+6tzC3Vw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR05MB5859 Subject: Re: [dpdk-dev] [PATCH v2] net/mlx5: fix resetting verbs hash fields X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, > -----Original Message----- > From: Ophir Munk > Sent: Tuesday, May 5, 2020 9:16 AM > To: dev@dpdk.org > Cc: Ophir Munk ; Raslan Darawsheh > ; Matan Azrad > Subject: [PATCH v2] net/mlx5: fix resetting verbs hash fields >=20 > The flow_verbs_translate() function accumulates hash fields while > iterating through the flow items (SRC_IPV4, DST_IPV4, SRC_IPV6, > DST_IPV6, SRC_PORT_TCP, DST_PORT_TCP, SRC_PORT_UDP, > DST_PORT_UDP). > Before this commit the dev_flow handle structure was reused in each new > flow_verbs_translate() call, however the dev_flow->hash_fields variable > was not reset before each call. As a result hash_fields from previous > calls remained present in the current flow which lead to invalid > combinations (e.g. simultaneous IPv4 and IPv6 specs). This scenario > happens for example in the next flows sequence, when running in verbs > mode (dv_flow_en=3D0). >=20 > flow create 0 ingress group 0 pattern eth / ipv4 / end > flow create 0 ingress group 0 pattern eth / ipv6 / end >=20 > The fix is to reset dev_flow->hash_fields in flow_verbs_prepare(). >=20 > Fixes: e7bfa3596a0a ("net/mlx5: separate the flow handle resource") >=20 > Signed-off-by: Ophir Munk > --- > drivers/net/mlx5/mlx5_flow_verbs.c | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git a/drivers/net/mlx5/mlx5_flow_verbs.c > b/drivers/net/mlx5/mlx5_flow_verbs.c > index 7efd97f..4659f0a 100644 > --- a/drivers/net/mlx5/mlx5_flow_verbs.c > +++ b/drivers/net/mlx5/mlx5_flow_verbs.c > @@ -1539,6 +1539,7 @@ flow_verbs_prepare(struct rte_eth_dev *dev, > dev_flow->verbs.size =3D 0; > dev_flow->verbs.attr.num_of_specs =3D 0; > dev_flow->ingress =3D attr->ingress; > + dev_flow->hash_fields =3D 0; > /* Need to set transfer attribute: not supported in Verbs mode. */ > return dev_flow; > } > -- > 2.8.4 Patch applied to next-net-mlx, Kindest regards, Raslan Darawsheh