DPDK patches and discussions
 help / color / mirror / Atom feed
From: Raslan Darawsheh <rasland@mellanox.com>
To: Slava Ovsiienko <viacheslavo@mellanox.com>,
	"dev@dpdk.org" <dev@dpdk.org>
Cc: Matan Azrad <matan@mellanox.com>, Ori Kam <orika@mellanox.com>,
	Shahaf Shuler <shahafs@mellanox.com>,
	"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix doorbell register offset type
Date: Wed, 15 Jan 2020 10:09:05 +0000	[thread overview]
Message-ID: <AM0PR05MB6707786218A5E36E2BF36EC5C2370@AM0PR05MB6707.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <1578925357-7088-1-git-send-email-viacheslavo@mellanox.com>

Hi,


> -----Original Message-----
> From: Viacheslav Ovsiienko <viacheslavo@mellanox.com>
> Sent: Monday, January 13, 2020 4:23 PM
> To: dev@dpdk.org
> Cc: Matan Azrad <matan@mellanox.com>; Raslan Darawsheh
> <rasland@mellanox.com>; Ori Kam <orika@mellanox.com>; Shahaf Shuler
> <shahafs@mellanox.com>; stable@dpdk.org
> Subject: [PATCH] net/mlx5: fix doorbell register offset type
> 
> The doorbell register is mapped using mmap() and offset must have off_t
> instead of unsigned int. Bug is not critical due to only least significant bits of
> offset are currently tested to determine mapping mode.
> 
> Fixes: 8409a28573d3 ("net/mlx5: control transmit doorbell register mapping")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com>
> ---
>  drivers/net/mlx5/mlx5_txq.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/mlx5/mlx5_txq.c b/drivers/net/mlx5/mlx5_txq.c
> index c750082..1a76f6e 100644
> --- a/drivers/net/mlx5/mlx5_txq.c
> +++ b/drivers/net/mlx5/mlx5_txq.c
> @@ -314,7 +314,7 @@
>  txq_uar_ncattr_init(struct mlx5_txq_ctrl *txq_ctrl, size_t page_size)  {
>  	struct mlx5_priv *priv = txq_ctrl->priv;
> -	unsigned int cmd;
> +	off_t cmd;
> 
>  	txq_ctrl->txq.db_heu = priv->config.dbnc ==
> MLX5_TXDB_HEURISTIC;
>  	txq_ctrl->txq.db_nc = 0;
> --
> 1.8.3.1


Patch applied to next-net-mlx,

Kindest regards,
Raslan Darawsheh

      parent reply	other threads:[~2020-01-15 10:09 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-12  5:32 [dpdk-dev] [PATCH] net/mlx5: fix 32b compilation Shahaf Shuler
2019-06-12 21:25 ` Yongseok Koh
2019-06-13 13:29   ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
2019-06-13 13:35     ` Ferruh Yigit
2020-01-13 14:22 ` [dpdk-dev] [PATCH] net/mlx5: fix doorbell register offset type Viacheslav Ovsiienko
2020-01-13 14:29   ` Matan Azrad
2020-01-15 10:09   ` Raslan Darawsheh [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AM0PR05MB6707786218A5E36E2BF36EC5C2370@AM0PR05MB6707.eurprd05.prod.outlook.com \
    --to=rasland@mellanox.com \
    --cc=dev@dpdk.org \
    --cc=matan@mellanox.com \
    --cc=orika@mellanox.com \
    --cc=shahafs@mellanox.com \
    --cc=stable@dpdk.org \
    --cc=viacheslavo@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).