From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9A4DCA04FD; Wed, 15 Jan 2020 11:09:09 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3695A1C00F; Wed, 15 Jan 2020 11:09:08 +0100 (CET) Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-eopbgr140044.outbound.protection.outlook.com [40.107.14.44]) by dpdk.org (Postfix) with ESMTP id A4F0D1BF7D; Wed, 15 Jan 2020 11:09:06 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lUSb5MKAsRAdDzprhOH8BPSWzGmnJRY4Zcs8UkPqTv1pEWRPDqoWY+r0Bmci67fpitZ0mtXVVDgB96VkarF2Tk1bZQdNIfPq34GlvPcxETd+ndB9DHogG7R+E2B71lBnuHkCxUT2NSd6SPzz47CHMwtg60GGmDlBSvk84MCyNwtsYw7UBZFR1l4Nv7+datXAooIiA2QR5f41w2i3IgvQJXUMJKzaAkL5XOkMiHv8hdl9IgpHQHnx4MZstAwHFht1sD1JuVF5G3fbiRZT9np2eK7XBHtKtij+5pLChXTpk2SKQI3IDXNNp6rHHrzceV0/zsd8lO9kYjAPU5F/MTIyYg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6aErdNHUINjsz2qmP5qmkOtY0/lXli2s0UjLPkxmKMQ=; b=J8PHF3d0XJv8eL/zqKQ/ZOAeLglXQKvIKPnYoMeLuGF0VEiV/05k/GYFRiwln6wuQ+FlRSWwGefpDEM94Qtvlw3uyaNBPsdm/xK1ojBlIk4mEtSoJ0i+l+QaCekiTB1vHp2KXOCmx+nd9k01xs5HSE2VHsWcDVE0DfpAWc9mv6me/5Xu3ON/9lqxS9QU8HMcnmsmOWXJJWhqZip0/aRP0EZ+uyIVtJrXzZX8emc6LcH405C8Et/AxDShqNBZOJ5VHV57p6YyO6BAR38hXK6EbCuicjiJ5woapm1k5aR8RzM2K94WGwO9BXY+HB9/Lpqq/lDcLFtII/ZFKYNWklNduA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6aErdNHUINjsz2qmP5qmkOtY0/lXli2s0UjLPkxmKMQ=; b=KP9Z0F5dvitsgVDJFS5MVUb4cxXCA/oDpv64Jeoq/48AKWeUvxD+utg2z7OzVhtKtFeJA5eh7DmTpi7k0Dx6RWdu6rqUTWF0sO1EtO6YyCXU6wZQffPbfWLTpjAvmWv1slFTLZ5q72WJngxPB/Ss8p/XmAnvE+TCglMhwl890YY= Received: from AM0PR05MB6707.eurprd05.prod.outlook.com (10.186.174.145) by AM0PR05MB6036.eurprd05.prod.outlook.com (20.178.118.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2623.9; Wed, 15 Jan 2020 10:09:05 +0000 Received: from AM0PR05MB6707.eurprd05.prod.outlook.com ([fe80::95ff:bfb2:7f11:87b2]) by AM0PR05MB6707.eurprd05.prod.outlook.com ([fe80::95ff:bfb2:7f11:87b2%5]) with mapi id 15.20.2623.018; Wed, 15 Jan 2020 10:09:05 +0000 From: Raslan Darawsheh To: Slava Ovsiienko , "dev@dpdk.org" CC: Matan Azrad , Ori Kam , Shahaf Shuler , "stable@dpdk.org" Thread-Topic: [PATCH] net/mlx5: fix doorbell register offset type Thread-Index: AQHVyh0Px/PKGh0DKUuLNVoZQ2SwHafrg1iw Date: Wed, 15 Jan 2020 10:09:05 +0000 Message-ID: References: <20190612053215.5682-1-shahafs@mellanox.com> <1578925357-7088-1-git-send-email-viacheslavo@mellanox.com> In-Reply-To: <1578925357-7088-1-git-send-email-viacheslavo@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=rasland@mellanox.com; x-originating-ip: [212.29.221.74] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 041305ec-2742-44a1-0bd1-08d799a2f438 x-ms-traffictypediagnostic: AM0PR05MB6036:|AM0PR05MB6036: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:883; x-forefront-prvs: 02830F0362 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(366004)(396003)(39860400002)(376002)(136003)(346002)(189003)(199004)(55016002)(9686003)(8936002)(6506007)(8676002)(81156014)(4326008)(450100002)(81166006)(2906002)(86362001)(54906003)(7696005)(5660300002)(53546011)(66476007)(76116006)(64756008)(71200400001)(33656002)(316002)(66946007)(478600001)(52536014)(186003)(66446008)(110136005)(66556008)(26005); DIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR05MB6036; H:AM0PR05MB6707.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: teCO2Ct+d3FZNWDy5NICz8FXduq7JTE4T9UszAwzoZlpA/8bQcxhXr/qp695drDFjYuIwvXhQSygMs4ExH+OnIUwVl8nyf2bagAuGvjs1lu2O8qNJk9bb+4f7gQ24dxcZ/jTL8uGKz0aW0Irw/2fo4NwYoRc+76R+mKmOAqS/RQ3MGgnFP/8XHTAQD80G3rCH3fXjFJDY7TT0SjBEaK7FaOebsX2nNdmCAk7zvXCE87hoblovr3j/Fc/cNB6WaD/bLdJaZZIMNLWcAsqpSZFOP9DGvapgo+dk8oIdZUL9wV9kAA6wN8vwxaA2noZxNQpWTXlOhZtaOOPp2ctgg/s66Kz5JNb1rcLiiIDsATDbAwK82F0OFjfPU8Dk6yoD8Z3XYJGgbM0hdDr8enH24mZY412m149XsBAVNKp3OaklXU0BW6SC1/ehcYu0qI63lQi Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 041305ec-2742-44a1-0bd1-08d799a2f438 X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Jan 2020 10:09:05.5756 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: u2KtumdOdSHNkNUfLa0MiF/PJKb9EwBYfF8NH67V8qXs1DczXXv7leuCIdeJKgthQccfSVemdZW3i16nkk+KoQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR05MB6036 Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix doorbell register offset type X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, > -----Original Message----- > From: Viacheslav Ovsiienko > Sent: Monday, January 13, 2020 4:23 PM > To: dev@dpdk.org > Cc: Matan Azrad ; Raslan Darawsheh > ; Ori Kam ; Shahaf Shuler > ; stable@dpdk.org > Subject: [PATCH] net/mlx5: fix doorbell register offset type >=20 > The doorbell register is mapped using mmap() and offset must have off_t > instead of unsigned int. Bug is not critical due to only least significan= t bits of > offset are currently tested to determine mapping mode. >=20 > Fixes: 8409a28573d3 ("net/mlx5: control transmit doorbell register mappin= g") > Cc: stable@dpdk.org >=20 > Signed-off-by: Viacheslav Ovsiienko > --- > drivers/net/mlx5/mlx5_txq.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/net/mlx5/mlx5_txq.c b/drivers/net/mlx5/mlx5_txq.c > index c750082..1a76f6e 100644 > --- a/drivers/net/mlx5/mlx5_txq.c > +++ b/drivers/net/mlx5/mlx5_txq.c > @@ -314,7 +314,7 @@ > txq_uar_ncattr_init(struct mlx5_txq_ctrl *txq_ctrl, size_t page_size) { > struct mlx5_priv *priv =3D txq_ctrl->priv; > - unsigned int cmd; > + off_t cmd; >=20 > txq_ctrl->txq.db_heu =3D priv->config.dbnc =3D=3D > MLX5_TXDB_HEURISTIC; > txq_ctrl->txq.db_nc =3D 0; > -- > 1.8.3.1 Patch applied to next-net-mlx, Kindest regards, Raslan Darawsheh