Re: [dpdk-dev] [PATCH v2] net/mlx5: fix incorrect index when creating flow

[Raslan Darawsheh <rasland@mellanox.com>]

Hi,
> -----Original Message-----
> From: Bing Zhao <bingz@mellanox.com>
> Sent: Thursday, April 9, 2020 5:39 PM
> To: Slava Ovsiienko <viacheslavo@mellanox.com>; Raslan Darawsheh
> <rasland@mellanox.com>
> Cc: Ori Kam <orika@mellanox.com>; Matan Azrad <matan@mellanox.com>;
> dev@dpdk.org
> Subject: [PATCH v2] net/mlx5: fix incorrect index when creating flow
> 
> When creating a flow, usually the creating routine is called in
> serial. No parallel execution is supported right now. The same
> function will be called only once for a single flow creation.
> But there is a special case that the creating routine will be called
> nested. If the xmeta feature is enabled and there is FLAG / MARK in
> the actions list, some metadata reg copy flow needs to be created
> before the original flow is applied to the hardware.
> In the flow non-cached mode, resources only for flow creation will
> not be saved anymore. The memory space is pre-allocated and reused
> for each flow. A global index for each device is used to indicate
> the memory address of the resources. If the function is called in a
> nested mode, then the index will be reset and make everything get
> corrupted.
> To solve this, a nested index is introduced to save the position for
> the original flow creation. Currently, only one level nested call
> of the flow creating routine is supported.
> 
> Fixes: 9273a26fe267 ("net/mlx5: separate the flow handle resource")
Fixed Fixes ID:  Fixes: da68485be ("net/mlx5: separate the flow handle resource")
> 
> Signed-off-by: Bing Zhao <bingz@mellanox.com>
> Acked-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com>
> ---
> v2: fix the typo of email address.
> ---

Patch applied to next-net-mlx,
Kindest regards
Raslan Darawsheh