From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8154AA058A; Sun, 12 Apr 2020 18:24:08 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 524EB293C; Sun, 12 Apr 2020 18:24:07 +0200 (CEST) Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2064.outbound.protection.outlook.com [40.107.22.64]) by dpdk.org (Postfix) with ESMTP id 52D081B53 for ; Sun, 12 Apr 2020 18:24:06 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=W0aklwKgLjZFpeoJgii24E2VjUsOwQyJQ+5OKUoPTeUrTT5v6TvXpjsMlvcUCK2ERPC40at3oL+8OKOgLt2he80l3w37bUaU7wSjXOSVUebgmXmIpY+R/cyUB8rxLFvwXaQK1U53YX/Blxa0fFbLCEnItJrRDOr1rdXwWpyQ6G+hKrHTwHOLHmQKLjpR936u+dAfkwkefaLHHxBJ5S2UQEzkMK8p+Q+SHep0Qf8R648pEK1ajeiMNyOgwtaA+HyPMMB5Fh1hRAO7bzJCDypSWZ46TkKnpqTu6mYTm029cG3wYG+hxI21da3VTBgNJXoZnMY5PBkj2si6NzXPsMgJeQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zmlMYzeVS3lq7vXufvrRWV3kj8uzKm6BXPxGdVT6V0o=; b=DoLt0AivnMomOd6CfxvYm/8l+SO0TQwUTmNLsue7Sa7EBKOgeyKmxH25gt0ORQZEMY8wzEH7J57hqTAtIJ+BvhxaSuOdvSBSUMak2BVX3gOXeO1mYncK7scFZYa9I5NmMh2mSJNjtQKCEAqG+YTj+OAl0nVbUA2FGwZrm/PqZTW8Mmjp6eZUH7/c/meObhvwuHaj4IXKQS8d46m9aWEDGFal095AqjbgexxI0fXuK0+8zPrhaUxsYH/XXGE47e9jpWsmZMaOrb50EJPs/H0g1+88AozgagbX+TEJ8NVR3hG0LIjhPnwfQbufwewYSLHl50JbGWPVyKPCbEOluG8+KQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zmlMYzeVS3lq7vXufvrRWV3kj8uzKm6BXPxGdVT6V0o=; b=BIRn7YQ2F+YI9m5CO4NDC5b3wIZW0JBk1Et9tHkgTU0CJuCt3Kg5OKzX4wAcKqxYPB6f6YLkDs9IntjkLGKB/NifnzFvrJ4edg3gra/j8Bemy/fEaiUJvjIxwrPjFLnMIdX8m4FgxLHTgYjLaUwrR/h3wnmOSCXKKWjyjEko6FM= Received: from AM0PR05MB6707.eurprd05.prod.outlook.com (2603:10a6:20b:15b::17) by AM0PR05MB4211.eurprd05.prod.outlook.com (2603:10a6:208:67::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2900.15; Sun, 12 Apr 2020 16:24:05 +0000 Received: from AM0PR05MB6707.eurprd05.prod.outlook.com ([fe80::508:747b:cc12:5f6e]) by AM0PR05MB6707.eurprd05.prod.outlook.com ([fe80::508:747b:cc12:5f6e%6]) with mapi id 15.20.2900.028; Sun, 12 Apr 2020 16:24:05 +0000 From: Raslan Darawsheh To: Bing Zhao , Slava Ovsiienko CC: Ori Kam , Matan Azrad , "dev@dpdk.org" Thread-Topic: [PATCH v2] net/mlx5: fix incorrect index when creating flow Thread-Index: AQHWDnyUH3YoJTp6+EanNAbF1NSWzah1sF9g Date: Sun, 12 Apr 2020 16:24:04 +0000 Message-ID: References: <1586442717-281512-1-git-send-email-bingz@mellanox.com> <1586443121-281661-1-git-send-email-bingz@mellanox.com> In-Reply-To: <1586443121-281661-1-git-send-email-bingz@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=rasland@mellanox.com; x-originating-ip: [188.161.230.106] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: c3bb8146-eacb-47ea-2fbf-08d7defdeb32 x-ms-traffictypediagnostic: AM0PR05MB4211:|AM0PR05MB4211: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7691; x-forefront-prvs: 0371762FE7 x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM0PR05MB6707.eurprd05.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(10009020)(4636009)(366004)(346002)(376002)(39860400002)(396003)(136003)(33656002)(76116006)(55016002)(186003)(7696005)(6506007)(2906002)(4326008)(316002)(54906003)(52536014)(26005)(110136005)(5660300002)(53546011)(71200400001)(66446008)(64756008)(66556008)(66476007)(66946007)(9686003)(478600001)(8936002)(8676002)(86362001)(81156014)(6636002); DIR:OUT; SFP:1101; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: sNCF/jmSv5Mc+zma+4HZ3S2JVr5sx0dwmMRJVe97jub9l/iUtJzA3P6YmWAfOerfI5xdPGVre4Gt3tBX0hq5NHv71ZISkDtneBbsQWcjrSFTXQWfXX8wlarqfJkveQevulOT+WVGWKiBR37HDBzNa5IRaLNL/PdLekjgVCJIXzkqGubiFJBaUIOBXZxuecZknq9EYVuuQAcYT7j/+/UKHMSPNhzcV9do0DKfhgXv0Yw/nbubknGwAJE8iqgb6qTeOUKt/u0np2yxRLTGwBoq/rr7cssPs/dIuV9r+sIqD/4S+2tpEwGCU3AkteFNULJrr6ANxp3zH4sBJ8ZY3PabW7DLIY5V1M7hThHup5CElQqpPVUGahN7t+j2WvWc5zk0f0m72QFb0z7snzrcXHFvOMQqyFcv2DqSSFGd6oNeUIl+nQQtdiHDtS09ouKtlUVu x-ms-exchange-antispam-messagedata: RXBmDt7oCpr3u2us/2u/dSWCY/vUOM9Da6xa4PqPXp2AB1L6pckTE16R/O8kQaXAfG901zwuYEGYLil/bHY/3b23u1PD0Tac3zvdl46HgcLKXsGHV25y5XsXPtQLBV1N+HG+w+PEVcSNDH3ZQIJS1A== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: c3bb8146-eacb-47ea-2fbf-08d7defdeb32 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Apr 2020 16:24:04.7463 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: pK+JYLG/hT4pLiLyuM3G9lQ7fc37dYBMkTjiAQFLjBsKoVrd/e1k/lotjSfX/rXjF6uxm1Yb/xxB1rWVnnNa6g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR05MB4211 Subject: Re: [dpdk-dev] [PATCH v2] net/mlx5: fix incorrect index when creating flow X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, > -----Original Message----- > From: Bing Zhao > Sent: Thursday, April 9, 2020 5:39 PM > To: Slava Ovsiienko ; Raslan Darawsheh > > Cc: Ori Kam ; Matan Azrad ; > dev@dpdk.org > Subject: [PATCH v2] net/mlx5: fix incorrect index when creating flow >=20 > When creating a flow, usually the creating routine is called in > serial. No parallel execution is supported right now. The same > function will be called only once for a single flow creation. > But there is a special case that the creating routine will be called > nested. If the xmeta feature is enabled and there is FLAG / MARK in > the actions list, some metadata reg copy flow needs to be created > before the original flow is applied to the hardware. > In the flow non-cached mode, resources only for flow creation will > not be saved anymore. The memory space is pre-allocated and reused > for each flow. A global index for each device is used to indicate > the memory address of the resources. If the function is called in a > nested mode, then the index will be reset and make everything get > corrupted. > To solve this, a nested index is introduced to save the position for > the original flow creation. Currently, only one level nested call > of the flow creating routine is supported. >=20 > Fixes: 9273a26fe267 ("net/mlx5: separate the flow handle resource") Fixed Fixes ID: Fixes: da68485be ("net/mlx5: separate the flow handle reso= urce") >=20 > Signed-off-by: Bing Zhao > Acked-by: Viacheslav Ovsiienko > --- > v2: fix the typo of email address. > --- Patch applied to next-net-mlx, Kindest regards Raslan Darawsheh