From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id BAB32A0350; Sun, 28 Jun 2020 15:55:42 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D9D271C2AC; Sun, 28 Jun 2020 15:55:41 +0200 (CEST) Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60045.outbound.protection.outlook.com [40.107.6.45]) by dpdk.org (Postfix) with ESMTP id 49B981C2A9 for ; Sun, 28 Jun 2020 15:55:40 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=B4fHM++n6m7JI+YqmGgWWOSKJI9aQ/4QweJ41ZiDdrUE6no8HjTi2G81ZnRBUu9rBXS9/s75zJJq39lFDBmrUwWgGKxTye1Fhf/JYuTuiNiXIqaC68xSjv7xwXhV5lhSJOtnesxBIIU/UB4pAH43IlA2hRZh6yLGQKo/QXBy8rMHFuG8QoqKmG9dzpf5yBYxCdnQn+778M1Hek2pZIAuXPS/qsgcylKM8yrY+tBUPcrCD3IoMDEVPrg8soICejxK/14CLwymJXTI3UQO5bR/yI3ZC9cXfYwJplwEIYk8BwPHx7pGvJ21MUWKpU6JLalYI/rC57JOY7Yg9hCZOmdBUA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+yOdzXg5aGyNXVNl7xwfh6IzR2sL0XUb6lKpDc5yKsY=; b=Nc7mmbQr0ZuEiesQ8S0m94hscArleiBgjj4wYAI7dVfkz8MJcLLsSrFWuCTHQr+urhkbBp7fgkqPzJ6Uv6lguZszQ6R3bpjXFAps9++Cyf2Nbs+n93sHYQdjC0YWPhQgi4ioXzn/5/qq00v0LaFUpC5MXRMWIvaK0nKlv1NnhZIh3gm/e40g5Sm8kduoHarhd4iQE6CyjmTF+MX9h+NK+zlxrj7HOMXSgwa/uwHjbBiXVYv/teTo5GAjEgppaL5Su8GFG4+VFfaqfI3C5/teGEMlX2dfvH8PbxMzHN3Ph5dgrhMf3sc5tRfrt/JApA3rbuLjP95LsldTj4GrGdALiw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+yOdzXg5aGyNXVNl7xwfh6IzR2sL0XUb6lKpDc5yKsY=; b=PzA11axRhI3m9aAKaoA8IqsEOQYXfB6EysiGcoSNJJHDfQEkven3WB4mQADXJq029VCgs52jFRn7BIYpD3A/GajKUQjLp/csj4aVj6AQ0iC5emp6wcZnUI703768LKw9aQRRPFeBNHFN9NUeDdgASzXkk+oz8S0gmdMSlnTwZng= Received: from AM0PR05MB6707.eurprd05.prod.outlook.com (2603:10a6:20b:15b::17) by AM0PR05MB5185.eurprd05.prod.outlook.com (2603:10a6:208:ef::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3131.26; Sun, 28 Jun 2020 13:55:39 +0000 Received: from AM0PR05MB6707.eurprd05.prod.outlook.com ([fe80::ecd3:6008:3784:4012]) by AM0PR05MB6707.eurprd05.prod.outlook.com ([fe80::ecd3:6008:3784:4012%4]) with mapi id 15.20.3131.026; Sun, 28 Jun 2020 13:55:39 +0000 From: Raslan Darawsheh To: Michael Baum , "dev@dpdk.org" CC: Matan Azrad , Slava Ovsiienko Thread-Topic: [dpdk-dev] [PATCH 2/7] net/mlx5: use direct API to find port by device Thread-Index: AQHWSjHLFFTf1+2KvkC9ivPC/d6M7qjuEoww Date: Sun, 28 Jun 2020 13:55:38 +0000 Message-ID: References: <1592998387-28181-1-git-send-email-michaelba@mellanox.com> <1592998387-28181-2-git-send-email-michaelba@mellanox.com> In-Reply-To: <1592998387-28181-2-git-send-email-michaelba@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: mellanox.com; dkim=none (message not signed) header.d=none;mellanox.com; dmarc=none action=none header.from=mellanox.com; x-originating-ip: [84.242.49.134] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 1e6fdd3a-06df-41ca-d695-08d81b6af0c1 x-ms-traffictypediagnostic: AM0PR05MB5185: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:913; x-forefront-prvs: 0448A97BF2 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: WecrFgmH9samOzLnJ0Jywn6echhKwoSzVhW5s96C4I8hXSfSiCdEwNqFz86a6M5snc0cyNuZVeL9w+nIV1AKyAddP/M+vniDpSZOlk4LM/BuzpZkEN7aTAldfjlI1Pi4B0BACFdEfaRV+DnjJoWvrei0tkbzdiRviD0Ydn8xZ2FQ5XwO1WCa8zzpNXiBoV3nuvtvgf1tY1zxrTWdbzwRia5RgVuCPRr/vadED3eTGSKSYTTP2G6ng40XJ0oX13O91dEgduIqoMttiR51YZfCu2HEDVE39uIDPKgAj7jbbBdbyMUkmNe+yXlpJMLDg/CNIJf22xhb1jTq8Iekfwl/c39dZRUgMdNiT8AfCdJGmT5bN0SZKWbGrAk20DmDq8U5 x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM0PR05MB6707.eurprd05.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(136003)(39860400002)(376002)(366004)(396003)(346002)(55016002)(71200400001)(26005)(9686003)(33656002)(5660300002)(86362001)(52536014)(66446008)(66946007)(66556008)(64756008)(83380400001)(66476007)(76116006)(316002)(478600001)(186003)(107886003)(2906002)(7696005)(53546011)(6506007)(4326008)(110136005)(8936002)(54906003)(37363001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: DET1bN5XuUS7/e/XyGi8NHndnYvLMj3s/0HcsQgdVOcVEPFd9reKARKxXICqpXSmfDwaU9T6SfBXXUYwSs1QCEYibZNkAjSI4/0wLqguAhQvkOeQ9RKX5swcjlVOcvIbDnwRAFIHL5jH6pJcnlcuHFuXsMGcsTdf85JIV2ejeEKzGoqwcR2hyCC3+MON3Kh7ucD02fcJQ+LTy/VRwuhk1/pKHkNCdj0tr7KcK19lq2W+6mW4bFHrK74y13FKXzIxFCdaVhlY3nPdaYzeKf7OYdltHiULcXkJr1lP7SLD4UvU+MmqOHLzrZQEsoK1py7lQ5HWIKbh4sBO5LFwCrU36I9rz636r+ACaycbjZ/ZLaSMevUTHhoevPq/hYTvasjKoF4tvok97+kbHEhwtzDmtuUdrMdbBqC6fUL0Xofojr4BsBjTHU5xS9lUBhgpmKmJZWLhlXT9KNVXjQR4F6DE6AARTrVOskKpPpYZ9GyJ2ixCDK8xQiFcjgWv8TWiEylE Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AM0PR05MB6707.eurprd05.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1e6fdd3a-06df-41ca-d695-08d81b6af0c1 X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Jun 2020 13:55:38.9836 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: lJ0XVJlkDS1VmG5LkES+Z7on02ZB6JSkvMQpLwVvRROXYiovC08GLXknTfh8bbqF2yiH5K0Dy0StM/69i+04+A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR05MB5185 Subject: Re: [dpdk-dev] [PATCH 2/7] net/mlx5: use direct API to find port by device X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, > -----Original Message----- > From: dev On Behalf Of Michael Baum > Sent: Wednesday, June 24, 2020 2:33 PM > To: dev@dpdk.org > Cc: Matan Azrad ; Slava Ovsiienko > > Subject: [dpdk-dev] [PATCH 2/7] net/mlx5: use direct API to find port by > device >=20 > Using RTE_ETH_FOREACH_DEV_OF loop is not necessary when the driver > wants > to find only the first match. >=20 > Use rte_eth_find_next_of to find it. >=20 > Signed-off-by: Michael Baum > Acked-by: Matan Azrad > --- > drivers/net/mlx5/mlx5_mr.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) >=20 > diff --git a/drivers/net/mlx5/mlx5_mr.c b/drivers/net/mlx5/mlx5_mr.c > index adbe07c..3b781b6 100644 > --- a/drivers/net/mlx5/mlx5_mr.c > +++ b/drivers/net/mlx5/mlx5_mr.c > @@ -313,9 +313,10 @@ struct mr_update_mp_data { > { > uint16_t port_id; >=20 > - RTE_ETH_FOREACH_DEV_OF(port_id, &pdev->device) > - return &rte_eth_devices[port_id]; > - return NULL; > + port_id =3D rte_eth_find_next_of(0, &pdev->device); > + if (port_id =3D=3D RTE_MAX_ETHPORTS) > + return NULL; > + return &rte_eth_devices[port_id]; > } >=20 > /** > -- > 1.8.3.1 Patch applied to next-net-mlx, Kindest regards, Raslan Darawsheh