DPDK patches and discussions
 help / color / mirror / Atom feed
From: Raslan Darawsheh <rasland@mellanox.com>
To: David Marchand <david.marchand@redhat.com>,
	"dev@dpdk.org" <dev@dpdk.org>
Cc: Thomas Monjalon <thomas@monjalon.net>,
	Matan Azrad <matan@mellanox.com>,
	Shahaf Shuler <shahafs@mellanox.com>,
	Slava Ovsiienko <viacheslavo@mellanox.com>,
	Ophir Munk <ophirmu@mellanox.com>
Subject: Re: [dpdk-dev] [PATCH] common/mlx5: remove unneeded experimental build	flag
Date: Mon, 29 Jun 2020 09:17:31 +0000	[thread overview]
Message-ID: <AM0PR05MB6707905B8EB65D87A7232107C26E0@AM0PR05MB6707.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <20200625075742.27657-1-david.marchand@redhat.com>

Hi,

> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of David Marchand
> Sent: Thursday, June 25, 2020 10:58 AM
> To: dev@dpdk.org
> Cc: Thomas Monjalon <thomas@monjalon.net>; Matan Azrad
> <matan@mellanox.com>; Shahaf Shuler <shahafs@mellanox.com>; Slava
> Ovsiienko <viacheslavo@mellanox.com>; Ophir Munk
> <ophirmu@mellanox.com>
> Subject: [dpdk-dev] [PATCH] common/mlx5: remove unneeded
> experimental build flag
> 
> allow_experimental_apis flag has no effect for in-tree compilation.
> See
> https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.dp
> dk.org%2Fdpdk%2Fcommit%2F%3Fid%3Dacec04c4b2f5&amp;data=02%7C01
> %7Crasland%40mellanox.com%7C892d421ac87447634c2608d818dd7df0%7Ca
> 652971c7d2e4d9ba6a4d149256f461b%7C0%7C0%7C637286686875768352&am
> p;sdata=lNkQ9KxAxW702IiqtCUPFL0Lh24zaNXqMzX0U0LLVzk%3D&amp;rese
> rved=0
> 
> Fixes: 72f756605651 ("common/mlx5: move glue files under Linux directory")
> 
> Signed-off-by: David Marchand <david.marchand@redhat.com>
Acked-by: Raslan Darawsheh <rasland@mellanox.com>

> ---
>  drivers/common/mlx5/meson.build | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/common/mlx5/meson.build
> b/drivers/common/mlx5/meson.build
> index 0a8980f2d3..ba43714af3 100644
> --- a/drivers/common/mlx5/meson.build
> +++ b/drivers/common/mlx5/meson.build
> @@ -7,8 +7,6 @@ if not (is_linux or is_windows)
>  	subdir_done()
>  endif
> 
> -allow_experimental_apis = true
> -
>  deps += ['hash', 'pci', 'net', 'eal', 'kvargs']
>  sources += files(
>  	'mlx5_devx_cmds.c',
> --
> 2.23.0


Patch applied to next-net-mlx,

Kindest regards,
Raslan Darawsheh

      reply	other threads:[~2020-06-29  9:17 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-25  7:57 David Marchand
2020-06-29  9:17 ` Raslan Darawsheh [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AM0PR05MB6707905B8EB65D87A7232107C26E0@AM0PR05MB6707.eurprd05.prod.outlook.com \
    --to=rasland@mellanox.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=matan@mellanox.com \
    --cc=ophirmu@mellanox.com \
    --cc=shahafs@mellanox.com \
    --cc=thomas@monjalon.net \
    --cc=viacheslavo@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).