From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8F832A0556; Thu, 20 Feb 2020 12:25:42 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 62FE71C00E; Thu, 20 Feb 2020 12:25:42 +0100 (CET) Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-eopbgr140049.outbound.protection.outlook.com [40.107.14.49]) by dpdk.org (Postfix) with ESMTP id 2C9DC1C00D; Thu, 20 Feb 2020 12:25:41 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gtQyrY1y7oAEyR/KKwsW87yEskl1uNdGr4aSfQH6GkjoyEroYtS3JnrU+eSb2FusIc5H+naTS3VjyMRFss1/2twUz3twBmKGckF0JI2zjfWOwqKHMpFTH89yLTyg11hQJ3kbHmG6SQdtHDYE0hrh0AuH63YwExCLS7nQqUcP6xmur+xk0D/IUSaB8zyUcKs+zxjcWziuHuyakWMz4jDmCKgRazKmhr2pIySULprvNfOXVy4zQbXZilQXIko04BAIj+5MsQHOm8fgmPB4gNS+godFl0LLWqHdAKpVkyS9b6vQOcv64H4sJQ/vVcszG3rMyEdR90tchs0JPtUPLcRgHA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=j+1N12uLjM5kLUBukXsQnPAQC2MXdDsDtLunxDNWIjQ=; b=YzJVB1aTvYIrSBlx9iwEOnZvgV78ulrWEp/k0JtyVnf/3rfVPcJKfTa9+8Dr+OTSVlJSmiIieAXmPRE7gxxU7KEHQQMcOPhBlO/fXBOKY+cYdbhEzA/jHwzM8qkxSMRdDM8dySNafFVygrF4Zza+X9pdZHoRSAPIsCnkM2K/UcFH50zYVbKBwr2Ej0m8gPQQjW7mawVEF+H80V2x+H2Y8hYMxkNeJMXIY0B8NwRJidTL/oD5EEXcPNhjtAl6Rg7YT8HiseN8EazpvkyMNyyD1v6IUGJjct2bAha7YC80cCFC+UD5oHM2KP7f0e+mqGCrjIuDutcZYwnboV7pSEC5kA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=j+1N12uLjM5kLUBukXsQnPAQC2MXdDsDtLunxDNWIjQ=; b=PGSMjWwtZs0k5KYAnrrX3cJj2CEqZNQTyMhe3wbTkHzoSVp127U0cco59hRu80Tu+1Nzl7dGNvoc4qwnldQ/zbtl96sQU75WWD2UWixjPitAnQIeOT7IiE46P8r8yhqWLU+Dw7UJnIl8J8571ryklb+EQRwNBDxA0i0IQwtL0Mg= Received: from AM0PR05MB6707.eurprd05.prod.outlook.com (10.186.174.145) by AM0PR05MB4626.eurprd05.prod.outlook.com (52.133.57.29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2729.22; Thu, 20 Feb 2020 11:25:40 +0000 Received: from AM0PR05MB6707.eurprd05.prod.outlook.com ([fe80::adbd:45ca:54:bba9]) by AM0PR05MB6707.eurprd05.prod.outlook.com ([fe80::adbd:45ca:54:bba9%7]) with mapi id 15.20.2750.016; Thu, 20 Feb 2020 11:25:40 +0000 From: Raslan Darawsheh To: Suanming Mou , Slava Ovsiienko , Matan Azrad , Dekel Peled CC: "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [PATCH] net/mlx5: fix incorrect set VLAN ID action offset Thread-Index: AQHV5y8JMPRkPM0pq0iij2mwRynu+6gj8oiA Date: Thu, 20 Feb 2020 11:25:40 +0000 Message-ID: References: <1582121717-53976-1-git-send-email-suanmingm@mellanox.com> In-Reply-To: <1582121717-53976-1-git-send-email-suanmingm@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=rasland@mellanox.com; x-originating-ip: [212.29.221.74] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 4dae1529-590d-4f5c-9c3f-08d7b5f79dae x-ms-traffictypediagnostic: AM0PR05MB4626:|AM0PR05MB4626: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6790; x-forefront-prvs: 031996B7EF x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(376002)(136003)(39860400002)(396003)(366004)(346002)(189003)(199004)(9686003)(55016002)(26005)(450100002)(478600001)(52536014)(4326008)(186003)(2906002)(5660300002)(71200400001)(316002)(64756008)(76116006)(66556008)(66946007)(66476007)(6636002)(8676002)(66446008)(33656002)(86362001)(110136005)(6506007)(53546011)(8936002)(81166006)(81156014)(7696005)(54906003); DIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR05MB4626; H:AM0PR05MB6707.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: obdY87/7YXJHkamxx3V/uWTOxWvE386Q3RXzxl78IhvVGLTaE/bRDYsJ4Lc6v86z8nGYhaVH43+bmql4z5fi0ohJvcCJBrNnrdfncRyK6dWD0iYIL8tr+atpEjFKKYRdDPQPN++jhcQIiNkJOhg1x46Z/m0NabJNVXZdhkFAe1qt1oggp0Qws/aKmVwYgXvd5EMVKRsEsMG5kxqRFRdPGwhEtNwae7dWxF8xqKhD7sevkNPPGYXqY6DQ9bzyUC+HjY3EPAbhhrtf167wL4sM0mtsluoGeLMBKhRf+s2bPYbUlckfPjAzfzAKEoY+mid9JVemECOKyN/nv+WiOKGHwdXVEjwvWCKOw1ljeRH0Wf04HzIE71zRGdFbm9zIGNiUn8f4FW0YsUl6aZ5IqRaWe+uLuGukIbkQnfCaUMz3JeN+evl5ZD1xFIHOaO7dcHm6 x-ms-exchange-antispam-messagedata: g6FmR6cpgpaFhhMLyNwaYY+4RVSJyMw3go2dUOSuLzzqmqeYEtKSh6pzwyFh5P/JAC0mgZoCVNiBAgO04xl4lc5zcfzx389tIjuv7Fvx8YuR5+XzIHHEeAo0M8erzDqyHg73N2cbd+LJpX96KiWKaw== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4dae1529-590d-4f5c-9c3f-08d7b5f79dae X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Feb 2020 11:25:40.1637 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: QKeHhnuvL2z3A4PBnPiGfQOf46EWjk8ksjRaq1AgjX2QZpdrqirUfRne7DRBN7jxmsRgZjk6UQZ+nozAt3/aeg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR05MB4626 Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix incorrect set VLAN ID action offset X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, > -----Original Message----- > From: Suanming Mou > Sent: Wednesday, February 19, 2020 4:15 PM > To: Slava Ovsiienko ; Matan Azrad > ; Dekel Peled > Cc: dev@dpdk.org; Raslan Darawsheh ; > stable@dpdk.org > Subject: [PATCH] net/mlx5: fix incorrect set VLAN ID action offset >=20 > Currently, the set VLAN ID header modify action has already got the > action pointer with offset from the header modify action array, but > the configuration saves the detail to the memory of action with the > offset again. It causes double offset to set the VLAN ID action to > the wrong place in the header modify array. >=20 > Remove the offset when get the action pointer to fix that issue. >=20 > Fixes: 5f163d520cff ("net/mlx5: support modify VLAN ID on existing VLAN > header") > Cc: stable@dpdk.org >=20 > Signed-off-by: Suanming Mou > Acked-by: Dekel Peled > --- > drivers/net/mlx5/mlx5_flow_dv.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/net/mlx5/mlx5_flow_dv.c > b/drivers/net/mlx5/mlx5_flow_dv.c > index 359a037..5950274 100644 > --- a/drivers/net/mlx5/mlx5_flow_dv.c > +++ b/drivers/net/mlx5/mlx5_flow_dv.c > @@ -637,7 +637,7 @@ struct field_modify_info modify_tcp[] =3D { > const struct rte_flow_action_of_set_vlan_vid *conf =3D > (const struct rte_flow_action_of_set_vlan_vid *)(action- > >conf); > int i =3D resource->actions_num; > - struct mlx5_modification_cmd *actions =3D &resource->actions[i]; > + struct mlx5_modification_cmd *actions =3D resource->actions; > struct field_modify_info *field =3D modify_vlan_out_first_vid; >=20 > if (i >=3D MLX5_MAX_MODIFY_NUM) > -- > 1.8.3.1 Patch applied to next-net-mlx, Kindest regards, Raslan Darawsheh