From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B7745A04AF; Sun, 3 May 2020 10:47:58 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 023F11D54F; Sun, 3 May 2020 10:47:58 +0200 (CEST) Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2041.outbound.protection.outlook.com [40.107.22.41]) by dpdk.org (Postfix) with ESMTP id 570441D542; Sun, 3 May 2020 10:47:56 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bfpBJQ3RiPo4FTML9vbGHSR2Wz2njnZBKky/OBPTX/TM0jf8etTRvDHFcdgiVPV/TzYGoBP0IOVxR6RBxxbTZblF0jilU1Qk0YKkpir1Ova8Sav7hAdCm8ck1XYG5RMWMoJb43PJXQHBgUf1zc2GWVAXLl1aEo7i4vkc9XnMIppI1uv6kkiX1044Y3vIJnyk0uk1bVd6BsNPYkgIEshv9a5zMC40rneWsRrrMC7R3kkIOUt+e/OyEvhOvT7dCqfKdIVAdFT7WOMW38y0NU41ZShoOT74/rlJbaj9uzfkhh4HmEAo1GgYGgewFlFZMpMu7WlZb9bLPta4VazhnFpmxg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=P5Erfl012ROcLlTAmAuOJfi5+Rw9ZJw6HogKAQZCgAA=; b=iuJG8BNcjG9cpZFWOtcHg/KXT8vLniordS6RJBdrYJdFu655bDtSpbpAf6Gvs6BM8cIUJvISrT1BrFj+OHtVFxNnyHJAtFTGv/x1yr/xGtF/P+MQy4wJva5BS0BMTxqHerb6XZF1Q9/qgXejrriyXKT3KARlUoiUSDS+yxQMKHGQIvZpg7h6IMPht0SGaCJ1BkXMhD+Vw5sGsPTzsmXuIuky04jBtWZqkaHcdD+ZY5cpU/qQYVMaE30HeOo/rNafvHvi7/MuV9tfkMX5As3kgqtO9wR9F5WnQiN8HWh8g1ycaIWUNtKpWVwYb5UyI3Z9kjc+beDj9V303iBfr6txBQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=P5Erfl012ROcLlTAmAuOJfi5+Rw9ZJw6HogKAQZCgAA=; b=EpYxyVrYAglzdJ2KUVBu5QLJy3GrFEJR8uQrplVeFRoXZhpAWwIWCTtUetl0CxNpDaSUYwP2/1C5kFKiW+qWvderQnsFj56B9sXDiWhFNXUZWY12xfEzNmUKPz90WGW4bU0FtRO9M9Pt1UU4EyW0wg0/uAmqeAYqCiIXjhSTWb4= Received: from AM0PR05MB6707.eurprd05.prod.outlook.com (2603:10a6:20b:15b::17) by AM0PR05MB5233.eurprd05.prod.outlook.com (2603:10a6:208:e9::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2937.22; Sun, 3 May 2020 08:47:44 +0000 Received: from AM0PR05MB6707.eurprd05.prod.outlook.com ([fe80::508:747b:cc12:5f6e]) by AM0PR05MB6707.eurprd05.prod.outlook.com ([fe80::508:747b:cc12:5f6e%5]) with mapi id 15.20.2958.029; Sun, 3 May 2020 08:47:44 +0000 From: Raslan Darawsheh To: Jack Min , Matan Azrad , Shahaf Shuler , Slava Ovsiienko CC: "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] net/mlx5: fix default rule do RSS regardless rxmode Thread-Index: AQHWHiY5MDcU9S+gW02xxF3W8ZTuwKiWEqSg Date: Sun, 3 May 2020 08:47:44 +0000 Message-ID: References: <208bd4b9828bf89cba4d546f9091e2807d478502.1588164500.git.jackmin@mellanox.com> In-Reply-To: <208bd4b9828bf89cba4d546f9091e2807d478502.1588164500.git.jackmin@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: mellanox.com; dkim=none (message not signed) header.d=none;mellanox.com; dmarc=none action=none header.from=mellanox.com; x-originating-ip: [188.161.230.216] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 5bd37c66-0859-4711-5e1e-08d7ef3ea5c1 x-ms-traffictypediagnostic: AM0PR05MB5233:|AM0PR05MB5233: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4303; x-forefront-prvs: 0392679D18 x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM0PR05MB6707.eurprd05.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(346002)(39860400002)(376002)(366004)(136003)(396003)(52536014)(86362001)(186003)(54906003)(2906002)(66556008)(8936002)(316002)(110136005)(71200400001)(76116006)(66946007)(66446008)(64756008)(66476007)(26005)(6636002)(4326008)(9686003)(55016002)(450100002)(7696005)(33656002)(53546011)(6506007)(478600001)(5660300002); DIR:OUT; SFP:1101; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 5UVTn4g9KXNYcFzqRXk5JHFN2bY5Cldvs+Rk4e1bsNOzUmHgYskb7NX6cI+A9ipRgOYSF7NruHo9zfes99toW3ECFJmQ/imSl49K2oeg8DiFSNvvMviSjDn72ftyxuKiieCrE28d9pJT65esVNYbXxH0jEqYIY8eySPt6CdM98DMWxop/Nv0FaVrzfsBCLMyeszXNXQy0TwwZEHazj++9gjFl6iDvElnbCMC7gSdXqM2fkVeWiGarzmrdJ0ZWE2rqsd8vCgLbgcg2P4ubGMbOfZgwrjMfZI2qkMEHGVA2iuuYJ7ncAdK8tNSjUNYYr6jN7mVrQvuIbUsyW7+SQljNBwmNCHv/csUdUDFkaLouInNlw2mHEKkg9NIaNuBIG4R5FjZJwy92dlM3Gjj4XWFgK4tinruXdJFC30TDas/NkFYRYVc8SNxtMA3cDynpCD7 x-ms-exchange-antispam-messagedata: 9kngVlXYWzshjQNgyMX9Y8XvvVohakZoi145UcTx4Buj9WSVcd6bYhWgCexfCAaC7DI5EYUv5fYDSeS4t5lXojfAdUKjXO41EGT+uWsiflWAIR1p+k3uIvQ8UYtZOAojt10r7H6y3NXPggvonvbFZs3piyLLmESuuxsCirtKKX+VcdNg+M2vuJhmf3jKcc/dyzwFXtBFGKnMExRg5pcZC6vpP8xo7JD7uM5GTFP7MXyZjkZhq9PMF2afAxrxGvcov6igrwj9+i8qTmOaCrSmIIzEoJWKQhxKCJRt4+yCWaYoBGWGk2JpsoeWYsadxKec1cNCGvlzCKR62QsVRD5ZCFAMfwchO4/wIRcDuuPm6Ua+shjDLLj+iRNIfv7AOscBRJHcX/qXPQpX4p70C+ovMDwPl6rbW7tIS0czuoq+ggneOrVqAiRWPt6c05BWMOVzSYv9YLSvc+sTpg85CdVltxSMl1M3BtdaE0J/m0mF3sTNlzlUGCHB2eXslAuT8lgP7syTI+XESKP/V9AA2A8IYudUR8y6O2zxaZkmTtD3WR28mnBFh/ceF9nikoO4+lAeVdqyXyvl6s54WP0UCMfvQeNBLpXhVsxMmBBVPEhr3j4tXhXjDn4hcCQBYvlb1QrgFFFamPmHlY21ejFr+yZdkqYUtmXsnHtTQxpyyIqbm1LmyVgoFujXWyq9X+towqNpgPLxDojO2/15mFVGIBZOGcWrqtCrfh2xAmMtXVhYl/KbsDYkNPw+J9q7IMnqU6/NJCeYlMXc0c9QtUNNri3H+W6rV8KuuXhNPiiOxd+uq52T1m6lWAuMOZDaSzMxQ/z5 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5bd37c66-0859-4711-5e1e-08d7ef3ea5c1 X-MS-Exchange-CrossTenant-originalarrivaltime: 03 May 2020 08:47:44.3142 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 4qMlN+3rb2GqxcKyD07JMLZq2lPES+ZRUHWLE1HcoiGfahOXn/9SMyiJc9YsplUWq1HzGNneYeKterwF3ilEkg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR05MB5233 Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix default rule do RSS regardless rxmode X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, > -----Original Message----- > From: dev On Behalf Of Xiaoyu Min > Sent: Wednesday, April 29, 2020 4:01 PM > To: Matan Azrad ; Shahaf Shuler > ; Slava Ovsiienko > Cc: dev@dpdk.org; stable@dpdk.org > Subject: [dpdk-dev] [PATCH] net/mlx5: fix default rule do RSS regardless > rxmode >=20 > PMD create some default control rules with RSS action > if it's not isolated mode. >=20 > However whether default control rules need to do RSS or not should be > controlled by device configuration, the mq_mode of rxmode configuration > in specific. >=20 > In another word, only when mq_mode is configured with > ETH_MQ_RX_RSS_FLAG > set, then RSS is needed for default rules. >=20 > Fixes: c64ccc0eca2f ("mlx5: fix overwritten RSS configuration") > Cc: stable@dpdk.org >=20 > Signed-off-by: Xiaoyu Min > --- > drivers/net/mlx5/mlx5_flow.c | 2 ++ > 1 file changed, 2 insertions(+) >=20 > diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c > index e9ae2f782c..cb593c9449 100644 > --- a/drivers/net/mlx5/mlx5_flow.c > +++ b/drivers/net/mlx5/mlx5_flow.c > @@ -4912,6 +4912,8 @@ mlx5_ctrl_flow_vlan(struct rte_eth_dev *dev, > if (!priv->reta_idx_n || !priv->rxqs_n) { > return 0; > } > + if (!(dev->data->dev_conf.rxmode.mq_mode & > ETH_MQ_RX_RSS_FLAG)) > + action_rss.types =3D 0; > for (i =3D 0; i !=3D priv->reta_idx_n; ++i) > queue[i] =3D (*priv->reta_idx)[i]; > flow_idx =3D flow_list_create(dev, &priv->ctrl_flows, > -- > 2.26.0 Patch applied to next-net-mlx, Kindest regards, Raslan Darawsheh