From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 16CD2A00C5; Thu, 30 Apr 2020 11:50:56 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 528E31DAED; Thu, 30 Apr 2020 11:50:55 +0200 (CEST) Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-eopbgr30053.outbound.protection.outlook.com [40.107.3.53]) by dpdk.org (Postfix) with ESMTP id 86C051D979; Thu, 30 Apr 2020 11:50:54 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=f2gBF+c+eEwHgfE1hNk+cmLWx1inXfcFxtvi/gm6pVQOYZprI/3kP+84sJRw1/W6ThpKTQ+bTVCGf+e517e5Ra7MHo6rChu/aTU/mLOc5UvCxvB4b0an3ND4PT0FWyEJGDuymGSE4VSxKgCEi0CQbvbEHg4lRlCqM6CUNWJuNf9loqHjn6tofUvJ9+LuygXrMgD3m9hAA91TjpCOQ862Ei4w/APODluqhG/VGTRysEoiM3iqCDdJCDJYmtZCHI3OfXLzTx3P/4GYdZTamtOSPf5L+ReI83Fud7L4gWS7EsoB8iXE0bYiul6K1MZOAezAjEVXu4zEYTVYQiXnwUrtLA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pWufSZhEtxE/kmBAPjb3DAoFvoDsv586uNY24fuqaIE=; b=HUfLUdgQaz7+LgXpzIVkO2aY0uSuJN0xaNzUVnfhWNLuhu+AAZr7LGDe6wCq8JutiLL4vpoqYpQoXUiUWEM8+jJnaWtFL+QouAEEMKqukM/25gc1MKGdqAUPeaUZKd8kwQnMKYaMAiKCYHnEYVOc1YLR+p7Ae2xjagyXTlFBuQoiyribxe6DLFreePGpimPdqEwJZ6OA8fywtXVygSuNofrW82/xO/uvlXSf6nX6POHqmSVtzSOlXBQTLlzmx+OmJRanpVtzdSApfwQ6bWYdaWPq60SplBx56c+jFRLsLfKqHXrOACJBEKegpyT0PG3cr7iNUtj3PwHt3BkQ3bUvNQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pWufSZhEtxE/kmBAPjb3DAoFvoDsv586uNY24fuqaIE=; b=P4phzTvg6EUooc++NPwr9IQZQp7R3BXk4bDB7KCmMFa0kUjZDZPv+AodbBAz4fYQUh6QmMyge/Rr8xmycP13/Rrttgr66HI/AFZ5SEUNC2mjSCttHYUxYZV+xxtwowtJDhEWjq6KesG80CCZuT41x0mmmeb7KLMAREd1okvxVtY= Received: from AM0PR05MB6707.eurprd05.prod.outlook.com (2603:10a6:20b:15b::17) by AM0PR05MB4514.eurprd05.prod.outlook.com (2603:10a6:208:af::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2937.22; Thu, 30 Apr 2020 09:50:53 +0000 Received: from AM0PR05MB6707.eurprd05.prod.outlook.com ([fe80::508:747b:cc12:5f6e]) by AM0PR05MB6707.eurprd05.prod.outlook.com ([fe80::508:747b:cc12:5f6e%5]) with mapi id 15.20.2958.020; Thu, 30 Apr 2020 09:50:53 +0000 From: Raslan Darawsheh To: Alexander Kozyrev , "dev@dpdk.org" CC: "stable@dpdk.org" , Slava Ovsiienko Thread-Topic: [PATCH] net/mlx5: fix packet length check assert in MPRQ Thread-Index: AQHWHMD6o0x/oHyHnECc+FLFxaDEI6iRcBVw Date: Thu, 30 Apr 2020 09:50:53 +0000 Message-ID: References: <1588011793-17125-1-git-send-email-akozyrev@mellanox.com> In-Reply-To: <1588011793-17125-1-git-send-email-akozyrev@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: mellanox.com; dkim=none (message not signed) header.d=none;mellanox.com; dmarc=none action=none header.from=mellanox.com; x-originating-ip: [188.161.230.216] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: bdfb2b4e-d31d-450b-d8d2-08d7ecebf92f x-ms-traffictypediagnostic: AM0PR05MB4514:|AM0PR05MB4514: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2582; x-forefront-prvs: 0389EDA07F x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM0PR05MB6707.eurprd05.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(366004)(136003)(346002)(376002)(39860400002)(396003)(186003)(71200400001)(64756008)(55016002)(9686003)(66946007)(66556008)(66446008)(66476007)(76116006)(52536014)(7696005)(6506007)(8676002)(26005)(86362001)(53546011)(478600001)(33656002)(107886003)(110136005)(4326008)(54906003)(8936002)(2906002)(5660300002)(450100002)(316002); DIR:OUT; SFP:1101; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 0jMGZAkjfBwwBrZ5gapgVfZUBXnVf08nDeBtTew03RgX7yjyQT3gUaBVNwoNbAhEu4IVYdBAcPjT5pmeNizEDEDJ34zU6xvLXHU+bJjDNddIVWrEb/P3A5d+CafkQnhUkFZ6j6ZVvuZCV+JDIzK14wGnnFPJfiQL9hon5w1R0jbwfYprxAFa8zD5RfVzbt+l0HeXNGKxY/lR6fBGBnTRqlnvp7La1UmRf/KqxEOj/AJouHsQ8bszX+9GrulnKx11UcvB73uFWREKK4Y1wV67rShjXOxXNksy5JS/iy3vuND96cpdT8MrII2+PtWv4Zyum5163IdS6OfwDmd/5pfCLxEEmRGW7KPJX8QNdAxNc128eqHCg7sGqMfmbVFJDH8YIY74dpBQp+HTBYTbiqLEz2WpgZO/dfN6Bq92odV7Ydk6jWbO275tCWwvZ00A/4tU x-ms-exchange-antispam-messagedata: bnbI/cWl4J+MUlRVG4bjn2ve5fG5oBUV4SkWSyHxtK0UP4Xep3g304uxd3YHpH2qoaW/0jFDE5f9VHBqmPTEcwVMMLpLRpKQUzbjhn8Xkkff0y3edOJ11b2fsVqqAbROk+HhfTCqNd10rKJZ2TH4/PxDKXEqzI7V85UUM2gMt9aVD6/O142IaSnFQpvEqGKT4dkjEc8UHjB1zxISATzDnTQqFCpEZt+ymTKJNSfM111q1zzHYHAgHYuOctvCCWUDul6BDYnQpGEkZIre+vWCQJO1jc9+AZKj5vxuNI8ojI2Jy7Q+q9Iv4LlVYqelntF8T8zXZasH4NPHKmWmqYSfbVVQv9PGiGA3aveheUOfzc15xT0udR3RGj7zAHTwANpFjsx5/p7x8tVThyiEr7+1W+AQ7FaqIABxlvMJ9i7wthmMA7UH6dAQJ9Fy7K6C7pbMisaU2sLpnMQpgmROP7ldIvH/sAFliMbfNRysBip2ST8afz7LViWZv+MSy9Rj9POE3b/nhpSANOBiyD9x/qvNsJ7jxoezQW4HFoJHvrpWXvE+pad5KdCHsTysAUOqyhsUrefVTx1rSQGkAHINxZJYZTQXr4bUQxQ/z2dHJWhrv2q6M3mDB8qkxQvrx38iLymKiv/jHRnyIqq6oqjaLH6VmumPLtiDfXcVM74gzp6Wh2zatHZYef9ywA+CuFmJ1tz4Y2ji4jF+FmpiFr4kl40gP/nZjLGj8PKo0vbnEjrqhlzlWrMisK8PFaXGpJUQfMsty24U0ZhSYt0P7CZ5f6hdwX3mlKsnzacm+x9paxnLZHiZ6sJeacT1tnXPkqFk+8+6 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: bdfb2b4e-d31d-450b-d8d2-08d7ecebf92f X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Apr 2020 09:50:53.6922 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: zZXIO5tWlUp+ARs5jUiGJtQCqlKihPM6Jz1ie783oqcGilnP1+0Omkz1V+/WLh3/xkY5aaKs8fuf9/atZ5dWHg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR05MB4514 Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix packet length check assert in MPRQ X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, > -----Original Message----- > From: Alexander Kozyrev > Sent: Monday, April 27, 2020 9:23 PM > To: dev@dpdk.org > Cc: stable@dpdk.org; Raslan Darawsheh ; Slava > Ovsiienko > Subject: [PATCH] net/mlx5: fix packet length check assert in MPRQ >=20 > The assert that checks if there is a enough room for the > whole packet minus headroom data is written incorrectly. > The check should be negated in order to work properly. >=20 > Fixes: bd0d593 ("net/mlx5: enable MPRQ multi-stride operations") > Cc: stable@dpdk.org >=20 > Signed-off-by: Alexander Kozyrev > Acked-by: Viacheslav Ovsiienko > --- > drivers/net/mlx5/mlx5_rxtx.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/net/mlx5/mlx5_rxtx.c b/drivers/net/mlx5/mlx5_rxtx.c > index a212010..6a17a9a 100644 > --- a/drivers/net/mlx5/mlx5_rxtx.c > +++ b/drivers/net/mlx5/mlx5_rxtx.c > @@ -1814,7 +1814,7 @@ enum mlx5_txcmp_code { > /* Set mbuf head-room. */ > SET_DATA_OFF(pkt, RTE_PKTMBUF_HEADROOM); > MLX5_ASSERT(pkt->ol_flags =3D=3D > EXT_ATTACHED_MBUF); > - MLX5_ASSERT(rte_pktmbuf_tailroom(pkt) < > + MLX5_ASSERT(rte_pktmbuf_tailroom(pkt) >=3D > len - (hdrm_overlap > 0 ? hdrm_overlap : 0)); > DATA_LEN(pkt) =3D len; > /* > -- > 1.8.3.1 Patch applied to next-net-mlx, Kindest regards, Raslan Darawsheh