From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E6377A0597; Tue, 21 Apr 2020 15:28:08 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4FE301D506; Tue, 21 Apr 2020 15:28:08 +0200 (CEST) Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-eopbgr00084.outbound.protection.outlook.com [40.107.0.84]) by dpdk.org (Postfix) with ESMTP id D7C2E1C0DC; Tue, 21 Apr 2020 15:28:07 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=V5N+S5Q/emoI/bR0GmQ4vPQkffa1naQM9l7oDQx5CZv1T/eMLp1CM2APTtATs7XiARTpUIAktgopuxxcwLYpmcl8C1MzQ88I/6x34OyrVOy8BZHrqfz1KRwyGmGEaQHzStUFmj0O647wyW64r7U/B64RmtI9qExW32sEX2QAajnODJ+GFqsRY/UPeYh4XyW2KWRBfq67bu3bgPAwKUek8EH3u/PmvRrrmcn1k7pPcOSEbce0+0tMP9iIRd7Hplaig/Qgvv/SkC204DB8eDN/L/BA3uTYk80UZma5WEzCcxdBfqJG4dnP1JKPE0lmzFJS3VsZVOPziVWa6PsP37+wQw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8CgN8PWzqmcjT+zJLSEuWK5tFDJGHG/eRP9n68W0qzU=; b=TjLJlhm1buZtRzkBXybLDHRPyVbXKACZgqsK6yhDeD/7rnMMjChYZALILguz72iNDXP6rcPc7miRuiR7Wp9jo+YOFRq2Dl42gDDu75YWzSkAqIRrx22BbaGASqabk8n8Viq1JQurjpFlgTjinpC/DyM3Px65wftHenHSlFTjs5+KazIuGW/gkeR+/puEa9VLrhvwz8YuN2dGEo0sQX6fOFwFZLouJWPmNclkqiYqJB2ImxKOVENFg5MJ0ttW55okhiYVlN+YQ98mzYcK+yHAVyL437ThfaBFhcme6ZSw/i9CUgYaTBJ6gKP/IOhPq5gWGvB0Tt/UYp3mE4ksHPp4xA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8CgN8PWzqmcjT+zJLSEuWK5tFDJGHG/eRP9n68W0qzU=; b=DTjIK7NCVM8HU1LD+Hv8VvL71vU1FrgwePlXNTYhwthjcOgMzouhTTlujf1pYhkN6XDw22kb+VlxCJ3A+GslGSavMtcZYCl/i9GlEqelyM92F8XCrtKPqqCcV+/08cI0miEFTMe50UAXJZZUNHN0dCNMArW3gVpda4fw6rDhrQI= Received: from AM0PR05MB6707.eurprd05.prod.outlook.com (2603:10a6:20b:15b::17) by AM0PR05MB4945.eurprd05.prod.outlook.com (2603:10a6:208:c0::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2921.29; Tue, 21 Apr 2020 13:28:06 +0000 Received: from AM0PR05MB6707.eurprd05.prod.outlook.com ([fe80::508:747b:cc12:5f6e]) by AM0PR05MB6707.eurprd05.prod.outlook.com ([fe80::508:747b:cc12:5f6e%6]) with mapi id 15.20.2921.030; Tue, 21 Apr 2020 13:28:06 +0000 From: Raslan Darawsheh To: Thomas Monjalon , "dev@dpdk.org" CC: "stable@dpdk.org" , Matan Azrad , Shahaf Shuler , Slava Ovsiienko , Dekel Peled Thread-Topic: [dpdk-dev] [PATCH] common/mlx5: fix build with rdma-core 21 Thread-Index: AQHWFAgGUG4gfPvLf0+d3HZGRkk1z6iDmT4w Date: Tue, 21 Apr 2020 13:28:06 +0000 Message-ID: References: <20200416155904.2723690-1-thomas@monjalon.net> In-Reply-To: <20200416155904.2723690-1-thomas@monjalon.net> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=rasland@mellanox.com; x-originating-ip: [188.161.228.234] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 40a64fd3-bd46-4d83-287e-08d7e5f7d390 x-ms-traffictypediagnostic: AM0PR05MB4945:|AM0PR05MB4945: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6108; x-forefront-prvs: 038002787A x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM0PR05MB6707.eurprd05.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(10009020)(4636009)(366004)(81156014)(33656002)(107886003)(8936002)(26005)(498600001)(55016002)(71200400001)(186003)(6506007)(53546011)(9686003)(66556008)(66446008)(66476007)(64756008)(76116006)(86362001)(8676002)(5660300002)(4326008)(66946007)(2906002)(110136005)(52536014)(54906003)(7696005); DIR:OUT; SFP:1101; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: wwv3SE92fl5oxbdpWLN73wQufy7MFsSlBGLSR89M7gv+Qux4G7yX5iCUqiDLDd0CIZ05coZyNoG9IjrcEo2LSuzXX/C59Ajy77RaeZLrqHgczm6OSFR7oM/WRVI+/RhRv1/Kmu4qfbJj5kzhV02cLtYsra/tPVuks0dOFIECJM1oJ0HQuMLNAaRth0PGohz93ahJJaWS1zPdgcF7A13uOlxAUhc0Jwmn3vCiO8UwRp5lA278phwePJfu9EOpcHR7EQTmUAV28v32SvvsfJLXaW1c5fhlruaEAw7OmzzQNfg9L6KBJqSBAIwVDrBRAWw8jxy649PLFiSSvYWY+Nmh/NkV7gkEzSzPXMXKrOpwnyiRJdyTG1tp/IEAAyotjpp5ZR1QMftrM6uKICVEH3tEvQhp1FH3BGPL9z2VpEKaPMhEmixUqOJzTkKxgK7cUhDg x-ms-exchange-antispam-messagedata: cHVUSXScGnogaQQnNBty17ejhzvzz21aV/s1k2o9tMXUp5NsiKCDBQme2cKkMarB4GHG5FLuVB4st4t9Pn+5J74FS3bb7F51F5efakU2rYnkEue50rVsWsvB7jfmoE7Hek7riRQ+2VIZ9nE4ikeJmg== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 40a64fd3-bd46-4d83-287e-08d7e5f7d390 X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Apr 2020 13:28:06.4162 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 1Km++UyNGWaZziHH5+Hh8DY0phhSvNOi8sWq8voCZnUYEOQncSXFcdJm322gaeXZcTKE6KeIlmVpE+0t1Pv4TA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR05MB4945 Subject: Re: [dpdk-dev] [PATCH] common/mlx5: fix build with rdma-core 21 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, > -----Original Message----- > From: dev On Behalf Of Thomas Monjalon > Sent: Thursday, April 16, 2020 6:59 PM > To: dev@dpdk.org > Cc: stable@dpdk.org; Matan Azrad ; Shahaf Shuler > ; Slava Ovsiienko ; > Dekel Peled > Subject: [dpdk-dev] [PATCH] common/mlx5: fix build with rdma-core 21 >=20 > drivers/common/mlx5/mlx5_glue.c: In function > 'mlx5_glue_devx_qp_query': > drivers/common/mlx5/mlx5_glue.c:1010:9: error: > implicit declaration of function 'mlx5dv_devx_qp_query' >=20 > The function mlx5dv_devx_qp_query() was added in rdma-core 22. > This function is compiled only if HAVE_IBV_DEVX_OBJ, > which is true if the function mlx5dv_devx_obj_create is found. > Unfortunately mlx5dv_devx_obj_create() was introduced in rdma-core 21, > when mlx5dv_devx_qp_query() did not exist yet. >=20 > A new flag HAVE_IBV_DEVX_QP is added when mlx5dv_devx_qp_query() > is found. >=20 > Fixes: 62d6f70f30f4 ("net/mlx5: add glue for queue query via DevX") > Cc: stable@dpdk.org >=20 > Signed-off-by: Thomas Monjalon > --- > drivers/common/mlx5/Makefile | 5 +++++ > drivers/common/mlx5/meson.build | 2 ++ > drivers/common/mlx5/mlx5_glue.c | 2 +- > 3 files changed, 8 insertions(+), 1 deletion(-) >=20 > diff --git a/drivers/common/mlx5/Makefile > b/drivers/common/mlx5/Makefile > index f32933d592..22dc4b2eb4 100644 > --- a/drivers/common/mlx5/Makefile > +++ b/drivers/common/mlx5/Makefile > @@ -150,6 +150,11 @@ mlx5_autoconf.h.new: $(RTE_SDK)/buildtools/auto- > config-h.sh > infiniband/mlx5dv.h \ > func mlx5dv_devx_obj_query_async \ > $(AUTOCONF_OUTPUT) > + $Q sh -- '$<' '$@' \ > + HAVE_IBV_DEVX_QP \ > + infiniband/mlx5dv.h \ > + func mlx5dv_devx_qp_query \ > + $(AUTOCONF_OUTPUT) > $Q sh -- '$<' '$@' \ > HAVE_MLX5DV_DR_ACTION_DEST_DEVX_TIR \ > infiniband/mlx5dv.h \ > diff --git a/drivers/common/mlx5/meson.build > b/drivers/common/mlx5/meson.build > index ac2cfa6236..6f007eea1b 100644 > --- a/drivers/common/mlx5/meson.build > +++ b/drivers/common/mlx5/meson.build > @@ -118,6 +118,8 @@ has_sym_args =3D [ > 'MLX5DV_FLOW_ACTION_COUNTERS_DEVX' ], > [ 'HAVE_IBV_DEVX_ASYNC', 'infiniband/mlx5dv.h', > 'mlx5dv_devx_obj_query_async' ], > + [ 'HAVE_IBV_DEVX_QP', 'infiniband/mlx5dv.h', > + 'mlx5dv_devx_qp_query' ], > [ 'HAVE_MLX5DV_DR_ACTION_DEST_DEVX_TIR', > 'infiniband/mlx5dv.h', > 'mlx5dv_dr_action_create_dest_devx_tir' ], > [ 'HAVE_IBV_DEVX_EVENT', 'infiniband/mlx5dv.h', > diff --git a/drivers/common/mlx5/mlx5_glue.c > b/drivers/common/mlx5/mlx5_glue.c > index 0af0b86677..e2d3beb9cc 100644 > --- a/drivers/common/mlx5/mlx5_glue.c > +++ b/drivers/common/mlx5/mlx5_glue.c > @@ -1006,7 +1006,7 @@ mlx5_glue_devx_qp_query(struct ibv_qp *qp, > const void *in, size_t inlen, > void *out, size_t outlen) > { > -#ifdef HAVE_IBV_DEVX_OBJ > +#ifdef HAVE_IBV_DEVX_QP > return mlx5dv_devx_qp_query(qp, in, inlen, out, outlen); > #else > (void)qp; > -- > 2.26.0 Patch applied to next-net-mlx, Kindest regards, Raslan Darawsheh