From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 23F29A00C5; Sun, 26 Apr 2020 13:01:03 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C09A71BF9E; Sun, 26 Apr 2020 13:01:01 +0200 (CEST) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70074.outbound.protection.outlook.com [40.107.7.74]) by dpdk.org (Postfix) with ESMTP id D76471BF8E for ; Sun, 26 Apr 2020 13:01:00 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KrkHDI7B2jDVGctKO5Mu9ZE6pDJmpBwDYwBogvqfptr8UKXwetJ26kxQGrIbVL+84h55N34ggCh05nKXRjhqvmSi+wpM0TfG0ntcowlPSqIhApeAWt4N+t8VgTIg5/1Nu0u4qIQDuWsMMUbjyEJrpWKRiRE8O6MWgmaDJci01m6VQUVv9/4/OfMr23BMChHRjcXXAJEGo9p7jETTwO+rvhtu4Qa8nbSoR1jtr4EfYHZ2JOB+AZ7uUfzJMBQIGWGvNWV66QR3Fo6V3sMDcrziZDPdeUT9+zFi0dkadqREmOOkv1dvjO/t0agdNvCgsG9ArEDTh+61lGhgvqWJbJwaKQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ye5Coz48JG6Uhti7D2HIDI+H2wRDsMvwTqQtGIZSx4g=; b=c92gosbBnvmBoXFuiSj4EvWeOIOeqcdaaoMvDkyGM/+WBLfix8YGvWQ63FKjUBEppQKJ+xxvaqL58pc87NJJT0vM09KhH5kAyu82ZpPAGRs3jWYpG2Ca+Psf2iacuFC3w4MH563M6g6/UrvY9fi1zff5WlybNujnQGBADXxBY0/f4eHxvO2g6iVOTHSUeDaI/e6CipR4FdtUu/30I1Sb5f9RS4+qm7AHwaI8P+FoBclpLmsTZDug+ZcqvA9LOrnIaJZm0gRffgePDzVe0N0jNzFQqTSOpl3y6U7qZwfpTbkVOPIvn8mCeLzKcPtZfCMRluZrwg1n9AYFAp0kZ9bM9A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ye5Coz48JG6Uhti7D2HIDI+H2wRDsMvwTqQtGIZSx4g=; b=RvR0L5NIU0YY6k30pdJCivgjKPyeN3WrApjQjPCCJPtmeUiXAXazsMU6Wfw/5yuQCSxLP5msEoDhHp0T1LD2T0y2qB9V6Cx20E36+DjBA9v4QiYq3HpI2UZY7CJM5l5y5Gooa9AEEtDeMGARktsQvvDBD9Gm+g/E2BF5EhROwmg= Received: from AM0PR05MB6707.eurprd05.prod.outlook.com (2603:10a6:20b:15b::17) by AM0SPR01MB0078.eurprd05.prod.outlook.com (2603:10a6:208:156::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2937.13; Sun, 26 Apr 2020 11:00:59 +0000 Received: from AM0PR05MB6707.eurprd05.prod.outlook.com ([fe80::508:747b:cc12:5f6e]) by AM0PR05MB6707.eurprd05.prod.outlook.com ([fe80::508:747b:cc12:5f6e%6]) with mapi id 15.20.2937.023; Sun, 26 Apr 2020 11:00:59 +0000 From: Raslan Darawsheh To: Thomas Monjalon , "dev@dpdk.org" CC: "david.marchand@redhat.com" , Anatoly Burakov , Li Feng Thread-Topic: [dpdk-dev] [PATCH] mem: fix build Thread-Index: AQHWG7gi6aG7wgAaOkmAlA4O8ASRC6iLPFYA Date: Sun, 26 Apr 2020 11:00:59 +0000 Message-ID: References: <20200426104725.2809101-1-thomas@monjalon.net> In-Reply-To: <20200426104725.2809101-1-thomas@monjalon.net> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=rasland@mellanox.com; x-originating-ip: [188.161.230.216] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: d340ef8e-d43c-4681-230c-08d7e9d11a7c x-ms-traffictypediagnostic: AM0SPR01MB0078: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1417; x-forefront-prvs: 03853D523D x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM0PR05MB6707.eurprd05.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(39860400002)(396003)(136003)(366004)(376002)(346002)(52536014)(86362001)(186003)(4326008)(478600001)(9686003)(55016002)(5660300002)(33656002)(26005)(6506007)(66446008)(8676002)(66476007)(66946007)(2906002)(54906003)(316002)(110136005)(64756008)(53546011)(7696005)(66556008)(71200400001)(81156014)(76116006)(8936002); DIR:OUT; SFP:1101; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ztIAt5zdyeunfWmekWkKzKl5zbL6HZj2QYVDqWVcbZ/DXwazOkaMqjS1LdWcIULjBfdhuETtvxzweKX2tl+PuOl9NOqkqm8uyol/8MerPbYU7w9nYhB7eusEs1vx9v41Z7/VTiKmW4ARA652bVV4tv/qpXjo+RS/oj2eKx7MNT/dbGWZ/mjtHPw0qlHmKrlmTO0sNTVnjOkbw5rsYA5uN33M9heqrZ/Ap+bZTq9tjWWRUtbnSpHpZbW77Hdj+r4Vdi0sCuS/NxxdHgzGJsU7BMXCeE91To60G5ClUx4kG9lIFpwGcvV671gkhZhMDqbqcsX/QISw9RPB4XwKXdR6CasA13p4vO1wsRTgLjOTCbbS/hJUib4Pog0/ECNgUHsyqbiHzuZx3j1VVHTv/P8raJtAEPU6dvZT44VdcwqA064ZyRJ0F2PI4yF9Agfjehtg x-ms-exchange-antispam-messagedata: ZEsWHrZ/YZktp3WU4/D/xfjFy4ie+CPhKABJiYWvBXM88uK7jG4+Gcp+Ij7b7RKLKZudUrvJRy5yuBXvd8rZFO/vaj3J4xkDrZKdrjXDEd/dvC3dK8umKa3dQZ8m0UkHCuSA1FXyy6IUU2M2ZxlJRET0OijI4fDgTWG0sxuqQEnYvd8r4Da5lfuRHru0jk4jNQW4q5LJwSibWu9srZkK20iXxq9MMIe7LfdtrWfY4HPFo57E9timpVr+AcHTJlfxpikxjF0+bmgdQ0AiUK4bxhL1ffoObOgWmElGKxKRbRwchdYS6Ujg4QE25lJZbGv/o0x8/0UPUp4oRh3IkepnpAwlOu2rdEdfvaigqOM6WGGoMO1GqyMGk28/0shs5S77SCNT2A+n0PAyrWESuG6/x4ghThuYSao5eagGJTkqHzsUFMGEWlaotZ0g90FwOTspzd12ZT/0rY43qZOj6A+JRRfsNekeWk7rvrAps3WbDHdcQDFSjZcsZu26Qv5ISbf4jqBiYbJXMelhS2hXDBDRkqboRw8bDAsE0G9x6sPzIyIfiLLDk9RyMTImF37igzyrt58QUDHlazDRwGA2cNwFMRikkFgiPdCHH39LTuD4jO5yHCV9XijaQGbFyN9MJv/te/Pmicx/hT0KuGda6PacsOwJAsCMl/bALlkEz9vCll3GOfDTyhmIwFb9g4e7sfQUg1kiOvl0kj8T0PL3r2QeBT1suNe2Pb6pMzSAu4c0rF9DPfaIls5dH0H2+kzlTeGI+TTR4dW11BRoXnoJPPSPZV6tPLlUvLBy4b6A3dbL5NSQeA47yZyEMqAY3ELfMkZL x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: d340ef8e-d43c-4681-230c-08d7e9d11a7c X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Apr 2020 11:00:59.6650 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: SsFSjJHGJvYxP6r44knVwxPlRoz9240gOFw5C/8NBAP4XX7pkmyk5OZxWdUdwrqg8D/e+tZh3ybKsx3MmDslsQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0SPR01MB0078 Subject: Re: [dpdk-dev] [PATCH] mem: fix build X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: dev On Behalf Of Thomas Monjalon > Sent: Sunday, April 26, 2020 1:47 PM > To: dev@dpdk.org > Cc: david.marchand@redhat.com; Anatoly Burakov > ; Li Feng > Subject: [dpdk-dev] [PATCH] mem: fix build >=20 > Some compilers (on RHEL7 and CentOS7) were getting this error: > error: "RTE_EXEC_ENV_FREEBSD" is not defined [-Werror=3Dundef] >=20 > Existence of a macro must be checked with "#ifdef" or "#if defined". >=20 > Fixes: d72e4042c5eb ("mem: exclude unused memory from core dump") >=20 > Signed-off-by: Thomas Monjalon Tested-by: Raslan Darawsheh > --- > lib/librte_eal/common/eal_common_memory.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/lib/librte_eal/common/eal_common_memory.c > b/lib/librte_eal/common/eal_common_memory.c > index 9a797a4fa3..4c897a13f1 100644 > --- a/lib/librte_eal/common/eal_common_memory.c > +++ b/lib/librte_eal/common/eal_common_memory.c > @@ -42,7 +42,7 @@ static uint64_t system_page_sz; >=20 > #ifdef RTE_EXEC_ENV_LINUX > #define RTE_DONTDUMP MADV_DONTDUMP > -#elif RTE_EXEC_ENV_FREEBSD > +#elif defined RTE_EXEC_ENV_FREEBSD > #define RTE_DONTDUMP MADV_NOCORE > #else > #error "madvise doesn't support this OS" > -- > 2.26.0 Kindest regards Raslan Darawsheh