Re: [dpdk-dev] [PATCH dpdk-dev v3] common/mlx5: fix dynamic loading reference

[Raslan Darawsheh <rasland@mellanox.com>]

Hi,

> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of
> xiangxia.m.yue@gmail.com
> Sent: Friday, March 6, 2020 4:27 PM
> To: Matan Azrad <matan@mellanox.com>; Ali Alnubani
> <alialnu@mellanox.com>
> Cc: dev@dpdk.org; Tonghao Zhang <xiangxia.m.yue@gmail.com>;
> stable@dpdk.org
> Subject: [dpdk-dev] [PATCH dpdk-dev v3] common/mlx5: fix dynamic loading
> reference
> 
> From: Tonghao Zhang <xiangxia.m.yue@gmail.com>
> 
> When setting the CONFIG_RTE_BUILD_SHARED_LIB to y,
> and build the mlx5 pmd, there is a building error.
> To fix it, add RTE_IBVERBS_LINK_DLOPEN to include
> relative codes.
> 
>     mlx5_common.o: In function `mlx5_glue_init':
>     drivers/common/mlx5/mlx5_common.c:324: undefined reference to
> `dlclose'
> 
> Fixes: 7b4f1e6bd367 ("common/mlx5: introduce common library")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Tonghao Zhang <xiangxia.m.yue@gmail.com>
> Tested-by: Ali Alnubani <alialnu@mellanox.com>
> ---
> v3:
> * rename the patch title
> * mv the dlfcn.h to define area
> * tested:
> https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Ftravis
> -ci.com%2Fovn-open-virtual-networks%2Fdpdk-next-
> net%2Fbuilds%2F151882661&amp;data=02%7C01%7Crasland%40mellanox.co
> m%7Cc089a6504673460ee42c08d7c1da91c5%7Ca652971c7d2e4d9ba6a4d1492
> 56f461b%7C0%7C0%7C637191016800944332&amp;sdata=AL6s1X0NFyBtAi%2
> BfFS%2FwB41xHZBUQsvDUZ5%2FWucJTd0%3D&amp;reserved=0
> 
> v2:
> * change the patch title
> ---
>  drivers/common/mlx5/mlx5_common.c | 10 +++++++---
>  drivers/net/mlx4/mlx4.c           |  4 +++-
>  2 files changed, 10 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/common/mlx5/mlx5_common.c
> b/drivers/common/mlx5/mlx5_common.c
> index 610fb48..9ea56f2 100644
> --- a/drivers/common/mlx5/mlx5_common.c
> +++ b/drivers/common/mlx5/mlx5_common.c
> @@ -2,10 +2,12 @@
>   * Copyright 2019 Mellanox Technologies, Ltd
>   */
> 

Patch applied to next-net-mlx,

Kindest regards,
Raslan Darawsheh