From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 94CA1A058A; Sun, 12 Apr 2020 17:51:51 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3F94B293C; Sun, 12 Apr 2020 17:51:50 +0200 (CEST) Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-eopbgr150049.outbound.protection.outlook.com [40.107.15.49]) by dpdk.org (Postfix) with ESMTP id 85FB91B53 for ; Sun, 12 Apr 2020 17:51:48 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IpUPT4KPft78DxhmsMkRrtDc83IyapqfypZseYJPDXZGwLYVs28YygGsaCOG7LBCONnepTVIo56GXG+qQRIxhnWwRNuNF6gP02jcbkZeNU5vhTuhAWeIYB7jk9VW+JS7G08sqVBiEQPyAdGJID+y+Z4c9YlVUxRFWuNzBFprlZKn85JMm4HLPiQjr2ppseXnE8sg5IQPquwYV9NwDsfp1lS5IgOY9SNY0fiOsuzH+eA4ZkCTNpWhk+IqjFlTk71vPRoMYXAE5jI2m+lvDW2bFrwBuRoSibhac8BGUAe8qcNWtydBbmOQrAekrnkq01JRvAiomQ9R9WYQSz5tl5pH4g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AVoYeeEAeQksbxMc2pVzT8smANSzdNUq36mIlzk4fO4=; b=bQYwOPlKth8clI1//5vGrNnypffIgsD6MclmzKanWfP6As5lx1WHU1WQEZ29p5AqJTdBm08UDX2ZxRrGvQ4qmSv8OZ+2ZHjxmBQZl+eMxeAhtuINl03+h99MPSccQ/2TWgAzSFiNyfginjDvuTa83lwTtbYPzo5Qfz5YLuVH2sjfxyJR1hDUaAJXYEsBfwIbYBuLTK1GKJQ4W3Uvp9t+WYjf4KqlWbtVEtDW0mcG23clEQQ63ayFU0pkMffssYugO5TIGDiHtmlLGVKkGv7F86/mN8GE3dmUaWhdrH7tcQb6wbWvSw17mTLXuJMmfIz3X+Px9he17WzDazc0MQxa5A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AVoYeeEAeQksbxMc2pVzT8smANSzdNUq36mIlzk4fO4=; b=FV0tDaxavoZw34I4q/lfOBvJA8bt7UFKFByRzDUi+j+fjR5kX99XSuvXg8osLU1w5fzSB1lGhsubeAvS3/3PyfmxNF05djuaqfscqS/oIh+WG/dHIZGZvL2lCvB9WnSj/bsvH1un+1TIuSnE1yzWf63F7uk4SlMXmfI0f93TOkE= Received: from AM0PR05MB6707.eurprd05.prod.outlook.com (2603:10a6:20b:15b::17) by AM0PR05MB6148.eurprd05.prod.outlook.com (2603:10a6:208:11b::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2900.15; Sun, 12 Apr 2020 15:51:47 +0000 Received: from AM0PR05MB6707.eurprd05.prod.outlook.com ([fe80::508:747b:cc12:5f6e]) by AM0PR05MB6707.eurprd05.prod.outlook.com ([fe80::508:747b:cc12:5f6e%6]) with mapi id 15.20.2900.028; Sun, 12 Apr 2020 15:51:47 +0000 From: Raslan Darawsheh To: Thomas Monjalon , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v3 0/3] mlx: fix build with -fno-common (gcc 10) Thread-Index: AQHWDTnzqw4CPcsCB0eH2J7A3X/iWqh1qgBA Date: Sun, 12 Apr 2020 15:51:47 +0000 Message-ID: References: <20200210103216.1168439-1-thomas@monjalon.net> <20200408000900.61896-1-thomas@monjalon.net> In-Reply-To: <20200408000900.61896-1-thomas@monjalon.net> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=rasland@mellanox.com; x-originating-ip: [188.161.230.106] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 2a2afc49-29dd-4c62-fccf-08d7def9683f x-ms-traffictypediagnostic: AM0PR05MB6148: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2803; x-forefront-prvs: 0371762FE7 x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM0PR05MB6707.eurprd05.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(10009020)(4636009)(39860400002)(366004)(346002)(396003)(376002)(136003)(86362001)(6506007)(53546011)(81156014)(33656002)(8936002)(71200400001)(26005)(8676002)(478600001)(7696005)(55016002)(9686003)(66556008)(66946007)(64756008)(66476007)(66446008)(110136005)(76116006)(186003)(5660300002)(316002)(2906002)(52536014); DIR:OUT; SFP:1101; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: GXXHiDLCQvK+FV/y6z+RDVkd1nntuaUvLRBE6Fq1DRA+KexfM7XnzNZwkX0/RDwdslBi+DGFXHcgS2KtokBGLzaHc9UZjo1SNHCphO2Nl+2ps5SyqlcbxoPVsQYzK++Rh7hYMJWHjNLyd1Oa8tVml4idM103mcffsKvlsnSK6I2N5SEk2E3bD0BRX7+LjEtCz1TqRPDVO+z0/UNA0o6gfXgoI1WJIGQNkl5w3d/DISMKI4FiWrsh2Lh8MRP4UOKKmJ+LoWwxkfHX2FplTXO7FGrhWpmYWJ+wuFVuP1R6jo2e4YIKHXD/RL1jpWdKl5XhBaV0US2JwUF2MGIlCFj0R8lfgDb3ycqRZ2kMbbGtWSgeVQbUIjSAuBPB4lQGyW81sBoLjBRkv3S564T6GYlQRt0zGcRFIkYQBvEh6km4iZ3jWOo0Xme1PD8Jy4alG3R2 x-ms-exchange-antispam-messagedata: i+zCkD+N/e/atXhpDgut4gkVhch39j9YuWgmQdpICAV3V12tvWs5YbqADKkdW37Yee1K7RIRD5iBwJ+/X4FcWMUS+Qmwl8Qjya9vbNYsDyArHf+RRJupHstMffY5b4cnW8/FPXjakaOTHsXBpF2jXw== x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2a2afc49-29dd-4c62-fccf-08d7def9683f X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Apr 2020 15:51:47.2575 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: WpSf+HBuTnrhWwieiRXgxGXYt8Nrj1OB0UeM2KHaQptg8ibpeBGBJWHJ2Ena+/8pYbbLz5sx6M0Hj3Nt+nhUgA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR05MB6148 Subject: Re: [dpdk-dev] [PATCH v3 0/3] mlx: fix build with -fno-common (gcc 10) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, > -----Original Message----- > From: dev On Behalf Of Thomas Monjalon > Sent: Wednesday, April 8, 2020 3:09 AM > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH v3 0/3] mlx: fix build with -fno-common (gcc 1= 0) >=20 > In GCC 10, -fno-common will be the default. > There are 2 ways of solving issues: > - add -fcommon > - stop allocating variables in .h files >=20 > In this patchset, the variables are declared extern, > because it is cleaner anyway. >=20 >=20 > v2: do not initialize global variables and Cc stable > v3: fix rebase >=20 >=20 > Thomas Monjalon (3): > common/mlx5: split glue initialization > common/mlx5: fix build with -fno-common > net/mlx4: fix build with -fno-common >=20 > drivers/common/mlx5/mlx5_common.c | 82 +++++++++++++++++++-------- > ---- > drivers/common/mlx5/mlx5_glue.h | 2 +- > drivers/net/mlx4/mlx4.c | 4 ++ > drivers/net/mlx4/mlx4_glue.h | 2 +- > drivers/net/mlx4/mlx4_rxtx.h | 2 +- > 5 files changed, 57 insertions(+), 35 deletions(-) >=20 > -- > 2.26.0 Series applied to next-net-mlx, Kindest regards, Raslan Darawsheh