* [dpdk-dev] [PATCH] net/mlx5: fix legacy non inline multi packet session
@ 2020-02-12 17:49 Viacheslav Ovsiienko
2020-02-13 9:38 ` Raslan Darawsheh
0 siblings, 1 reply; 3+ messages in thread
From: Viacheslav Ovsiienko @ 2020-02-12 17:49 UTC (permalink / raw)
To: dev; +Cc: matan, rasland, orika
The commit being fixed introduced the different format
for the transmitting descriptor multi-packet session for
ConnectX-4LX. The session was assumed always opened if
not-inlinable packet was encountered. The patch checks
whether the inline multi-packet is opened and it allows
to proceed with normal packets (non inlined) successfully.
Fixes: 82a506b404b0 ("net/mlx5: fix the legacy multi packet write session")
Signed-off-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com>
---
drivers/net/mlx5/mlx5_rxtx.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/mlx5/mlx5_rxtx.c b/drivers/net/mlx5/mlx5_rxtx.c
index 86e0fab..b55db4f 100644
--- a/drivers/net/mlx5/mlx5_rxtx.c
+++ b/drivers/net/mlx5/mlx5_rxtx.c
@@ -4341,6 +4341,7 @@ enum mlx5_txcmp_code {
* intermix for legacy MPW sessions.
*/
if (MLX5_TXOFF_CONFIG(MPW) &&
+ part != room &&
loc->wqe_last->dseg[0].bcount == RTE_BE32(0))
break;
/*
--
1.8.3.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH] net/mlx5: fix legacy non inline multi packet session
2020-02-12 17:49 [dpdk-dev] [PATCH] net/mlx5: fix legacy non inline multi packet session Viacheslav Ovsiienko
@ 2020-02-13 9:38 ` Raslan Darawsheh
2020-02-13 11:30 ` Ferruh Yigit
0 siblings, 1 reply; 3+ messages in thread
From: Raslan Darawsheh @ 2020-02-13 9:38 UTC (permalink / raw)
To: Slava Ovsiienko, dev; +Cc: Matan Azrad, Ori Kam
Hi,
> -----Original Message-----
> From: Viacheslav Ovsiienko <viacheslavo@mellanox.com>
> Sent: Wednesday, February 12, 2020 7:49 PM
> To: dev@dpdk.org
> Cc: Matan Azrad <matan@mellanox.com>; Raslan Darawsheh
> <rasland@mellanox.com>; Ori Kam <orika@mellanox.com>
> Subject: [PATCH] net/mlx5: fix legacy non inline multi packet session
>
> The commit being fixed introduced the different format
> for the transmitting descriptor multi-packet session for
> ConnectX-4LX. The session was assumed always opened if
> not-inlinable packet was encountered. The patch checks
> whether the inline multi-packet is opened and it allows
> to proceed with normal packets (non inlined) successfully.
>
> Fixes: 82a506b404b0 ("net/mlx5: fix the legacy multi packet write session")
>
Added Cc: stable@dpdk.org
> Signed-off-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com>
> ---
> drivers/net/mlx5/mlx5_rxtx.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/mlx5/mlx5_rxtx.c b/drivers/net/mlx5/mlx5_rxtx.c
> index 86e0fab..b55db4f 100644
> --- a/drivers/net/mlx5/mlx5_rxtx.c
> +++ b/drivers/net/mlx5/mlx5_rxtx.c
> @@ -4341,6 +4341,7 @@ enum mlx5_txcmp_code {
> * intermix for legacy MPW sessions.
> */
> if (MLX5_TXOFF_CONFIG(MPW) &&
> + part != room &&
> loc->wqe_last->dseg[0].bcount == RTE_BE32(0))
> break;
> /*
> --
> 1.8.3.1
Patch applied next-net-mlx,
Kindest regards,
Raslan Darawsheh
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH] net/mlx5: fix legacy non inline multi packet session
2020-02-13 9:38 ` Raslan Darawsheh
@ 2020-02-13 11:30 ` Ferruh Yigit
0 siblings, 0 replies; 3+ messages in thread
From: Ferruh Yigit @ 2020-02-13 11:30 UTC (permalink / raw)
To: Raslan Darawsheh, Slava Ovsiienko, dev; +Cc: Matan Azrad, Ori Kam
On 2/13/2020 9:38 AM, Raslan Darawsheh wrote:
> Hi,
>
>> -----Original Message-----
>> From: Viacheslav Ovsiienko <viacheslavo@mellanox.com>
>> Sent: Wednesday, February 12, 2020 7:49 PM
>> To: dev@dpdk.org
>> Cc: Matan Azrad <matan@mellanox.com>; Raslan Darawsheh
>> <rasland@mellanox.com>; Ori Kam <orika@mellanox.com>
>> Subject: [PATCH] net/mlx5: fix legacy non inline multi packet session
>>
>> The commit being fixed introduced the different format
>> for the transmitting descriptor multi-packet session for
>> ConnectX-4LX. The session was assumed always opened if
>> not-inlinable packet was encountered. The patch checks
>> whether the inline multi-packet is opened and it allows
>> to proceed with normal packets (non inlined) successfully.
>>
>> Fixes: 82a506b404b0 ("net/mlx5: fix the legacy multi packet write session")
>>
> Added Cc: stable@dpdk.org
>
>> Signed-off-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com>
>> ---
>> drivers/net/mlx5/mlx5_rxtx.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/net/mlx5/mlx5_rxtx.c b/drivers/net/mlx5/mlx5_rxtx.c
>> index 86e0fab..b55db4f 100644
>> --- a/drivers/net/mlx5/mlx5_rxtx.c
>> +++ b/drivers/net/mlx5/mlx5_rxtx.c
>> @@ -4341,6 +4341,7 @@ enum mlx5_txcmp_code {
>> * intermix for legacy MPW sessions.
>> */
>> if (MLX5_TXOFF_CONFIG(MPW) &&
>> + part != room &&
>> loc->wqe_last->dseg[0].bcount == RTE_BE32(0))
>> break;
>> /*
>> --
>> 1.8.3.1
>
>
> Patch applied next-net-mlx,
>
Squashed into relevant commit in next-net, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-02-13 11:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-12 17:49 [dpdk-dev] [PATCH] net/mlx5: fix legacy non inline multi packet session Viacheslav Ovsiienko
2020-02-13 9:38 ` Raslan Darawsheh
2020-02-13 11:30 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).