From: Raslan Darawsheh <rasland@mellanox.com>
To: Matan Azrad <matan@mellanox.com>,
Slava Ovsiienko <viacheslavo@mellanox.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, Eli Britstein <elibr@mellanox.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix zero out UDP checksum in encap data
Date: Sun, 26 Jan 2020 16:19:25 +0000 [thread overview]
Message-ID: <AM0PR05MB6707EAB451103966C6388022C2080@AM0PR05MB6707.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <1579705438-31330-1-git-send-email-matan@mellanox.com>
Hi,
> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Matan Azrad
> Sent: Wednesday, January 22, 2020 5:04 PM
> To: Slava Ovsiienko <viacheslavo@mellanox.com>
> Cc: dev@dpdk.org; Eli Britstein <elibr@mellanox.com>; stable@dpdk.org
> Subject: [dpdk-dev] [PATCH] net/mlx5: fix zero out UDP checksum in encap
> data
>
> From: Eli Britstein <elibr@mellanox.com>
>
> The cited commit zeroed the UDP checksum for raw-encap case. Add the
> same handling for vxlan-encap case.
>
> Fixes: bf1d7d9a033a ("net/mlx5: zero out UDP checksum in encapsulation")
> Cc: stable@dpdk.org
>
> Signed-off-by: Eli Britstein <elibr@mellanox.com>
> Acked-by: Matan Azrad <matan@mellanox.com>
> ---
> drivers/net/mlx5/mlx5_flow_dv.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/mlx5/mlx5_flow_dv.c
> b/drivers/net/mlx5/mlx5_flow_dv.c
> index 5a1b426..367e7d7 100644
> --- a/drivers/net/mlx5/mlx5_flow_dv.c
> +++ b/drivers/net/mlx5/mlx5_flow_dv.c
> @@ -2931,8 +2931,6 @@ struct field_modify_info modify_tcp[] = {
> (const struct rte_flow_action_raw_encap *)action-
> >conf;
> res.size = raw_encap_data->size;
> memcpy(res.buf, raw_encap_data->data, res.size);
> - if (flow_dv_zero_encap_udp_csum(res.buf, error))
> - return -rte_errno;
> } else {
> if (action->type ==
> RTE_FLOW_ACTION_TYPE_VXLAN_ENCAP)
> encap_data =
> @@ -2946,6 +2944,8 @@ struct field_modify_info modify_tcp[] = {
> &res.size, error))
> return -rte_errno;
> }
> + if (flow_dv_zero_encap_udp_csum(res.buf, error))
> + return -rte_errno;
> if (flow_dv_encap_decap_resource_register(dev, &res, dev_flow,
> error))
> return rte_flow_error_set(error, EINVAL,
> RTE_FLOW_ERROR_TYPE_ACTION,
> --
> 1.8.3.1
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
prev parent reply other threads:[~2020-01-26 16:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-22 15:03 Matan Azrad
2020-01-26 16:19 ` Raslan Darawsheh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM0PR05MB6707EAB451103966C6388022C2080@AM0PR05MB6707.eurprd05.prod.outlook.com \
--to=rasland@mellanox.com \
--cc=dev@dpdk.org \
--cc=elibr@mellanox.com \
--cc=matan@mellanox.com \
--cc=stable@dpdk.org \
--cc=viacheslavo@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).